From: Marek Vasut <marex@denx.de>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-leds@vger.kernel.org
Cc: kernel@dh-electronics.com, Conor Dooley <conor+dt@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Document "netdev" trigger
Date: Mon, 8 Jul 2024 13:47:21 +0200 [thread overview]
Message-ID: <800e848c-9cf7-4ded-aa44-a132cdc302af@denx.de> (raw)
In-Reply-To: <9a0b596a-82ab-4731-8a48-88b02e48395b@kernel.org>
On 7/8/24 8:18 AM, Krzysztof Kozlowski wrote:
> On 07/07/2024 21:49, Marek Vasut wrote:
>> On 7/7/24 3:49 PM, Krzysztof Kozlowski wrote:
>>> On 05/07/2024 23:52, Marek Vasut wrote:
>>>> Document the "netdev" trigger which is used to control LEDs by
>>>> network device activity.
>>>
>>> Instead, please propose a patch adding a comment there (in that place):
>>> "# netdev - not accepted, please do not add it"
>>>
>>> This is like fourth or fifth attempt.
>>>
>>> https://lore.kernel.org/all/20230217230346.GA2217008-robh@kernel.org/
>>
>> There is a follow up to that discussion:
>>
>> https://lore.kernel.org/all/20230221014413.GA780723-robh@kernel.org/
>>
>> That netdev trigger is nothing new, there are existing DTs using that
>> trigger in-tree going back to 2019, this is only documenting it.
>>
>> So, shall I really add a comment or update the commit message ?
>
> I was not aware that discussion, so it seems commit will be fine, but
> with updated message.
V2 with slightly expanded commit message sent, thanks !
prev parent reply other threads:[~2024-07-08 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 21:52 [PATCH] dt-bindings: leds: Document "netdev" trigger Marek Vasut
2024-07-07 13:49 ` Krzysztof Kozlowski
2024-07-07 19:49 ` Marek Vasut
2024-07-08 6:18 ` Krzysztof Kozlowski
2024-07-08 11:47 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=800e848c-9cf7-4ded-aa44-a132cdc302af@denx.de \
--to=marex@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).