From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Kun Yi <kunyi@google.com>, linux-leds@vger.kernel.org
Cc: pavel@ucw.cz, dmurphy@ti.com, u.kleine-koenig@pengutronix.de,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 0/2] Fix LED GPIO trigger behavior
Date: Fri, 17 May 2019 18:56:17 +0200 [thread overview]
Message-ID: <87d5d4a6-857b-b362-baaf-3a004ee51d49@gmail.com> (raw)
In-Reply-To: <20190516214209.139726-1-kunyi@google.com>
Cc Linus Walleij and leds-gpio@vger.kernel.org.
On 5/16/19 11:42 PM, Kun Yi wrote:
> *** BLURB HERE ***
> Hello there,
>
> I recently tested ledtrig-gpio on an embedded controller and one of the
> issues I had involve not requesting the user input pin as GPIO.
>
> In many embedded systems, a pin could be muxed as several functions, and
> requesting the pin as GPIO is necessary to let pinmux select the pin as
> a GPIO instead of, say an I2C pin. I'd like to learn whether it is appropriate
> to assume user of ledtrig-gpio really intends to use GPIOs and not some
> weird pins that are used as other functions.
>
> Kun Yi (2):
> ledtrig-gpio: Request user input pin as GPIO
> ledtrig-gpio: 0 is a valid GPIO number
>
> drivers/leds/trigger/ledtrig-gpio.c | 35 ++++++++++++++++++++---------
> 1 file changed, 24 insertions(+), 11 deletions(-)
>
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-05-17 16:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 21:42 [PATCH 0/2] Fix LED GPIO trigger behavior Kun Yi
2019-05-16 21:42 ` [PATCH 1/2] ledtrig-gpio: Request user input pin as GPIO Kun Yi
2019-05-17 6:26 ` Uwe Kleine-König
2019-05-16 21:42 ` [PATCH 2/2] ledtrig-gpio: 0 is a valid GPIO number Kun Yi
2019-05-17 6:27 ` Uwe Kleine-König
2019-05-17 16:56 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d5d4a6-857b-b362-baaf-3a004ee51d49@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=kunyi@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox