public inbox for linux-leds@vger.kernel.org
 help / color / mirror / Atom feed
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org, Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [lee-leds:for-leds-next] BUILD REGRESSION e257dc532c20bd93f0076c18cb5ffd739a5f0bb4
Date: Mon, 19 Jan 2026 09:40:44 +0100	[thread overview]
Message-ID: <87v7gy6lmb.fsf@pengutronix.de> (raw)
In-Reply-To: <20260113105722.GC1902656@google.com> (Lee Jones's message of "Tue, 13 Jan 2026 10:57:22 +0000")

On 2026-01-13 at 10:57 GMT, Lee Jones <lee@kernel.org> wrote:

Hi Lee,

> +Steffen
> 
> > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
> > branch HEAD: e257dc532c20bd93f0076c18cb5ffd739a5f0bb4  leds: lp55xx: Simplify with scoped for each OF child loop
> > 
> > Error/Warning (recently discovered and may have been fixed):
> > 
> >     ERROR: modpost: "lp5860_device_init" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!
> >     ERROR: modpost: "lp5860_device_remove" [drivers/leds/rgb/leds-lp5860-spi.ko] undefined!

hm, I'm not sure I understand why this is happening for some of the defconfigs.

> >     drivers/leds/rgb/leds-lp5860-core.c:72:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> >     drivers/leds/rgb/leds-lp5860-core.c:72:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> >

okay. This one is easy. Of course I should return the ret from the regmap_read on error.
Should I send a fixup! for your next-branch or a patch that fixes it?

> >     drivers/leds/rgb/leds-lp5860-spi.c:87:1: sparse: sparse: bad integer constant expression

Looks like a false positive to me. That's the MODULE_AUTHOR line.


Best regards,
Steffen

-- 
Pengutronix e.K.                | Dipl.-Inform. Steffen Trumtrar |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |

  reply	other threads:[~2026-01-19  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10 16:59 [lee-leds:for-leds-next] BUILD REGRESSION e257dc532c20bd93f0076c18cb5ffd739a5f0bb4 kernel test robot
2026-01-13 10:57 ` Lee Jones
2026-01-19  8:40   ` Steffen Trumtrar [this message]
2026-01-19 11:43     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7gy6lmb.fsf@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox