From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F207CC433E1 for ; Fri, 5 Jun 2020 12:42:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBE392065C for ; Fri, 5 Jun 2020 12:42:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="U+K1MK30" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbgFEMmv (ORCPT ); Fri, 5 Jun 2020 08:42:51 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:33110 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726409AbgFEMmv (ORCPT ); Fri, 5 Jun 2020 08:42:51 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 055Cgjed040494; Fri, 5 Jun 2020 07:42:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1591360965; bh=oT1gIBxDDUEHLfBPD+U2tTYn+54H+gzmNsjUa42oJTI=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=U+K1MK30/03I0t/wRyi73OF265yw11zdP54ULxAbvMhKNLkLMsnNAlWiYA0H7vLqi MMzFsMl4Qd41UpXPE/e7DKIWGrS0Wh35/tRJXe7OVNRGxxSc6bNJMdiKEg/ABI7Gvk 6rx1gjhrlvHjXJm+bNvaHMBF6MXSy8C3GJX3whOg= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 055CgjWU068954 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Jun 2020 07:42:45 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 5 Jun 2020 07:42:45 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 5 Jun 2020 07:42:45 -0500 Received: from [10.250.52.63] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 055Cgi4D020074; Fri, 5 Jun 2020 07:42:45 -0500 Subject: Re: [PATCH v26 01/15] dt: bindings: Add multicolor class dt bindings documention To: Rob Herring CC: , , , , References: <20200604120504.32425-1-dmurphy@ti.com> <20200604120504.32425-2-dmurphy@ti.com> <20200604224026.GA4153787@bogus> From: Dan Murphy Message-ID: <8b32231a-90d8-258e-d828-362af8cbfbb5@ti.com> Date: Fri, 5 Jun 2020 07:42:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200604224026.GA4153787@bogus> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Rob On 6/4/20 5:40 PM, Rob Herring wrote: > On Thu, Jun 04, 2020 at 07:04:50AM -0500, Dan Murphy wrote: >> Add DT bindings for the LEDs multicolor class framework. >> Add multicolor ID to the color ID list for device tree bindings. >> >> CC: Rob Herring >> Acked-by: Pavel Machek >> Acked-by: Jacek Anaszewski >> Signed-off-by: Dan Murphy >> --- >> .../bindings/leds/leds-class-multicolor.yaml | 39 +++++++++++++++++++ >> include/dt-bindings/leds/common.h | 3 +- >> 2 files changed, 41 insertions(+), 1 deletion(-) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >> new file mode 100644 >> index 000000000000..6cab2a1405e1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >> @@ -0,0 +1,39 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/leds/leds-class-multicolor.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Common properties for the multicolor LED class. >> + >> +maintainers: >> + - Dan Murphy >> + >> +description: | >> + Bindings for multi color LEDs show how to describe current outputs of >> + either integrated multi-color LED elements (like RGB, RGBW, RGBWA-UV >> + etc.) or standalone LEDs, to achieve logically grouped multi-color LED >> + modules. This is achieved by adding multi-led nodes layer to the >> + monochrome LED bindings. >> + The nodes and properties defined in this document are unique to the multicolor >> + LED class. Common LED nodes and properties are inherited from the common.txt >> + within this documentation directory. >> + >> +patternProperties: >> + "^multi-led@([0-9a-f])$": >> + type: object >> + description: Represents the LEDs that are to be grouped. >> + properties: >> + #allOf: >> + #- $ref: "common.yaml#" > Why is this commented out? Other than it is wrong. Uncommented, this > would be defining a DT property called 'allOf'. > > You can drop 'allOf' now. '$ref' should be at the level of 'properties'. I used the example from the rohm,bd71828-leds.yaml where these lines appear. So that binding is wrong as well. >> + >> + color: >> + $ref: /schemas/types.yaml#definitions/uint32 > common.yaml already defines the type, so drop this. OK Dan