From: Naresh Solanki <naresh.solanki@9elements.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Lee Jones <lee@kernel.org>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 2/2] leds: max597x: Add support for max597x
Date: Fri, 24 Mar 2023 19:20:31 +0530 [thread overview]
Message-ID: <8b3cb61c-8824-e358-a039-012471d679f2@9elements.com> (raw)
In-Reply-To: <ZB2gdvgFR4ZTIegA@duo.ucw.cz>
Hi Christophe, Pavel,
On 24-03-2023 06:37 pm, Pavel Machek wrote:
> Hi!
>
>>>> +++ b/drivers/leds/Kconfig
>>>> @@ -590,6 +590,17 @@ config LEDS_ADP5520
>>>> To compile this driver as a module, choose M here: the
>>>> module will
>>>> be called leds-adp5520.
>>>> +config LEDS_MAX597X
>>>> + tristate "LED Support for Maxim 597x"
>>>> + depends on LEDS_CLASS
>>>> + depends on MFD_MAX597X
>>>> + help
>>>> + This option enables support for the Maxim 597x smart switch
>>>> indication LEDs
>>>> + via the I2C bus.
>>>> +
>>>> + To compile this driver as a module, choose M here: the module will
>>>> + be called max597x-led.
>>>
>>> leds-max597x?
>> As per struct max597x_led_driver, driver name is max597x-led
>
> Please test the modular build and double check the module name.
Thank you for your suggestion, it turns out that you were right. The
correct module name is leds-max597x(./drivers/leds/leds-max597x.ko).
Will update Kconfig message accordingly. Thanks!
>
> BR,
> Pavel
>
Regards,
Naresh
next prev parent reply other threads:[~2023-03-24 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230323194550.1914725-1-Naresh.Solanki@9elements.com>
2023-03-23 19:45 ` [PATCH v2 2/2] leds: max597x: Add support for max597x Naresh Solanki
2023-03-23 20:18 ` Christophe JAILLET
2023-03-24 10:54 ` Naresh Solanki
2023-03-24 13:07 ` Pavel Machek
2023-03-24 13:50 ` Naresh Solanki [this message]
2023-03-24 15:36 ` Christophe JAILLET
2023-03-27 15:47 ` Naresh Solanki
2023-03-27 17:20 ` Christophe JAILLET
2023-03-27 17:49 ` Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b3cb61c-8824-e358-a039-012471d679f2@9elements.com \
--to=naresh.solanki@9elements.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox