From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Life is hard, and then you die" <ronald@innovation.ch>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, linux-leds@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [j.anaszewski-leds:for-next 15/49] drivers/input/keyboard/applespi.c:1789: undefined reference to `devm_led_classdev_register_ext'
Date: Tue, 27 Aug 2019 21:39:37 +0200 [thread overview]
Message-ID: <91bbf77a-d1ac-46ed-5e8f-064e7b2a9a8b@gmail.com> (raw)
In-Reply-To: <20190827064630.GA15193@innovation.ch>
On 8/27/19 8:46 AM, Life is hard, and then you die wrote:
>
> Hi Jacek,
>
> On Sun, Aug 25, 2019 at 12:58:59AM +0200, Jacek Anaszewski wrote:
>>
>> You're missing LEDS_CLASS dependency in Kconfig:
>>
>> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
>> index 8e9c3ea9d5e7..96285e071ee1 100644
>> --- a/drivers/input/keyboard/Kconfig
>> +++ b/drivers/input/keyboard/Kconfig
>> @@ -76,6 +76,7 @@ config KEYBOARD_APPLESPI
>> depends on ACPI && EFI
>> depends on SPI
>> depends on X86 || COMPILE_TEST
>> + depends on LEDS_CLASS
>> help
>> Say Y here if you are running Linux on any Apple MacBook8,1 or
>> later,
>> or any MacBookPro13,* or MacBookPro14,*.
>
> This patch is already present in v5.3-rc4 - I can't tell from the
> below what version you were testing, but apparently an older one?
I received this message from kbuild test robot <lkp@intel.com>,
that tested for-next branch of linux-leds.git which is based on rc1.
But I see it fixed indeed in mainline, so that's no longer an issue.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-08-27 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 22:03 [j.anaszewski-leds:for-next 15/49] drivers/input/keyboard/applespi.c:1789: undefined reference to `devm_led_classdev_register_ext' kbuild test robot
2019-08-24 22:58 ` Jacek Anaszewski
2019-08-27 6:46 ` Life is hard, and then you die
2019-08-27 19:39 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91bbf77a-d1ac-46ed-5e8f-064e7b2a9a8b@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ronald@innovation.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox