From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B8F0C4332F for ; Sat, 4 Nov 2023 15:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229490AbjKDP1w (ORCPT ); Sat, 4 Nov 2023 11:27:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjKDP1w (ORCPT ); Sat, 4 Nov 2023 11:27:52 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 074991BF; Sat, 4 Nov 2023 08:27:49 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c59a4dd14cso40641001fa.2; Sat, 04 Nov 2023 08:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699111667; x=1699716467; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=+tyDOuBxTyUIj1x+uacPNDMwWcoDqqrQlj8bnqnWq7E=; b=hNZABKL8By3XWU/+LDf/cnK7ggQgoQ+0KwT6uEz6haHqxXmVnriiH8tBoFri2HrJSl DdmnRmVtHTDvsuAy9IcLIE2d8KlbI6t4aDOBlR24SOVNAx150/06x6cs0TBnLnnBrchu VEHkUYSoeDWkb3HC5ddZmp6OWYQng0ayf1CMWT6CXb5feBkGP9CSj8+vkostIesEynLW r03IA3wYqomOrDC1gfSUmydN5U9iGdOiB/BDTPeD2wZ/7CmpYTXhA6xi0VKzhpzGJfU0 ABEwr983VFUlDBXxmhWQDlgPrau6ttf/M9JnKyibedfJRLEKsH56sR4YcG0nKjQBU7sq G8Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699111667; x=1699716467; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+tyDOuBxTyUIj1x+uacPNDMwWcoDqqrQlj8bnqnWq7E=; b=otmVKsuPdBSmy3Z8dAYbn4iGjZ+qOof0Tklep6p8jvH/a3GCK4LwP2C8EQxF3VrI8Y 3P3QWrQCXboW/D5pZc/ZePpyIYv8fCp2F38NsRkE9v9uSoRysf0FfpG1UvhVfo92D4t0 VeLkvQtaWboYiwf+oblE8Y26frjZc01zQVvylis1ig7mVk9qlh3RZ7GZcq4oroumL1VG RgH+KZmzCg/Rthz9q2uQnYeRV1tTH+i05err1cIu7HXzqErF5jfTkF/IaaQwGzqprsVh TASa5OEQgtEu6Dn9RGClVi1MwZPtgTtzUEyLn8WAPJ3blhqzOddvRqmGXbZ5ebk86omo hkfA== X-Gm-Message-State: AOJu0YzBRGbQrUBkQbacqjK26sGMMQA8hmcIJWf4xGKsP+d6+bNeGzrx nf8lrcL/QoEZ6kxF5JgL5GA= X-Google-Smtp-Source: AGHT+IG3mIQ8pnIx3+BkgcgZb3TPa6WBur6aDF8NdQgwZhBbhP8wL9T2Gw1B8JyOuwbuUDq5hifzuQ== X-Received: by 2002:a2e:9015:0:b0:2c5:4a0:f3cb with SMTP id h21-20020a2e9015000000b002c504a0f3cbmr18536467ljg.11.1699111666875; Sat, 04 Nov 2023 08:27:46 -0700 (PDT) Received: from ?IPv6:2a02:168:6806:0:e018:7b08:28f0:78c5? ([2a02:168:6806:0:e018:7b08:28f0:78c5]) by smtp.gmail.com with ESMTPSA id n5-20020a05600c3b8500b004064e3b94afsm6233738wms.4.2023.11.04.08.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 08:27:46 -0700 (PDT) Message-ID: <95ff53a1d1b9102c81a05076f40d47242579fc37.camel@gmail.com> Subject: Re: [PATCH] leds: triggers: netdev: add a check, whether device is up From: Klaus Kudielka To: Andrew Lunn Cc: Pavel Machek , Lee Jones , Christian Marangi , "David S . Miller" , Jakub Kicinski , Samuel Holland , Jisheng Zhang , Li Zetao , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 04 Nov 2023 16:27:45 +0100 In-Reply-To: <0e3fb790-74f2-4bb3-b41e-65baa3b00093@lunn.ch> References: <20231104125840.27914-1-klaus.kudielka@gmail.com> <0e3fb790-74f2-4bb3-b41e-65baa3b00093@lunn.ch> Autocrypt: addr=klaus.kudielka@gmail.com; prefer-encrypt=mutual; keydata=mQINBFd7/7YBEACdN4Zcl5NXaWFIIhNVEmpUzE2kMmRaJgvZ6Wf2ZuNRF/7N/CuIRAy//MLAaavZt0PjGAfNWtjHPVXMX3TDxSU2g6+djn2IAy8ok7wU+/CLKSTdmjDsz6f6dwltx7NHIOULaOrKFXx0qGWtAjJk1KV/B6YaggKVdIX7FfAVcdFq0B2oI3xbjOLYuKK1Kl+P9JurYQIXD1HuN932ECHLj7CPdR6qM8CEUggtbaLeBezEHkE6rqxN6tV+j8OtU4m9IR2JgWNWXLT/Zq3JMtl7ye+zo0/FegNT3ApqDDXCLF6K5XbdCXDTraec4fe7/098l74dYMIq/qpc6SdI0LbbMJTNWXvqr22OeHE/8mHH9A1BB8kwqEBHjwQtk0zxR9YV4LkBaB+fZ63zy7NSm5eEPiMQHHw/68vFmNlZxZcyJ/Aqn3wjVONDkPtz7ntJvp5yuaezUXaNf12SDCFgZODj+hNAA1RkUORblFNxXgYk7tqTsb0xNIg86QVdjJizONnE+0UKXhr8wXJZkIMNkEv80F4dfBHE3jXLwpo8oF5oR11E5e4Y6Bh4JPSz45cQqpONlKNDBTfn0L5oo0wo7L1NuqcqlEuK0PHhrHzdruIs20Xj8I4a8bysJOSk5n/fI7GuSDkpbWXMCGwVkFwbHO0zLYV8wH4NZplirLwXUW3PZA8VNwARAQABtClLbGF1cyBLdWRpZWxrYSA8a2xhdXMua3VkaWVsa2FAZ21haWwuY29tPokCNwQTAQgAIQUCV3v/tgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRCZQcBXr2xWjGO0D/9QPkRgENHGSt3ymdfvDi7zKlCRPbtOGBrMEf6Sh1CYBbxXe4RC8168GhcXNeOJ8H0qA5496IopSzP+eKECfsy9S xTQYo6SQH5uxdYSsvog3yk7q93BIp2IO+G37Dns54h2Hy/IeMp0FAmzo3U1fkckd b1CbgXRTrvKI/uPjyPrgYBOEZKj4mKhD0mUQt5kP0pnBa43ALGn/VbRsGsoNhlt5YaT0YGByLVZch1xomjV9Ln8iam1ksSMjFRaXD6hqcDqMzt3OtrEuFtSMYoyekcXtk5WT68nN+tbCVJ5ke1zFs2J3pP5BjqZybSAAGiFfA8BFaR+SMgVvnXCYd7kfEMX7pILlvxMo/cl0A3sQUzYJ8Y2pybWZvc/SsqW+lGJX2hWZdr5w5nQ1D/FfssaCuWU5IAB7Y0s/PdvBF6KSlqExMTL0ErDyuYxDYfRzeZY89NSPyL+zHvencg/azF/hvGXCSEGZMZq82No67DjPwb/Dov7Eh0WWXtw9kc34LJIzXfOz0FKeMws+RmGRoss0L+abM2RMg1jgQii3Df1vj3wzbuScmWABAOlNtWVqtF3J1K4dYVwAw5zcvz7zTLUk22CMb1RZ0L0AuL7ZKnNg9MT+A8maQzrPeBTdNKq0uFZ/UDQTF96IVDo2CEzcEGaA7UMjP2tk2l6KSQgDOz2gybGlbkCDQRXe/+2ARAAtsJRacWt9z3kgGTGkAIIygQfgL0kbTpzQRbf253rizIoOHXJ9jamxOqDwSDgXp8NBA1jtn6RJEqXqiBrLr7rQQ8bs+lQ+PkKvxpjm7ieHrWgijkgVq0QJzfP746CfzAwnSOq6x+LN8dX/BLxxjzAvvn02ONXKs26jX61kF7f2ovTvdjkIEclC/1Wv4PlULGW8mgnBYypB59pxOE9vFW9T2/Sy1Tlt44O0bTjwEFe2WPgdRoncVz/OHQAB2eLNbUtFfkRMXcevFb1AS2iENtFzWLBBOEI3ft1eBb1NPcQzB10/Ts1Sa52KaslaJVdnOs2BVGtcnMMnieHyamHXG+2SuFqQABc8saucITV/19QcUXOjTbWwW4irfyJE+5XD70EH 6kTY5DSyQonk9MELs08pe3mmVPudoPF0nPLN9hWMq1PEroNQPKEyFOsPIwjdBtO3g gMjC+QxdVR6nG51h9PB8R/D5P8bmA/5bJFpw9vmbx131to1Brt0PknW84KqK97jLc3vaqooTd8X+c78wvfCFSs5RBWsBE2xdzaLiqrn+v62LBhhYHaDw5oWLFMb+gjQzPtE6hnnZvT+j2JhAyuGPHaORAjZHYBVpu5pYPbKRILxXXcBHEUNuW6iWNQnKl3UNyzhpV4x7EPyuGBtDuI1GE7clKIOGI9qlboCn3gxhkAEQEAAYkCHwQYAQgACQUCV3v/tgIbDAAKCRCZQcBXr2xWjJSVD/4qfvHe3eJuKSUWqXZ6J1gjQiVKN0P95rzmE6Haa1cHPzp+kyjx2piG9X+ZUxmLFE5r8dtt6MnyzQsYLPVGj81ygUt7QHuPkDYIiQ+y/5Kx+z5Yox893TGDib/FoD6xLRfXdXv3rWx4g40+95fnc4P8v9Y7rk/e16yKt97iIwducqO2pCS6AWPe5fghuuAgKB/sZu0LrRLwvAm6KTY80YWooBFFsMMudfgNoARGaXOEiSSqkQf84xXIlCUQWpwqSryuqRf44I1oFPw9jucVzrWfdssr4yLi9iyydI0qnaCruX5U5j5z8zfUE/IFiiioBQrMo8BJioosltWIHhT/UgL3ovU1bBy2Fl4C6ofLw6RrbAp1OU3UrmBz6f1IZ3UXTSvDewe7E9dncvRG9SQDQvibZfPdlRHScsPQPfXBKWN1ByRuNUpvAKJOq216EuYTvF+P8th7hm6KkkNU7p6DSbIZo3t+8F746DC2ipz6j7QjAqbq7xFFO+Sk08nTTuhfL661BO96YuI3zaJcmNKeNlhZCa0t98k9DWHq/D/SjfjPmzDv3EYcxEBc+2bCa/s/AkUKHNV3lcSDEkyw8/nyPQFkcmr0mp34Mtu7xM0DtS2Tul2IdTGnbtLGWmaf+AUZ1M4lXsObf cX+dR55tcKyNbmYcze1wo0XfihQuVtCZOGbTLkCDQRXfAIbARAAxf5FzfM0AjrWD1o FwHnlrGCd4RMefLxJYdg1yaO4nGW9tFtPrYcozNoyydMAkBPoIr+ODD6eETfC6RJuBRsz/PkNnMBOX9arD9XFfHqyL0wexab6NaViyKFYs53OLSrWp55Ej7jzhADB+vvtEHKfoA2ge1xEDBWBC4didG4PWMR64NN7cPvKfDCLxA4iyt11YIhVodG2k7HDEZ7La+m98UMleQ9f9r3IoojSZ+VG8Zpbs0sZONyI9uBD2bf2Fc6RWChEq9xJp825MKZTJdsTfedEol8P36xVXMNz/ACSdCqB7aeE9Fen9LdlKIf8yIudQDm5DZ3MJAeJjPOap20BKN1owNTtU8vbl6uj52JNGX8HiiVrXlHfYLkh5w8eFKcTEob6sFfa/LohS1XSSMKVpFa6qi8TOlWn5R68MnbCsk+7EQwJmuUvc2V9tt47TMpvQF9Uap4V7KWx1TKvNv6U9tdNCafH9SJpRsOf/88EPm4IKLjg4KmsEOUuwRGiOHZ9L/+UZ6pRGamU4NBFdmPsxCfIMzVLOMExS49kZKrDwaGd0uw/ZZ/iF3PggnGMwcJC+7ALc5rHJ2zaRvx1xNVHvRV9Yiujbc6G2WwjYkG4JDx4Ho0fnsp11UwwOcH7rBhgqbl6p061e5DrUVPEn1nFeUGiXBwiacdjH69BMnnJ7CUAEQEAAYkCHwQYAQgACQUCV3wCGwIbIAAKCRCZQcBXr2xWjDH7EACWwedD9sOtoh5Sp2PRmNdfnbNOMHDXlX5jZWtumFKVdo+x5JdEU1EB2djEi4gSMgtQ4rkXlp/Neye8cAZzVGo3o/1jn+kOODw5Pg0HpZv/bj1L9YSbLoZYnLdRTtKOFiJuWb/gQdZNaJTH+SWly0T9GYdq0WYlbuY6V/Q4E2Yi2WqOojx6cTKRyp+pGd/8R9TJqRjVFN/THsOteFWZy DeHOiXxyyqu5CViUGjfENkRYYAKuUjoPg4H7zGD2775DeNQXoz8y2oheJ7pcBrwWNRr 6Cnq+U7ymuaFHAWUjb7cfDNnhAYUKuPy5ua824tGptIRlNahHFmfZkVxTuJAPL7fJm/Vpxp/JFuMKEY8RbBevAXI6rWKou99xe4p+BlZMvvL/EIs6XqU8cVJ40skofonDuFyw0tSjZGJOU0XskGqRxldPYtTg/xtJEuDa+TLuuwoeXfdZiWYdFek8OT3NNIK6vwc4edhk23VrjIeuPfDJt7Q7KDa2eRBGBlY5v9YWJ9kYfHm9dvp/P2lU9ds3kseCd1KjqtSFcaOKp1pUqgp+sN1W8KnD16wHVg3Q8h8WEnntVVyZMk+td4ufxHaDeUEcGet91vHFTMBuQw+GGynEbvyMHe7gfbgFxkMWGDPvoPYoVjRYSUTYv8IIRDyv1ljhrauoUjCeXn61e3SeT2MYg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1-1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sat, 2023-11-04 at 15:29 +0100, Andrew Lunn wrote: > On Sat, Nov 04, 2023 at 01:58:40PM +0100, Klaus Kudielka wrote: > > Some net devices do not report NO-CARRIER, if they haven't been brought > > up. >=20 > Hi Klaus >=20 > We should probably fix the driver. What device is it? >=20 > > In that case, the netdev trigger results in a wrong link state being > > displayed. Fix this, by adding a check, whether the device is up. >=20 > Is it wrong? Maybe the carrier really is up, even if the interface is > admin down. Broadcast packets are being received by the > hardware. Maybe there is a BMC sharing the link and it is active? My particular example is Turris Omnia, eth2 (WAN), connected to SFP. SFP module is inserted, but no fiber connected, so definitely no carrier.= =20 *Without* the patch: After booting, the device is down, but netdev trigger reports "link" active= . This looks wrong to me. I can then "ip link set eth2 up", and the "link" goes away - as I would have expected it to be from the beginning. > It is not a clear cut wrong to me. And its a way to find broken > drivers. We might want to discuss this some more. Maybe an initialization issue. Just a guess, I'm really not an expert here: phylink_start() is the first one that does netif_carrier_off() and thus sets the NOCARRIER bit, but that only happens when bringing the device up. Before that, I would not know who cares about setting the NOCARRIER bit. Anyway, it's only a cosmetic issue, but it has been bugging me for too long :) Best regards, Klaus