From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] leds: trigger: use RCU to protect the led_cdevs list
Date: Mon, 27 Sep 2021 16:20:47 +0200 [thread overview]
Message-ID: <97300681a8e793b71ccedf8224010f1f64da6b5c.camel@sipsolutions.net> (raw)
In-Reply-To: <20210927141619.GA18276@duo.ucw.cz>
Hi Pavel,
> >
> > Cc: stable@vger.kernel.org
>
> I ... don't like idea of this going to stable.
OK, I guess that's fair. We've been running into the lockdep report for
a while - ever since we made the spinlock in iwlwifi no longer disable
IRQs all the time, which was meant to be a good thing ...
However, the scenario that could cause *real* deadlocks there is really
unlikely and requires four CPUs all doing the exactly right thing,
including a normally very rare *write lock* on the leddev_list_lock, so
I don't think in practice it'll be much of an issue.
johannes
prev parent reply other threads:[~2021-09-27 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 16:16 [PATCH] leds: trigger: use RCU to protect the led_cdevs list Johannes Berg
2021-09-27 14:16 ` Pavel Machek
2021-09-27 14:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97300681a8e793b71ccedf8224010f1f64da6b5c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox