From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA7951A4E70; Tue, 9 Sep 2025 09:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757408789; cv=none; b=VOsVJL1qR+8Z4/BvV0CMY7gRUOKUzgL75A9uW19W+qMi66Do3+/PoZn4l91+kSQAQ79rNDDRP19eFiFR1iA6PG6aq8f6f3PJwQzFbIRXlnG47K9nO+SvujdMA37LKzakQfwLv1b4WHSqKyKy7aj7rTvR2xTif6iADCrEwlPlAY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757408789; c=relaxed/simple; bh=7KHRyNXulEzV5xfA0DTLR93wZhedtS6U0W/OgCRxzTo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WTHeZrTL9rsbHgW3joBwov/tyAWHVvCpQQvcmHjkwv+WI3kvMA2qxfQsErKogAPG7HGRLmwk17wr4v5fgJXQ/i9IySiv7Giaf2Asi0/5xsRrRxaOdbdFmimzZ1duteiGyxrL2onl5hszwst9fKl1CV2YNmz0u9xBUWEWHYD084I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YgpIdyA/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YgpIdyA/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0263CC4CEF5; Tue, 9 Sep 2025 09:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757408788; bh=7KHRyNXulEzV5xfA0DTLR93wZhedtS6U0W/OgCRxzTo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YgpIdyA/7SeKJXe88JKdL+8cKRhcsDkqKgcop6CyNabiQH1IoGUGWwnhISrzq+ATK iw+a1kLwmrkdfoCl+Y3T4dFzQ8PiQC7YrA26Lp4HvdqoN2LU+n3Yoi0MtMBGjkeea2 ohKhJtF5gy9ML01DyQtxo78OqfDTX/OtsszEzisC5gbN6zhA4mh5be1PK6inzH7n/n rmL1ylDc4WnEFZK9RumjHEvr/qFuHAbGJLE5xzf+fbRiKWYGDO4XzmzyUrtIezcjJc 1Iv9IyF4uuYyhVUnsSMAOlvNmC0VKCUpivKwootXbR+ghdD42K7rqLJ4UQPM4rTMvI LhJpZ1LEvqxdw== Message-ID: <98871c1b-7183-4a08-a5ea-9fa5c91c6777@kernel.org> Date: Tue, 9 Sep 2025 11:06:21 +0200 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] dt-bindings: leds: commonize leds property To: Rob Herring , Konrad Dybcio Cc: Aleksandrs Vinarskis , Lee Jones , Pavel Machek , Krzysztof Kozlowski , Conor Dooley , Bryan O'Donoghue , Daniel Thompson , Jingoo Han , Mauro Carvalho Chehab , Jean-Jacques Hiblot , Jacopo Mondi , Sakari Ailus , Bjorn Andersson , Konrad Dybcio , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250908-leds-v3-0-5944dc400668@vinarskis.com> <20250908-leds-v3-2-5944dc400668@vinarskis.com> <0e030e7d-0a1a-4a00-ba18-ed26107d07fa@oss.qualcomm.com> <046b289d-b6a5-45f9-88b1-090e2ab7c95d@kernel.org> <39b955b9-a152-458a-8e09-908efebaaccd@oss.qualcomm.com> <20250908222247.GA1943768-robh@kernel.org> From: Hans de Goede Content-Language: en-US, nl In-Reply-To: <20250908222247.GA1943768-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 9-Sep-25 12:22 AM, Rob Herring wrote: > On Mon, Sep 08, 2025 at 09:36:39AM +0200, Konrad Dybcio wrote: >> On 9/8/25 9:33 AM, Hans de Goede wrote: >>> Hi, >>> >>> On 8-Sep-25 09:20, Konrad Dybcio wrote: >>>> On 9/8/25 1:18 AM, Aleksandrs Vinarskis wrote: >>>>> A number of existing schemas use 'leds' property to provide >>>>> phandle-array of LED(s) to the consumer. Additionally, with the >>>>> upcoming privacy-led support in device-tree, v4l2 subnode could be a >>>>> LED consumer, meaning that all camera sensors should support 'leds' >>>>> and 'led-names' property via common 'video-interface-devices.yaml'. >>>>> >>>>> To avoid dublication, commonize 'leds' property from existing schemas >>>>> to newly introduced 'led-consumer.yaml'. >>>>> >>>>> Signed-off-by: Aleksandrs Vinarskis >>>>> --- >>>> >>>> [...] >>>> >>>>> >>>>> + leds: >>>>> + minItems: 1 >>>>> + maxItems: 1 >>>> >>>> My brain compiler suggests this will throw a warning (minItems should >>>> be redundant in this case) >>>>> + >>>>> + led-names: >>>>> + enum: >>>>> + - privacy-led >>>> >>>> Nit: "privacy" makes more sense without the suffix, as we inherently >>>> know this is supposed to be an LED >>> >>> Note "privacy-led" as name is already used on the x86/ACPI side and >>> the code consuming this will be shared. >>> >>> With that said if there is a strong preference for going with just >>> "privacy" the x86 side can be adjusted since the provider-info is >>> generated through a LED lookup table on the x86/ACPI side. So we can >>> just modify both the lookup table generation as well as the already >>> existing led_get(dev, "privacy-led") call to use just "privacy" >>> without problems. >> >> In that case, it may be cleaner to just go with what we have today >> (unless the dt maintainers have stronger opinions) > > Well, I do, but I guess it's fine. Please don't add the suffix on the > rest and add a comment for why it's there. Dropping the "-led" suffix on the ACPI side really is no big deal, so if we don't want the suffix it is probably best to also drop it for "privacy-led" rather then setting a bad example to be copy and pasted. Regards, Hans