From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, Randy Dunlap <rdunlap@infradead.org>,
pavel@ucw.cz
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices
Date: Tue, 30 Apr 2019 21:32:11 +0200 [thread overview]
Message-ID: <98b7f0fd-6f94-b8a1-a367-77d8cae2a97e@gmail.com> (raw)
In-Reply-To: <a953b7e9-ce80-641a-4d0e-f0b96828a732@ti.com>
On 4/30/19 9:30 PM, Dan Murphy wrote:
> Randy
>
> On 4/30/19 2:23 PM, Randy Dunlap wrote:
>> On 4/30/19 12:17 PM, Dan Murphy wrote:
>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>>> index da00b9ed5a5c..3ae24eaf4cde 100644
>>> --- a/drivers/leds/Kconfig
>>> +++ b/drivers/leds/Kconfig
>>> @@ -776,6 +776,14 @@ config LEDS_NIC78BX
>>> To compile this driver as a module, choose M here: the module
>>> will be called leds-nic78bx.
>>>
>>> +config LEDS_TI_LMU_COMMON
>>> + tristate "LED driver for TI LMU"
>>
>> what does LMU mean?
>
> Lighting management unit it is defined in the DT documentation
>
>>
>>> + depends on REGMAP
>>> + help
>>> + Say Y to enable the LED driver for TI LMU devices.
>>> + This supports common features between the TI LM3532, LM3631, LM3632,
>>> + LM3633, LM3695 and LM3697.
>>
>> Fix help indentation above to use tab + 2 spaces consistently.
>>
>
> UGH I wish I had this comment 2 weeks ago.
> But I can fix it
I will amend this while merging, no need to resend.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-04-30 19:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 19:17 [PATCH v3 0/7] LMU Common code intro Dan Murphy
2019-04-30 19:17 ` [PATCH v3 1/7] dt-bindings: mfd: LMU: Fix lm3632 dt binding example Dan Murphy
2019-04-30 19:17 ` [PATCH v3 2/7] dt-bindings: mfd: LMU: Add the ramp up/down property Dan Murphy
2019-04-30 22:01 ` Pavel Machek
2019-05-06 17:53 ` Dan Murphy
2019-04-30 19:17 ` [PATCH v3 3/7] dt-bindings: mfd: LMU: Add ti,brightness-resolution Dan Murphy
2019-04-30 19:17 ` [PATCH v3 4/7] leds: TI LMU: Add common code for TI LMU devices Dan Murphy
2019-04-30 19:23 ` Randy Dunlap
2019-04-30 19:30 ` Dan Murphy
2019-04-30 19:32 ` Jacek Anaszewski [this message]
2019-04-30 19:34 ` Dan Murphy
2019-04-30 19:17 ` [PATCH v3 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy
2019-04-30 22:05 ` Pavel Machek
2019-04-30 22:07 ` Dan Murphy
2019-04-30 22:08 ` Pavel Machek
2019-04-30 19:17 ` [PATCH v3 6/7] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2019-04-30 19:17 ` [PATCH v3 7/7] leds: lm3697: Introduce the lm3697 driver Dan Murphy
2019-04-30 22:05 ` [PATCH v3 0/7] LMU Common code intro Jacek Anaszewski
2019-05-01 9:45 ` Jacek Anaszewski
2019-05-08 6:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b7f0fd-6f94-b8a1-a367-77d8cae2a97e@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).