From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings Date: Wed, 13 Dec 2017 21:43:16 +0100 Message-ID: <98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com> References: <20171212215011.30066-1-dmurphy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f44.google.com ([74.125.82.44]:42117 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752908AbdLMUoO (ORCPT ); Wed, 13 Dec 2017 15:44:14 -0500 In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Dan Murphy , robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net, pavel@ucw.cz, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Dan, On 12/13/2017 09:41 PM, Dan Murphy wrote: > Jacek > > On 12/13/2017 02:29 PM, Jacek Anaszewski wrote: >> Hi Dan, >> >> checkpatch.pl doesn't want to be mentioned in the patch subject :-) >> > > Ack > >> "WARNING: A patch subject line should describe the change not the tool >> that found it" >> >> Preferably I'd see two separate patches. >> > > So you want me to split them up? I have no issue with that. Yeah, it will be easier to come up with concise but meaningful subjects. >> Also, line length limit for the commit description is 75 characters. >> Please use whole available space. >> > > -- Best regards, Jacek Anaszewski