public inbox for linux-leds@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	rpurdie@rpsys.net, pavel@ucw.cz, keescook@chromium.org,
	shuah@kernel.org
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] leds: ledtrig-transient: Add SPDX license identifiers
Date: Wed, 10 Jan 2018 15:43:00 -0700	[thread overview]
Message-ID: <9a26debc-e04d-e935-d2d8-bba1df6d92e5@osg.samsung.com> (raw)
In-Reply-To: <d1c6aab4-735d-565d-1bc4-9fd77e82e589@gmail.com>

On 01/10/2018 01:40 PM, Jacek Anaszewski wrote:
> Hi Shuah,
> 
> Thanks for the patch.
> 
> On 01/10/2018 05:35 PM, Shuah Khan wrote:
>> Replace GPL license statements with SPDX GPL-2.0 license identifiers
>> and and correct the module license to GPLv2.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  drivers/leds/trigger/ledtrig-transient.c | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/leds/trigger/ledtrig-transient.c b/drivers/leds/trigger/ledtrig-transient.c
>> index 7acce64b692a..f0578af858e7 100644
>> --- a/drivers/leds/trigger/ledtrig-transient.c
>> +++ b/drivers/leds/trigger/ledtrig-transient.c
>> @@ -1,3 +1,4 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>>  /*
> 
> How about changing this whole block comment to "//"?
> We did it already for drivers/leds/trigger/ledtrig-netdev.c,
> present in linux-next. See related discussion with reference
> to relevant Linus' guidelines in this matter [0].
> 

v2 is on its way.

thanks,
-- Shuah

      reply	other threads:[~2018-01-10 22:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-10 16:35 [PATCH] leds: ledtrig-transient: Add SPDX license identifiers Shuah Khan
2018-01-10 20:40 ` Jacek Anaszewski
2018-01-10 22:43   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a26debc-e04d-e935-d2d8-bba1df6d92e5@osg.samsung.com \
    --to=shuahkh@osg.samsung.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox