From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C74FCCA47F for ; Tue, 19 Jul 2022 07:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234762AbiGSHex (ORCPT ); Tue, 19 Jul 2022 03:34:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236690AbiGSHe2 (ORCPT ); Tue, 19 Jul 2022 03:34:28 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C6BE33A28 for ; Tue, 19 Jul 2022 00:34:26 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id u14so8393599lju.0 for ; Tue, 19 Jul 2022 00:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=lo9T0CevCQg3oDP4vfcp2Mw2HsO8mehETjg/lVyDcfY=; b=ujOHcdJmYVsYhfNNqPcA/dd4wzJFt5tWMnScCWNWXxq5OQH0NSu7uVHVgwdsQrk/9y op/Hw+GxTyOnF4SHBB+MVYf21XW6XxJLZrPmiT1VJg/njbDmhYBoR2ezx8+vdZScFCvf TScwqv44LcO851ZzM/7D+Cp49thHpgdkBd3aehzzO+JBWj38A019iUjegdlz3sPDvxwD RXF3I8clp64+x59rKF414sPh6YwwYHBuyHrRO0Ip39xmm4lBuPz6Fv8nTnsL1GQCkpS3 e9SycSsdzCB1zyCztyGCSdvEkd7bIC1B5DmiiIcYf33fZDjnUcYqeaRPR0LELanji2f4 YRYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lo9T0CevCQg3oDP4vfcp2Mw2HsO8mehETjg/lVyDcfY=; b=rackHy5a0fFfUA4OH1BggSD6ykYfBZzy9WiZCaPPehd2YK0dlalkOzoCDHVQZoTOOm aRLl1Dkg9uwf8o2euGEsuzVTJThzdPFZ+tCJCeKN4rjYvk/xhtB8X9rWIj3MjqDMOvD5 JCZ/Og45xaNbLi8185x2XPMRe6Vr62otserdMkj77aNhOtvnZ5JD7B0HSOM9xEUc0yot 6ayJRnbrbKwacC4Owv3SmE47cEuCA6q681HqUeH1UD6ZLe2+BkRaOVgyHEFPRN2GWmfB dP8XuCbYnMKxz0z0DZYMIoTatD2swZKrZzNg2lVv+pnKMAOjQvXJK8zT/nc70VpFrTIj Z5xA== X-Gm-Message-State: AJIora+Pf67kSqo3YhCg0oz6oZRkwq5eQrDbgA1s6rJp/CJTDB5tTRjI stsIgd8qvAihQUFsnmWOF4bXOQ== X-Google-Smtp-Source: AGRyM1vWdi/tW4c6Hzt77zEWrErAi9tPR28pFblEHqUOtlAeDCDOfkkAE8WAktYM/O1PwhVa1M79TA== X-Received: by 2002:a2e:b007:0:b0:25d:82ab:6a6c with SMTP id y7-20020a2eb007000000b0025d82ab6a6cmr14797420ljk.88.1658216064478; Tue, 19 Jul 2022 00:34:24 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id b12-20020a056512024c00b00479307e4a1bsm3039531lfo.135.2022.07.19.00.34.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 00:34:24 -0700 (PDT) Message-ID: <9e137bb2-0543-ce18-4967-792c8fa13841@linaro.org> Date: Tue, 19 Jul 2022 09:34:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] dt-bindings: leds: lp50xx: fix LED children names Content-Language: en-US To: Rob Herring Cc: Pavel Machek , Krzysztof Kozlowski , Dan Murphy , Jacek Anaszewski , Linux LED Subsystem , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" References: <20220624111325.96478-1-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 18/07/2022 17:18, Rob Herring wrote: > On Fri, Jun 24, 2022 at 5:13 AM Krzysztof Kozlowski > wrote: >> >> The lp50xx LEDs expects to have single-color LED children with unit >> addresses. This is required by the driver and provided by existing >> DTSes. Fix the binding to match actual usage. >> >> Signed-off-by: Krzysztof Kozlowski >> Fixes: dce1452301e7 ("dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers") >> --- >> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml >> index f12fe5b53f30..c274a10bbde6 100644 >> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml >> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml >> @@ -65,8 +65,14 @@ patternProperties: >> for the child node. The LED modules can either be used stand alone >> or grouped into a module bank. >> >> + '#address-cells': >> + const: 1 >> + >> + '#size-cells': >> + const: 0 >> + >> patternProperties: >> - "(^led-[0-9a-f]$|led)": >> + "^led@[0-9a-f]+$": > > Looks like you forgot to update the example. Now failing with > 'unevaluatedProperties' fixed: Yeah, this was fixed in my other patch: https://lore.kernel.org/all/20220607075247.58048-1-krzysztof.kozlowski@linaro.org/ and I assumed Pavel will also pick it up... It has been waiting for more than one month. Best regards, Krzysztof