From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH 4/5] devicetree: leds: Introduce "panic-blink" optional property Date: Wed, 6 Apr 2016 01:39:31 -0300 Message-ID: References: <1459801326-5541-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1459801326-5541-5-git-send-email-ezequiel@vanguardiasur.com.ar> <5704301D.7040300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wm0-f42.google.com ([74.125.82.42]:36669 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751022AbcDFEjd convert rfc822-to-8bit (ORCPT ); Wed, 6 Apr 2016 00:39:33 -0400 Received: by mail-wm0-f42.google.com with SMTP id v188so9290803wme.1 for ; Tue, 05 Apr 2016 21:39:32 -0700 (PDT) In-Reply-To: <5704301D.7040300@gmail.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-kernel , Richard Purdie , Jacek Anaszewski , Rob Herring On 5 April 2016 at 18:37, Jacek Anaszewski = wrote: > Hi Ezequiel, > > On 04/04/2016 10:22 PM, Ezequiel Garcia wrote: >> >> It's desirable to specify which LEDs are to be blinked on a kernel >> panic. Therefore, introduce a devicetree boolean property to mark >> which LEDs should be treated this way. >> >> Signed-off-by: Ezequiel Garcia >> --- >> Documentation/devicetree/bindings/leds/common.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/common.txt >> b/Documentation/devicetree/bindings/leds/common.txt >> index 68419843e32f..dd409df9203a 100644 >> --- a/Documentation/devicetree/bindings/leds/common.txt >> +++ b/Documentation/devicetree/bindings/leds/common.txt >> @@ -37,6 +37,8 @@ Optional properties for child nodes: >> property is mandatory for the LEDs in the non= -flash >> modes >> (e.g. torch or indicator). >> >> +- panic-blink : Mark this LED to be used by the panic LED trigger. > > > I'd say that 'panic-indicator' would be more informative. > Sure, that looks much better. > Please next time cc also devicetree list and maintainers. > Will do. Thanks for the reviews! --=20 Ezequiel Garc=C3=ADa, VanguardiaSur www.vanguardiasur.com.ar