From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967A2C433EF for ; Fri, 24 Jun 2022 21:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231759AbiFXVgV (ORCPT ); Fri, 24 Jun 2022 17:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231732AbiFXVgU (ORCPT ); Fri, 24 Jun 2022 17:36:20 -0400 Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A69286AEF for ; Fri, 24 Jun 2022 14:36:18 -0700 (PDT) Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-3176d94c236so36874307b3.3 for ; Fri, 24 Jun 2022 14:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cGTylEOWtLkcLIsxYVoGzfL+q0nSap9+8NoSlXBuXe4=; b=cmDy8lsyV2rPNiNRuYkEb5rHWD8XZVHKqJZAeKf3TnWZFLlj+/DTdLUMbXEmtTuv9s 4KLbNJHfJqFtWZDtoSIB0jA5BkjqsNets6Rbr/qrINRnJTlQirI2k20GLR/Ql3zSe9Wq Pb5aXUq1NZ5lDKQQMD7a39HTujZM62LjFsQtIqhJoX7pGAoQGMqpg1+inV2FswApITO2 CmT3BH618Yqgt62CZsqxQ5e1jZosKUxMbd0fExcTgjLrAxPBxkG7CVcmjw/O8dvTmdbG l6UouC6UHf0T16KEM/mMUtmMtJOh0vyJl540PkTEmkGnFr3Ic8OHzXavkS9AsevSsxDH c7uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cGTylEOWtLkcLIsxYVoGzfL+q0nSap9+8NoSlXBuXe4=; b=BMxEsMzrb1W0PtiVdS7TblDkOdSmWCVxKdIgIe1j5X2qegflkdAP/MjuVhf77Nbyal JjIZUHSh9xRG71dqx2oBvbhpWJrjx0SZyoe/WFeCzCKBx5pTVB6vS0exXKirOpuef3/G ysV20UyQEbNAu3TnotCprtzAi+NWBnTrU9hsBT0hmEgM8Ar3wYEs9fImxy1CMJWdhthy ZRO30AsoKGFjTWXiyCAPg1mUvhf/KJ/aM5RhsnXgLmB/m8yb7/93pwmibJsiftN8c/LU ngq05y7RCiHw/WRZuAGTl6IwfQqpK3cGHvKhYJgT3d7kVRHORTx8OcX7+izqNjKyy6Sh drqQ== X-Gm-Message-State: AJIora+BIAPrIWP3UOXhYSJyqVkeWvgbo2U0L57GJbQaA3gok0osbxAS RI4xsjlOlqYZTqRYU2s9sFlrK/C5ISKF4xejJduZGw== X-Google-Smtp-Source: AGRyM1v7bTPADut4sgzebmriq1YeKB4PBfCCubvcMefuaUSK78eOKMtZqJdaXmsewcrgPAHhOp3HhKhV310/qVQEQyc= X-Received: by 2002:a0d:cc54:0:b0:317:752c:bcf3 with SMTP id o81-20020a0dcc54000000b00317752cbcf3mr1068283ywd.437.1656106577632; Fri, 24 Jun 2022 14:36:17 -0700 (PDT) MIME-Version: 1.0 References: <20220623115631.22209-1-peterwu.pub@gmail.com> <20220623115631.22209-13-peterwu.pub@gmail.com> In-Reply-To: From: Linus Walleij Date: Fri, 24 Jun 2022 23:36:06 +0200 Message-ID: Subject: Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support To: szuni chen Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , devicetree , "open list:FRAMEBUFFER LAYER" , alice_chen@richtek.com, Linux PM , linux-iio , USB , Linux Kernel Mailing List , dri-devel , ChiYuan Huang , chiaen_wu@richtek.com, "moderated list:ARM/Mediatek SoC support" , linux-arm Mailing List , Linux LED Subsystem Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Jun 24, 2022 at 9:20 AM szuni chen wrote: > > I meant this one. Move that into drivers/leds/flash > > drivers/leds/flash/leds-mt6370-flash.c | 657 ++++++++++++ > > In next version, I'll use "leds: flash: ......" instead of "leds: > flashlight: ......" in subject. > May I confirm that the driver has already in the drivers/leds/flash, > so I don=E2=80=99t have to move it in next version? Yeah you're right, I am just writing wrong comments today, it is already correct. Sorry! Yours, Linus Walleij