From: Linus Walleij <linus.walleij@linaro.org>
To: liviu@dudau.co.uk
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds
Date: Thu, 25 Oct 2018 14:55:20 +0200 [thread overview]
Message-ID: <CACRpkdaHBf1eJig5t2_u89HhKb2Ne8FV1AhfdZ3Yy_XTZQdEqw@mail.gmail.com> (raw)
In-Reply-To: <20181018001432.710-1-liviu@dudau.co.uk>
On Thu, Oct 18, 2018 at 2:14 AM Liviu Dudau <liviu@dudau.co.uk> wrote:
> Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
> removed the common code path that set the led_dat->gpiod pointer in
> create_gpio_led(), but only added it back for the devices that have
> a valid gpio_led_platform_data structure. Calling gpio_leds_create()
> in gpio_led_probe() is not enough to get a valid gpiod pointer.
>
> Fortunately enough, gpio_leds_create() already gets the needed pointer,
> we just need to assign it to the relevant gpio_led_data structure.
>
> Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
Ooops
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2018-10-25 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 0:14 [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds Liviu Dudau
2018-10-23 11:18 ` Liviu Dudau
2018-10-25 13:08 ` Pavel Machek
2018-10-25 19:18 ` Jacek Anaszewski
2018-10-25 12:55 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaHBf1eJig5t2_u89HhKb2Ne8FV1AhfdZ3Yy_XTZQdEqw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=liviu@dudau.co.uk \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).