* [PATCHi v6] leds: ipaq-micro: Implement brightness_set_blocking op
@ 2015-11-19 16:48 Jacek Anaszewski
2015-11-30 8:47 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Jacek Anaszewski @ 2015-11-19 16:48 UTC (permalink / raw)
To: linux-leds; +Cc: Jacek Anaszewski, Linus Walleij
Since brightness setting can sleep for this driver, implement
brightness_set_blocking op, instead of brightness_set.
It makes this driver compatible with LED triggers.
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
Changes from v5:
- use newly introduced brightness_set_blocking op, which was deemed
a better solution that flags proposed at earlier stage
of LED core improvent patch sets
drivers/leds/leds-ipaq-micro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-ipaq-micro.c b/drivers/leds/leds-ipaq-micro.c
index fa262b6..229386f 100644
--- a/drivers/leds/leds-ipaq-micro.c
+++ b/drivers/leds/leds-ipaq-micro.c
@@ -102,7 +102,7 @@ static int micro_leds_blink_set(struct led_classdev *led_cdev,
static struct led_classdev micro_led = {
.name = "led-ipaq-micro",
- .brightness_set = micro_leds_brightness_set,
+ .brightness_set_blocking = micro_leds_brightness_set,
.blink_set = micro_leds_blink_set,
.flags = LED_CORE_SUSPENDRESUME,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHi v6] leds: ipaq-micro: Implement brightness_set_blocking op
2015-11-19 16:48 [PATCHi v6] leds: ipaq-micro: Implement brightness_set_blocking op Jacek Anaszewski
@ 2015-11-30 8:47 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2015-11-30 8:47 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: linux-leds@vger.kernel.org
On Thu, Nov 19, 2015 at 5:48 PM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Since brightness setting can sleep for this driver, implement
> brightness_set_blocking op, instead of brightness_set.
> It makes this driver compatible with LED triggers.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> ---
> Changes from v5:
> - use newly introduced brightness_set_blocking op, which was deemed
> a better solution that flags proposed at earlier stage
> of LED core improvent patch sets
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-30 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-19 16:48 [PATCHi v6] leds: ipaq-micro: Implement brightness_set_blocking op Jacek Anaszewski
2015-11-30 8:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).