From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B82A20B0B for ; Mon, 13 Nov 2023 14:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WpKDgd+u" Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBBCA10E5 for ; Mon, 13 Nov 2023 06:16:10 -0800 (PST) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-5bf812041a6so47988277b3.3 for ; Mon, 13 Nov 2023 06:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699884970; x=1700489770; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VsObpwiNRRoDaNBTqnKKwKCtx88JHZeh51II3/PGBnI=; b=WpKDgd+uVI58OVzn3e8kkvCc2MG0lGpmQSwcahu7Eyf3MnRjB+FPG9MYSg5xLXU26a FT/fjGlunh0ABlb0pd6vjuXUgQm53kPl9/5xlW824g+WPAdMe30vajXMbbvuCXI1/59h M4fADNOddQFkhn3THqo+4YyJTN8pCtiuhRXgrQYjFKEDeIl2PwHStx8M6L0td5kvpRhv AoQvb13Nqpapq2ZFvm97ERRlm2KcekWL3tgIupr4x9t4qe5XNV0T1q1XO58VjL1EAfBX w76PEUCZWtESIJRrlIX7EL9GURRhxbA2PfMK8HRFZLnZUOK8Y+2Jqi912yvtH7qAXqoV lE4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884970; x=1700489770; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VsObpwiNRRoDaNBTqnKKwKCtx88JHZeh51II3/PGBnI=; b=a7AkSrWVh5iLgfb/9ayVYXhbRGoMTqDOF/d8e5EAYzstCkrYf38TFc7sr9WFy59UoC 9R3EbhrMP6Ye2sFvps2e7Vs44I8m3ZRthtBeVhhUS5HKRfFYZR18JXYdawipJo53tm2n MIGIro7Is95nM8vRVCL8oRfgdWxS90PwTnsXiNnZBYu6pbSsx136JvepZOp4QPluiNVA 7gRj1YpYr1l9oi3023lw0hnPy/62xTzZ8i3XdvPbsOChqLpHzAsCPlAeJnPZWvkDqx9u i+vsidHr+fxTltOThrFuULTQE2S7MXZMFBfjt/pQhobmN2coLEEMl5YBx9NMO+lnex+C Z+Rw== X-Gm-Message-State: AOJu0YxzHkfIllg3YAGuU0c48Judem1iMqeE+Ow9o04U576MP+e3PpgL fNnj/98mqt6P1nWryIW9lk7K63qM2omZRQXYPKKSqwvu3JyOnB1S X-Google-Smtp-Source: AGHT+IEfo3yjlThVT/1VbEzaAtk/giSVbUC9q6aHRoszCrkPGNGtNlWOQLaQkv5lYlgVl+3GIUdM37qvyenBOQnoLpA= X-Received: by 2002:a81:8085:0:b0:5a7:e4fe:ea3 with SMTP id q127-20020a818085000000b005a7e4fe0ea3mr6865035ywf.22.1699884969990; Mon, 13 Nov 2023 06:16:09 -0800 (PST) Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231031015119.29756-1-larry.lai@yunjingtech.com> <20231031015119.29756-3-larry.lai@yunjingtech.com> In-Reply-To: <20231031015119.29756-3-larry.lai@yunjingtech.com> From: Linus Walleij Date: Mon, 13 Nov 2023 15:15:58 +0100 Message-ID: Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA To: "larry.lai" , Andy Shevchenko Cc: lee@kernel.org, pavel@ucw.cz, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com, jack.chang@yunjingtech.com, noah.hung@yunjingtech.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Larry, Andy, On Tue, Oct 31, 2023 at 2:51=E2=80=AFAM larry.lai wrote: > The UP Squared board implements certain > features (pin control) through an on-board FPGA. > > Reported-by: kernel test robot > Signed-off-by: Gary Wang > Signed-off-by: larry.lai (...) > +#include "core.h" > +#include "intel/pinctrl-intel.h" As mentioned this is using the intel core pin control driver infrastructure so I want Andy's ACK on this before I merge it. Yours, Linus Walleij