From: Paulo Costa <me@paulo.costa.nom.br>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org
Subject: Re: [RFC] ledtrig-dither: A Poor man's adjustable LED brightness.
Date: Thu, 17 Aug 2017 01:21:37 -0300 [thread overview]
Message-ID: <CADbEYbkGYO7dSuMcK4SjtWch+2GjPL7axPuk7UHohWLCfkj61Q@mail.gmail.com> (raw)
In-Reply-To: <20170816223022.GA13540@amd>
> Hmm. You could do led=on, udelay(100), led=off. Do that 100 times a
> second, and I believe you'll get quite nice low levels.
I don't want to keep the CPU busy on a delay() just for blinking led,
even if only for a few micros.
> Now... nice hack. Probably can be improved. But is it suitable for
> mainline?
Thank you =)
It's a proof of concept for now, definitely not ready for mainline.
Instead of a LED trigger + wrapper LED entry, I think this should kick in
if we set 'myled/dither=1' or something like that.
Now, do you think it would be a nice addition / Should I put more work on it?
Thanks for looking into it
next prev parent reply other threads:[~2017-08-17 4:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 21:35 [RFC] ledtrig-dither: A Poor man's adjustable LED brightness Paulo Costa
2017-08-15 22:34 ` Pavel Machek
2017-08-16 3:55 ` Paulo Costa
2017-08-16 22:30 ` Pavel Machek
2017-08-17 4:21 ` Paulo Costa [this message]
2017-08-28 9:10 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADbEYbkGYO7dSuMcK4SjtWch+2GjPL7axPuk7UHohWLCfkj61Q@mail.gmail.com \
--to=me@paulo.costa.nom.br \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).