From mboxrd@z Thu Jan 1 00:00:00 1970 From: Janne Kanniainen Subject: Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels Date: Sun, 15 Jun 2014 17:59:40 +0300 Message-ID: References: <20140612090636.GK10256@localhost> <1402605252-9620-1-git-send-email-janne.kanniainen@gmail.com> <20140613075411.GG10940@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-qc0-f175.google.com ([209.85.216.175]:48915 "EHLO mail-qc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbaFOO7l (ORCPT ); Sun, 15 Jun 2014 10:59:41 -0400 In-Reply-To: Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Johan Hovold Cc: Jiri Kosina , Bryan Wu , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org >> Ok, so you decided to continue setting mode on every LED brightness >> update. That should be fine, but you never answered my question about >> whether it is necessary? > > I decided to do it that way because official driver did it as well. I > can check if it is necessary. Ok, I checked this one and every time you update LEDs brightness you will need to update mode also.