From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Dmitry Rokosov <ddrokosov@salutedevices.com>
Cc: lee@kernel.org, pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
kernel@sberdevices.ru, rockosov@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org,
George Stark <gnstark@salutedevices.com>
Subject: Re: [PATCH v5 04/11] leds: aw200xx: calculate dts property display_rows in the driver
Date: Tue, 28 Nov 2023 17:47:33 +0200 [thread overview]
Message-ID: <CAHp75VciKCGcaRvask-q4pCMY3iuRf71qiVCNVqybGuN--kqPw@mail.gmail.com> (raw)
In-Reply-To: <20231125200519.1750-5-ddrokosov@salutedevices.com>
On Sat, Nov 25, 2023 at 10:05 PM Dmitry Rokosov
<ddrokosov@salutedevices.com> wrote:
>
> From: George Stark <gnstark@salutedevices.com>
>
> Get rid of device tree property "awinic,display-rows". The property
> value actually means number of current switches and depends on how LEDs
> are connected to the device. It should be calculated manually by max
> used LED number. In the same way it is computed automatically now.
> Max used LED is taken from LED definition subnodes.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-28 15:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 20:05 [PATCH v5 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 01/11] leds: aw200xx: fix write to DIM parameter Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 02/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-11-28 15:46 ` Andy Shevchenko
2023-11-25 20:05 ` [PATCH v5 03/11] dt-bindings: leds: aw200xx: introduce optional enable-gpios property Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 04/11] leds: aw200xx: calculate dts property display_rows in the driver Dmitry Rokosov
2023-11-28 15:47 ` Andy Shevchenko [this message]
2023-11-25 20:05 ` [PATCH v5 05/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 06/11] leds: aw200xx: add delay after software reset Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 07/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 08/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 09/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 10/11] dt-bindings: leds: awinic,aw200xx: add AW20108 device Dmitry Rokosov
2023-11-25 20:05 ` [PATCH v5 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints Dmitry Rokosov
2023-12-01 11:09 ` [PATCH v5 00/11] leds: aw200xx: several driver updates Lee Jones
2023-12-06 11:29 ` Dmitry Rokosov
2023-12-06 13:11 ` Lee Jones
2023-12-06 17:02 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VciKCGcaRvask-q4pCMY3iuRf71qiVCNVqybGuN--kqPw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=ddrokosov@salutedevices.com \
--cc=devicetree@vger.kernel.org \
--cc=gnstark@salutedevices.com \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).