From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CB7C00140 for ; Mon, 8 Aug 2022 13:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242628AbiHHNR1 (ORCPT ); Mon, 8 Aug 2022 09:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233946AbiHHNR0 (ORCPT ); Mon, 8 Aug 2022 09:17:26 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A0D226F6; Mon, 8 Aug 2022 06:17:25 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id a4so1677467qto.10; Mon, 08 Aug 2022 06:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=keJvvuxY+DljIPbAKycRkrQWZ9q+w8P5iUoKjKCUfF0=; b=cnMKJA0S3S2yDzpUf7DokNU7ZCZ7gyEVxUT+e7HqDS7SJT7jVgNTStSffi8wD4P1qc 7M+cXD+Pl3Tf7YbsAWoisB6U4mr6gCWFe0/1QkJiaeCURjjB5a1yRF+fcF1aawh7Ii4y UrIdE/RE7Nw3kIDrl3mXth4pfktvC4AxyVkhlmRYuCqZHjJsNssD+IePpgUnmscgSvgA n1tF4QaTyHmKNVOeFSUYZ3+ggYmoevbm4hA30rXMqml9rKFIG2FAW7qwGUAp+cPG3TAq vOKacpKpusNsFKPN9xOWijuaSRrHYMExJDXxL4GXtPTq7FSoznDszx5eWLb6cJkt5BL3 EnPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=keJvvuxY+DljIPbAKycRkrQWZ9q+w8P5iUoKjKCUfF0=; b=t3KqwiXXkdBaVu8YmyxFmcGxJuno9GCWbsr0ZbowztlVAfTjbi2xiz/lTCSxnFa9BV FS6HjJR3t4hVqQsoTIPUaDYwGpFWGOa5g/JYlnumtwFEx+lTr4AdzXuxGiT8VdNCsyuL IiNXsuGmQrGr62OxaR46M4iHkAJwV5ZKhqy0kUpuNZQklPfr2uf1Mn0EETuNxhMWO5up s7hg8/TCgNUIguFi6W8rwgJlugpVBjX1TWHfJZdBmTH1h3yG0bN4xbUzgWyxa+PwVobv xuZZXd/WqLAO4NIZcV7HjGMqbMQzZ6OHo/767KfxP9Hvot3k60UeBqKTzsKtiAgtXajw gDkA== X-Gm-Message-State: ACgBeo3G+dPHvhetNn/Ot2o2GT/8EoXxj5rQbTVLj/AJ0uBI0SQFDNoS 7fjLO3bz+CrXgY9istY0luHvZ/p6qa5LLKTzUj8= X-Google-Smtp-Source: AA6agR7hDpStlNRxIfMMDWA6POmSAO0pE5vIlu1j+57ugjjgAtS6AH53+W91AYdhfSgZRlBkRXZQuHxusy/dJYI0eCU= X-Received: by 2002:ac8:7fd1:0:b0:31e:e9c0:c071 with SMTP id b17-20020ac87fd1000000b0031ee9c0c071mr16009872qtk.481.1659964644308; Mon, 08 Aug 2022 06:17:24 -0700 (PDT) MIME-Version: 1.0 References: <20220807104027.10808-1-paul@crapouillou.net> In-Reply-To: <20220807104027.10808-1-paul@crapouillou.net> From: Andy Shevchenko Date: Mon, 8 Aug 2022 15:16:48 +0200 Message-ID: Subject: Re: [PATCH] leds: max8997: Don't error if there is no pdata To: Paul Cercueil Cc: Pavel Machek , Linux LED Subsystem , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sun, Aug 7, 2022 at 12:40 PM Paul Cercueil wrote: > > The driver will works just fine if no platform data was supplied. s/works/work/ ...or... s/will// With the above fix, Reviewed-by: Andy Shevchenko > Signed-off-by: Paul Cercueil > --- > drivers/leds/leds-max8997.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/leds/leds-max8997.c b/drivers/leds/leds-max8997.c > index c0bddb33888d..c8d7f55c9dec 100644 > --- a/drivers/leds/leds-max8997.c > +++ b/drivers/leds/leds-max8997.c > @@ -238,11 +238,6 @@ static int max8997_led_probe(struct platform_device *pdev) > char name[20]; > int ret = 0; > > - if (pdata == NULL) { > - dev_err(&pdev->dev, "no platform data\n"); > - return -ENODEV; > - } > - > led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL); > if (led == NULL) > return -ENOMEM; > @@ -258,7 +253,7 @@ static int max8997_led_probe(struct platform_device *pdev) > led->iodev = iodev; > > /* initialize mode and brightness according to platform_data */ > - if (pdata->led_pdata) { > + if (pdata && pdata->led_pdata) { > u8 mode = 0, brightness = 0; > > mode = pdata->led_pdata->mode[led->id]; -- With Best Regards, Andy Shevchenko