Re: [PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c

[Bryan Wu <cooloney@gmail.com>]

On Tue, Jun 16, 2015 at 1:23 AM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Hi Paul,
>
>
> On 06/16/2015 12:12 AM, Paul Gortmaker wrote:
>>
>> This file is built for a bool Kconfig variable, and hence this
>> code is either present or absent.  It currently can never be
>> modular, so using module_init as an alias for __initcall can be
>> somewhat misleading.
>>
>> Fix this up now, so that we can relocate module_init from
>> init.h into module.h in the future.  If we don't do this, we'd
>> have to add module.h to obviously non-modular code, and that
>> would be a worse thing.
>>
>> Note that direct use of __initcall is discouraged, vs. one
>> of the priority categorized subgroups.  As __initcall gets
>> mapped onto device_initcall, our use of device_initcall
>> directly in this change means that the runtime impact is
>> zero -- it will remain at level 6 in initcall ordering.
>>
>> And since it can't be modular, we remove all the __exitcall
>> stuff related to module_exit() -- it is dead code that won't
>> ever be executed.
>>
>> Cc: Bryan Wu <cooloney@gmail.com>
>> Cc: Richard Purdie <rpurdie@rpsys.net>
>> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
>> Cc: linux-leds@vger.kernel.org
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>> ---
>> [
>>   To be appended to the branch content originally sent as:
>>   "Replace module_init with device_initcall in non modules"
>>
>> https://lkml.kernel.org/r/1432860493-23831-1-git-send-email-paul.gortmaker@windriver.com
>> ]
>>
>>   drivers/leds/leds-cobalt-raq.c | 15 +--------------
>>   1 file changed, 1 insertion(+), 14 deletions(-)
>
>
> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>

Thanks, merged.

-Bryan