From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Wu Subject: Re: [PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c Date: Tue, 16 Jun 2015 12:09:31 -0700 Message-ID: References: <1434406367-32251-1-git-send-email-paul.gortmaker@windriver.com> <557FDD0E.8000000@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-pd0-f171.google.com ([209.85.192.171]:33356 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932188AbbFPTJw (ORCPT ); Tue, 16 Jun 2015 15:09:52 -0400 In-Reply-To: <557FDD0E.8000000@samsung.com> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: Jacek Anaszewski Cc: Paul Gortmaker , lkml , Richard Purdie , Linux LED Subsystem On Tue, Jun 16, 2015 at 1:23 AM, Jacek Anaszewski wrote: > Hi Paul, > > > On 06/16/2015 12:12 AM, Paul Gortmaker wrote: >> >> This file is built for a bool Kconfig variable, and hence this >> code is either present or absent. It currently can never be >> modular, so using module_init as an alias for __initcall can be >> somewhat misleading. >> >> Fix this up now, so that we can relocate module_init from >> init.h into module.h in the future. If we don't do this, we'd >> have to add module.h to obviously non-modular code, and that >> would be a worse thing. >> >> Note that direct use of __initcall is discouraged, vs. one >> of the priority categorized subgroups. As __initcall gets >> mapped onto device_initcall, our use of device_initcall >> directly in this change means that the runtime impact is >> zero -- it will remain at level 6 in initcall ordering. >> >> And since it can't be modular, we remove all the __exitcall >> stuff related to module_exit() -- it is dead code that won't >> ever be executed. >> >> Cc: Bryan Wu >> Cc: Richard Purdie >> Cc: Jacek Anaszewski >> Cc: linux-leds@vger.kernel.org >> Signed-off-by: Paul Gortmaker >> --- >> [ >> To be appended to the branch content originally sent as: >> "Replace module_init with device_initcall in non modules" >> >> https://lkml.kernel.org/r/1432860493-23831-1-git-send-email-paul.gortmaker@windriver.com >> ] >> >> drivers/leds/leds-cobalt-raq.c | 15 +-------------- >> 1 file changed, 1 insertion(+), 14 deletions(-) > > > Acked-by: Jacek Anaszewski > Thanks, merged. -Bryan