From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Wu Subject: Re: [PATCH/RFC v8 03/14] Documentation: leds: Add description of v4l2-flash sub-device Date: Fri, 5 Dec 2014 11:50:01 -0800 Message-ID: References: <1417166286-27685-1-git-send-email-j.anaszewski@samsung.com> <1417166286-27685-4-git-send-email-j.anaszewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1417166286-27685-4-git-send-email-j.anaszewski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Linux LED Subsystem , "linux-media@vger.kernel.org" , lkml , Kyungmin Park , b.zolnierkie@samsung.com, Pavel Machek , "rpurdie@rpsys.net" , Sakari Ailus , Sylwester Nawrocki List-Id: linux-leds@vger.kernel.org On Fri, Nov 28, 2014 at 1:17 AM, Jacek Anaszewski wrote: > This patch extends LED Flash class documention by > the description of interactions with v4l2-flash sub-device. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- This patch looks good to me. I will take it with other patches! Thanks, -Bryan > Documentation/leds/leds-class-flash.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/leds/leds-class-flash.txt b/Documentation/leds/leds-class-flash.txt > index d68565c..1a611ec 100644 > --- a/Documentation/leds/leds-class-flash.txt > +++ b/Documentation/leds/leds-class-flash.txt > @@ -46,3 +46,16 @@ Following sysfs attributes are exposed for controlling flash led devices: > until this flag is no longer set > * 0x100 - the temperature of the LED has exceeded its allowed > upper limit > + > +A LED subsystem driver can be controlled also from the level of VideoForLinux2 > +subsystem. In order to enable this CONFIG_V4L2_FLASH_LED_CLASS symbol has to > +be defined in the kernel config. The driver must call the v4l2_flash_init > +function to get registered in the V4L2 subsystem. On remove the > +v4l2_flash_release function has to be called (see ). > + > +After proper initialization a V4L2 Flash sub-device is created. The sub-device > +exposes a number of V4L2 controls, which allow for controlling a LED Flash class > +device with use of its internal kernel API. > +Opening the V4L2 Flash sub-device makes the LED subsystem sysfs interface > +unavailable. The interface is re-enabled after the V4L2 Flash sub-device > +is closed. > -- > 1.7.9.5 >