Re: [PATCH 1/5] leds: leds-ss4200: fix incorrect placement of __initdata marker

[Bryan Wu <cooloney@gmail.com>]

On Tue, Feb 25, 2014 at 9:09 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> The __initdata marker can be virtually anywhere on the line,
> EXCEPT right after "struct". The preferred location is before
> the "=" sign if there is one, or before the trailing ";"
> otherwise. It also fixes the following chechpatch warning.
>
>   WARNING: __initdata should be placed after nodetect
>

Good, I merged it.
Thanks, -Bryan

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/leds/leds-ss4200.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
> index 5b8f938..3faf550 100644
> --- a/drivers/leds/leds-ss4200.c
> +++ b/drivers/leds/leds-ss4200.c
> @@ -78,7 +78,7 @@ static int __init ss4200_led_dmi_callback(const struct dmi_system_id *id)
>         return 1;
>  }
>
> -static bool __initdata nodetect;
> +static bool nodetect __initdata;
>  module_param_named(nodetect, nodetect, bool, 0);
>  MODULE_PARM_DESC(nodetect, "Skip DMI-based hardware detection");
>
> --
> 1.7.10.4
>
>