From: Bryan Wu <cooloney@gmail.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Linux LED Subsystem <linux-leds@vger.kernel.org>,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] leds: fix max77693-led build errors
Date: Mon, 29 Jun 2015 10:09:53 -0700 [thread overview]
Message-ID: <CAK5ve-KL985j1L_BWkjKEm+XtVYXaugqowLEELHybSwZX2kpYA@mail.gmail.com> (raw)
In-Reply-To: <1435589123-23545-1-git-send-email-j.anaszewski@samsung.com>
On Mon, Jun 29, 2015 at 7:45 AM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Fix build errors when LEDS_MAX77693=y and V4L2_FLASH_LED_CLASS=m
> by restricting LEDS_MAX77693 to =m if V4L2_FLASH_LED_CLASS=m.
>
> drivers/leds/leds-max77693.c:1062: undefined reference to `v4l2_flash_release'
> drivers/leds/leds-max77693.c:1068: undefined reference to `v4l2_flash_release'
> drivers/built-in.o: In function `max77693_register_led':
> drivers/leds/leds-max77693.c:968: undefined reference to `v4l2_flash_init'
> drivers/built-in.o: In function `max77693_led_probe':
> drivers/leds/leds-max77693.c:1048: undefined reference to `v4l2_flash_release'
>
Merged, thanks,
-Bryan
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
> drivers/leds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index a817a13..9ad35f7 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -502,6 +502,7 @@ config LEDS_TLC591XX
> config LEDS_MAX77693
> tristate "LED support for MAX77693 Flash"
> depends on LEDS_CLASS_FLASH
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> depends on MFD_MAX77693
> depends on OF
> help
> --
> 1.7.9.5
>
prev parent reply other threads:[~2015-06-29 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 14:45 [PATCH] leds: fix max77693-led build errors Jacek Anaszewski
2015-06-29 17:09 ` Bryan Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK5ve-KL985j1L_BWkjKEm+XtVYXaugqowLEELHybSwZX2kpYA@mail.gmail.com \
--to=cooloney@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).