* [PATCH] leds: fix max77693-led build errors
@ 2015-06-29 14:45 Jacek Anaszewski
2015-06-29 17:09 ` Bryan Wu
0 siblings, 1 reply; 2+ messages in thread
From: Jacek Anaszewski @ 2015-06-29 14:45 UTC (permalink / raw)
To: linux-leds; +Cc: Jacek Anaszewski, Bryan Wu, Richard Purdie
Fix build errors when LEDS_MAX77693=y and V4L2_FLASH_LED_CLASS=m
by restricting LEDS_MAX77693 to =m if V4L2_FLASH_LED_CLASS=m.
drivers/leds/leds-max77693.c:1062: undefined reference to `v4l2_flash_release'
drivers/leds/leds-max77693.c:1068: undefined reference to `v4l2_flash_release'
drivers/built-in.o: In function `max77693_register_led':
drivers/leds/leds-max77693.c:968: undefined reference to `v4l2_flash_init'
drivers/built-in.o: In function `max77693_led_probe':
drivers/leds/leds-max77693.c:1048: undefined reference to `v4l2_flash_release'
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/leds/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index a817a13..9ad35f7 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -502,6 +502,7 @@ config LEDS_TLC591XX
config LEDS_MAX77693
tristate "LED support for MAX77693 Flash"
depends on LEDS_CLASS_FLASH
+ depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
depends on MFD_MAX77693
depends on OF
help
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: fix max77693-led build errors
2015-06-29 14:45 [PATCH] leds: fix max77693-led build errors Jacek Anaszewski
@ 2015-06-29 17:09 ` Bryan Wu
0 siblings, 0 replies; 2+ messages in thread
From: Bryan Wu @ 2015-06-29 17:09 UTC (permalink / raw)
To: Jacek Anaszewski; +Cc: Linux LED Subsystem, Richard Purdie
On Mon, Jun 29, 2015 at 7:45 AM, Jacek Anaszewski
<j.anaszewski@samsung.com> wrote:
> Fix build errors when LEDS_MAX77693=y and V4L2_FLASH_LED_CLASS=m
> by restricting LEDS_MAX77693 to =m if V4L2_FLASH_LED_CLASS=m.
>
> drivers/leds/leds-max77693.c:1062: undefined reference to `v4l2_flash_release'
> drivers/leds/leds-max77693.c:1068: undefined reference to `v4l2_flash_release'
> drivers/built-in.o: In function `max77693_register_led':
> drivers/leds/leds-max77693.c:968: undefined reference to `v4l2_flash_init'
> drivers/built-in.o: In function `max77693_led_probe':
> drivers/leds/leds-max77693.c:1048: undefined reference to `v4l2_flash_release'
>
Merged, thanks,
-Bryan
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
> drivers/leds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index a817a13..9ad35f7 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -502,6 +502,7 @@ config LEDS_TLC591XX
> config LEDS_MAX77693
> tristate "LED support for MAX77693 Flash"
> depends on LEDS_CLASS_FLASH
> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> depends on MFD_MAX77693
> depends on OF
> help
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-29 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-29 14:45 [PATCH] leds: fix max77693-led build errors Jacek Anaszewski
2015-06-29 17:09 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).