Re: [PATCH v2 0/3] LED triggers for USB host and device

[Bryan Wu <cooloney@gmail.com>]

On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka <sojka@merica.cz> wrote:
> This adds LED triggers for USB host and device.
>
> Changes from v1:
> - Moved from drivers/leds/ to drivers/usb/
> - Improved Kconfig help
> - Linked with other modules rather than being standalone modules
>
> Michal Sojka (3):
>   usb: Add missing #include
>   usb: Add LED trigger for USB host activity
>   usb: Add LED trigger for USB gadget activity
>
>  drivers/usb/core/Kconfig        |  9 +++++++++
>  drivers/usb/core/Makefile       |  1 +
>  drivers/usb/core/hcd.c          |  2 ++
>  drivers/usb/core/led.c          | 38 ++++++++++++++++++++++++++++++++++++++

I suggest put host trigger and gadget trigger together in
drivers/usb/core/led.c.

>  drivers/usb/gadget/Kconfig      | 12 ++++++++++++
>  drivers/usb/gadget/udc/Makefile |  5 ++++-
>  drivers/usb/gadget/udc/led.c    | 38 ++++++++++++++++++++++++++++++++++++++

We don't need a duplicated version for gadget.

>  drivers/usb/musb/musb_gadget.c  |  5 +++--
>  include/linux/usb/gadget.h      | 10 ++++++++++
>  include/linux/usb/hcd.h         |  7 +++++++
>  10 files changed, 124 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/usb/core/led.c
>  create mode 100644 drivers/usb/gadget/udc/led.c
>
> --
> 2.1.0
>