linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: jacek.anaszewski@gmail.com, Richard Purdie <rpurdie@rpsys.net>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: pwm-led turns on during suspend
Date: Fri, 17 Nov 2017 11:27:32 -0200	[thread overview]
Message-ID: <CAOMZO5D66OW+pxC-11LVLnxoZ2=kCXRrJZkO1v+FbQpw0=qxFw@mail.gmail.com> (raw)
In-Reply-To: <20171117124505.GP31757@n2100.armlinux.org.uk>

Hi Russell,

On Fri, Nov 17, 2017 at 10:45 AM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:

> The LED is wired to the 3.3V supply, and most likely the PWM output goes
> low when the SoC suspends.  As SolidRun boards don't have support for
> powering down the board supplies, the 3.3V supply does not collapse on
> suspend.

I managed to fix this by introducing pinctrl_pm_select_sleep_state()
support into drivers/leds/leds-pwm.c.

Here is the complete change:
https://pastebin.com/FCsLMuW1

Now I can get the LED to be turned off during suspend.

I will separate the changes and submit the patches.

Thanks

      reply	other threads:[~2017-11-17 13:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 12:31 pwm-led turns on during suspend Fabio Estevam
2017-11-17 12:45 ` Russell King - ARM Linux
2017-11-17 13:27   ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5D66OW+pxC-11LVLnxoZ2=kCXRrJZkO1v+FbQpw0=qxFw@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).