From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 132463ECBCC; Wed, 15 Apr 2026 17:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776274238; cv=none; b=CL/3+Fi2RKdx1VtbgipbSNGmAgrRrFz/E2oJbRr7R5/uU/Zgrdz0eMyfpQVXgUi/IQZEIRuTUJ2Lur16lDzkY4c5bDek1tL6VLF/Y10lylMe3OJU05fQNFTE87B723CJrgJEmC96Almc3r6gEkLSZ/+VzLwFVDyLnyN9QPJI84M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776274238; c=relaxed/simple; bh=qdi/nhUMdFGJLsMXflK6dnMGj0s+20mNJIk0XH5Wevg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=T96zbJ0I4lt51GRl9TQjdqOSx/r1bbwG1ywJLooUXtoG06C/kQMSylUUkTfhq2lgSXiqHPE1m6nx2aXF9SHKs3lVpBEiNvowyTpzqfhsUm0cLNUUD/POG3sR6O17ICawDr0MJMPLi/xlU2+ktJeQPfOUd3uAA0cApL/NRhaXFBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=UvIHm5KI; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="UvIHm5KI" Received: from [127.0.0.1] (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 89C0927128; Wed, 15 Apr 2026 19:30:31 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id lTlVcM1qlI08; Wed, 15 Apr 2026 19:30:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1776274230; bh=qdi/nhUMdFGJLsMXflK6dnMGj0s+20mNJIk0XH5Wevg=; h=Date:Cc:Subject:From:To:References:In-Reply-To; b=UvIHm5KI2b76Drc7fvFQmjy5Wk+JLF0Ti9T4CTiQhJxmegfJueVfLSgwOcbg7skRG pWSLOPsx4Qs3bBOGwC6WezoDxaOQYGYng7wgLwvWQ2VQcRZMPGv7L/FWTaib+4xjXY +2Tp5jKqWBEeW7bFtp95T3nHB1odT2vJT8mOEfCbe3ECcsxxrHqVhrrk9DfDzeMnjs cqMFkpzWStkU1n3Eg2/mrUdnWXQrjEyUi3U6rKzUhS0pUSL/6gd3yRsgXQgHSkkiMG ZnQ+Pie2AbrGE0/zL0UfbNWNK51Z0FwPEXgnbPc8l/d7VLA20atOuhHbDaAyW+Cojt HEH1BoXDbiKyg== Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 15 Apr 2026 23:00:16 +0530 Message-Id: Cc: "Lee Jones" , "Pavel Machek" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "MyungJoo Ham" , "Chanwoo Choi" , "Sebastian Reichel" , =?utf-8?q?Andr=C3=A9_Draszik?= , "Alexandre Belloni" , "Jonathan Corbet" , "Shuah Khan" , "Nam Tran" , =?utf-8?q?=C5=81ukasz_Lebiedzi=C5=84ski?= , , , , , , , Subject: Re: [PATCH v4 02/13] dt-bindings: leds: document Samsung S2M series PMIC RGB LED device From: "Kaustabh Chakraborty" To: "Krzysztof Kozlowski" , "Kaustabh Chakraborty" References: <20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org> <20260414-s2mu005-pmic-v4-2-7fe7480577e6@disroot.org> <20260415-sensible-kiwi-of-argument-44d6ed@quoll> In-Reply-To: <20260415-sensible-kiwi-of-argument-44d6ed@quoll> On 2026-04-15 09:03 +02:00, Krzysztof Kozlowski wrote: > On Tue, Apr 14, 2026 at 12:02:54PM +0530, Kaustabh Chakraborty wrote: >> +description: | >> + The Samsung S2M series PMIC RGB LED is a three-channel LED device wit= h >> + 8-bit brightness control for each channel, typically used as status >> + indicators in mobile phones. >> + >> + This is a part of device tree bindings for S2M and S5M family of Powe= r >> + Management IC (PMIC). >> + >> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml f= or >> + additional information and example. >> + >> +allOf: >> + - $ref: common.yaml# > > Rob's comment is still valid: > 1. How do you address one of three LEDs in non-RGB case? > 2. Where is multi-color? Yes, multi-color should have been added here. > > And based on this alone without other properties, I say this should be > part of top-level schema. Separate node is fine, but no need for > separate binding. BTW, for loading the sub-device driver via platform (as it won't be a separate binding) the driver *must* be built-in. Although not related to bindings, this seems counter-intuitive. I see the same problem with the PMIC charger. > > Best regards, > Krzysztof