From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA26839FCD7; Thu, 16 Apr 2026 12:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776341761; cv=none; b=lTPLg9oQ3gwrrazUKgODYEfCkd7jjJxAwblRxuaKKJDT95O3JNJequKS3+RhyVdrjMfHPom3RoYrh/4d9E4Ct9CRFbsoUbTkqbQQLKKAcB/jDLSHc2CqeSsvQq54wEYePWp0ZdPuAzxuNuBG8b6DOLtccQXOz5tMnGZx5XRHqBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776341761; c=relaxed/simple; bh=gZLO9lN2kJhvahZVktWGr0uWFAt2YTX/UxFa5gJq4A8=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=oSwzCM+QvK7GCVlyRsnBticF0MXmXzk+u1Vk/OPpp6jkJGtYFqLEvDyWPIi0HCIcYRqiymwyjiXdJM1GKnXrfkyu++VcELlMwP0w+dokA74lVkrdGsUdQjCTM9naHapg+bISksjAGn7ZMmrMurQRRN96Pdc5gqTjmAilQ+AWHR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=S7USaVxd; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="S7USaVxd" Received: from [127.0.0.1] (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id D25DF2652E; Thu, 16 Apr 2026 14:15:56 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id X6_CcIs2Vbau; Thu, 16 Apr 2026 14:15:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1776341756; bh=gZLO9lN2kJhvahZVktWGr0uWFAt2YTX/UxFa5gJq4A8=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=S7USaVxd65Og3uIBkajZCPvp5uwQZmZ7aCXvg10iCZY+jeBRc/BMfVzEvDleesVkg zLq8XGpCS0tbNavffePMl5DA6RCAH0jOM3KNEmy5DCj6a0BoGV38qsN26VB1WglB7t fT2puLTOvqjZiVoA4BPCbpyKRCY7189XIxmioDYpRAAY/NN3q5RkjOBI0gRM7u6zGc +egLI8//Sm2SGNidrv5TEjS9Gga2NeNfGKOSFk/CdPDViYFLc2W7m+N52QVgB0Wml0 w4rlnKVUAdQ3K9UVfY7NGHeml8SVHt8HFxkwEyJRqhYpuUgRRuJ8tdEmGnjN2t1UzP GQiJcPVvGWHEQ== Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 16 Apr 2026 17:45:32 +0530 Message-Id: Subject: Re: [PATCH v4 02/13] dt-bindings: leds: document Samsung S2M series PMIC RGB LED device From: "Kaustabh Chakraborty" To: "Krzysztof Kozlowski" , "Kaustabh Chakraborty" Cc: "Lee Jones" , "Pavel Machek" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "MyungJoo Ham" , "Chanwoo Choi" , "Sebastian Reichel" , =?utf-8?q?Andr=C3=A9_Draszik?= , "Alexandre Belloni" , "Jonathan Corbet" , "Shuah Khan" , "Nam Tran" , =?utf-8?q?=C5=81ukasz_Lebiedzi=C5=84ski?= , , , , , , , References: <20260414-s2mu005-pmic-v4-0-7fe7480577e6@disroot.org> <20260414-s2mu005-pmic-v4-2-7fe7480577e6@disroot.org> <20260415-sensible-kiwi-of-argument-44d6ed@quoll> <20260416-upbeat-archetypal-mantis-1ede48@quoll> In-Reply-To: <20260416-upbeat-archetypal-mantis-1ede48@quoll> On 2026-04-16 10:23 +02:00, Krzysztof Kozlowski wrote: > On Wed, Apr 15, 2026 at 11:00:16PM +0530, Kaustabh Chakraborty wrote: >> On 2026-04-15 09:03 +02:00, Krzysztof Kozlowski wrote: >> > On Tue, Apr 14, 2026 at 12:02:54PM +0530, Kaustabh Chakraborty wrote: >> >> +description: | >> >> + The Samsung S2M series PMIC RGB LED is a three-channel LED device = with >> >> + 8-bit brightness control for each channel, typically used as statu= s >> >> + indicators in mobile phones. >> >> + >> >> + This is a part of device tree bindings for S2M and S5M family of P= ower >> >> + Management IC (PMIC). >> >> + >> >> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yam= l for >> >> + additional information and example. >> >> + >> >> +allOf: >> >> + - $ref: common.yaml# >> > >> > Rob's comment is still valid: >> > 1. How do you address one of three LEDs in non-RGB case? >> > 2. Where is multi-color? >>=20 >> Yes, multi-color should have been added here. >>=20 >> > >> > And based on this alone without other properties, I say this should be >> > part of top-level schema. Separate node is fine, but no need for >> > separate binding. >>=20 >> BTW, for loading the sub-device driver via platform (as it won't be a >> separate binding) the driver *must* be built-in. Although not related to >> bindings, this seems counter-intuitive. I see the same problem with the > > I don't understand that comment. If it has nothing to do with the > binding, what is the problem? It was an unrelated user-space issue, so ignore. > > Best regards, > Krzysztof