From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608D5C4363A for ; Mon, 5 Oct 2020 18:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03A9020853 for ; Mon, 5 Oct 2020 18:31:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725960AbgJESbS (ORCPT ); Mon, 5 Oct 2020 14:31:18 -0400 Received: from w1.tutanota.de ([81.3.6.162]:35210 "EHLO w1.tutanota.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726935AbgJESbS (ORCPT ); Mon, 5 Oct 2020 14:31:18 -0400 Received: from w3.tutanota.de (unknown [192.168.1.164]) by w1.tutanota.de (Postfix) with ESMTP id 9CDB6FA0400; Mon, 5 Oct 2020 18:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1601922676; s=s1; d=tutanota.com; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=FyGnVACqUfIMK6u5r4pLOucerf6LwFRTJg4C0HOGYDc=; b=LPz0pzRVpMFFYJFbY7NhGduQgYIm4s54WWDLM+LuKF1m+dNJkNzfl0HalHEWFzqm g3X8R1ESBEIn6Ewyp3IS+5aUNnlIui6UARYCAHbCQm4SFNOFojv3mzXwraVojnK8Irp 9tJ0oQXuY4X2C0Y/jJACEhxxhTboP00co9ejFbYi/8Qco6BFKaOOj05YZIZBtxwKau3 7AshDGb/pRyV59NIPCMmfhgvyzXdo+Apc9Ral6quuty392PPRXQTcwxvX8nhYcDFmzN jp9/Wfh1q5vX4AhgEeBZnBI0ZtcA2MSxXI4755BZMT+ndmGsGcJLcVMBQnT0/yLisXR DhywylX+mA== Date: Mon, 5 Oct 2020 20:31:16 +0200 (CEST) From: ultracoolguy@tutanota.com To: Pavel Machek Cc: Alexander Dahl , Dmurphy , Marek Behun , Linux Leds , Linux Kernel Message-ID: In-Reply-To: References: <20201005141334.36d9441a@blackhole.sk> <3c5fce56-8604-a7d5-1017-8a075f67061e@ti.com> <966c3f39-1310-dd60-6f33-0d9464ed2ff1@ti.com> <20201005164808.slrtmsvmw4pvwppm@falbala.internal.home.lespocky.de> <20201005173227.GA6431@duo.ucw.cz> Subject: Re: [PATCH] leds: lm3697: Fix out-of-bound access MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Otherwise everything works great :) (And sorry for sending two emails) Oct 5, 2020, 18:29 by ultracoolguy@tutanota.com: > This:=20 > > led->num_banks =3D count;=20 > > Has to be below devm_kzalloc. Else, it's NULL. > Oct 5, 2020, 17:32 by pavel@ucw.cz: > >> Hi! >> >>> Agh. I added the Signed-off-by in an earlier non-published version of t= he commit, but forgot to add it back. But that doesn't really excuses me. >>> >>> I attached the (hopefully) final version of this patch.=C2=A0 Pavel, I'= ll send the struct rename separately after I submit this.=20 >>> >> >> Thanks, I applied it with ... some tweaks. I hope I did not break it, >> and would not mind testing. >> >> Best regards, >> Pavel >> >> >> --=20 >> (english) http://www.livejournal.com/~pavelmachek >> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/= blog.html >> > >