From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: chengwei <larry.lai@yunjingtech.com>,
lee@kernel.org, pavel@ucw.cz, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org,
GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com,
jack.chang@yunjingtech.com, noah.hung@yunjingtech.com,
Javier Arteaga <javier@emutex.com>,
Nicola Lunghi <nicola.lunghi@emutex.com>
Subject: Re: [PATCH V3 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA
Date: Wed, 9 Nov 2022 12:54:30 +0200 [thread overview]
Message-ID: <Y2uG5jrYeadqMNav@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdZQ7FCtLPEioWXn+MXQhnpuu-EY+CjhEeKqBe=Bvq777g@mail.gmail.com>
On Wed, Nov 09, 2022 at 10:27:59AM +0100, Linus Walleij wrote:
> On Wed, Nov 9, 2022 at 10:11 AM chengwei <larry.lai@yunjingtech.com> wrote:
...
> > +config PINCTRL_UPBOARD
> > + tristate "UP board FPGA pin controller"
> > + depends on ACPI
> > + depends on MFD_UPBOARD_FPGA
> > + depends on X86
>
> This is Andy territory as it is x86 and ACPI but...
It seems they forgot paying the respect to the reviewers by Cc'ing them.
...
> So this looks like it should be uncommented and used or deleted?
> It just looks unfinished, and this patch is not an RFC.
I'm wondering why it has v3 and not RFC in the Subject. So, no need to spend
time right now in reviewing this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-09 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 9:09 [PATCH V3 0/3] Add support control UP board CPLD/FPGA pin control chengwei
2022-11-09 9:09 ` [PATCH V3 1/3] mfd: Add support for UP board CPLD/FPGA chengwei
2022-11-16 15:13 ` Lee Jones
[not found] ` <SG2PR06MB37427F013BD702117467B8A7F91A9@SG2PR06MB3742.apcprd06.prod.outlook.com>
2022-12-08 10:35 ` 回覆: " Lee Jones
2022-11-09 9:09 ` [PATCH V3 2/3] pinctrl: Add support pin control " chengwei
2022-11-09 9:27 ` Linus Walleij
2022-11-09 10:54 ` Andy Shevchenko [this message]
2022-11-09 9:09 ` [PATCH V3 3/3] leds: Add support for UP board CPLD onboard LEDS chengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2uG5jrYeadqMNav@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=GaryWang@aaeon.com.tw \
--cc=jack.chang@yunjingtech.com \
--cc=javier@emutex.com \
--cc=larry.lai@yunjingtech.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=musa.lin@yunjingtech.com \
--cc=nicola.lunghi@emutex.com \
--cc=noah.hung@yunjingtech.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox