From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 773EFC47088 for ; Thu, 1 Dec 2022 13:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231128AbiLAN3Z (ORCPT ); Thu, 1 Dec 2022 08:29:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231164AbiLAN3Y (ORCPT ); Thu, 1 Dec 2022 08:29:24 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC008A9CFB; Thu, 1 Dec 2022 05:29:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1669901362; x=1701437362; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uzYyfpe5ovcmHtziruShrAihFDRO3ojyXNM6UnYgYzM=; b=tmHPurYXVLVpFYdLIqgvPMlbkSnnU1cf61uor8EnedPd6W6EiRJ2/9L2 9LYu66/FnTpawxLZnYi2WzvCsOGfqeX9ruSm2407lvDaG6+BoIL7cvnoW j3ag1ouTyhU2k0qPX43lzIKbY0jDEBbV6JUldQ0trVVpFBqBD5PcGGiH9 ehspGwxj8pjoNHlohJCQrR5qDO0lWu9bVWCvBXQuxgw3tBY1DT6+ZfMRZ rshnmCO43TlbTZNjAnXrIdJniAsnLRFj2Idg4Zh7I0GAYn9HMnhHZ4uXq juXqDDqIcDdjlUgIjc0OKzTvwwZ2lC+E+kp4N+8lBZf58cwmfjUbX16FQ g==; X-IronPort-AV: E=Sophos;i="5.96,209,1665471600"; d="scan'208";a="125998122" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 01 Dec 2022 06:29:21 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 1 Dec 2022 06:29:09 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Thu, 1 Dec 2022 06:29:01 -0700 Date: Thu, 1 Dec 2022 13:28:42 +0000 From: Conor Dooley To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= CC: Alexandre Belloni , Alexandre Torgue , , "Douglas Anderson" , Thierry Reding , Satya Priya , Pavel Machek , "Guenter Roeck" , Marijn Suijten , Nobuhiro Iwamatsu , , , "Jerome Brunet" , , "Florian Fainelli" , Samuel Holland , "Sean Anderson" , Kevin Hilman , Bartosz Golaszewski , Michal Simek , , Hammer Hsieh , , Chen-Yu Tsai , Matthias Kaehlcke , "Broadcom internal kernel review list" , NXP Linux Team , Orson Zhai , , , "Pengutronix Kernel Team" , Martin Blumenstingl , Ray Jui , "Sascha Hauer" , Steven Rostedt , "Stephen Boyd" , , Fabrice Gasnier , , , Baolin Wang , Paul Walmsley , Matthias Brugger , , , Scott Branden , Bjorn Andersson , Nicolas Ferre , "Michael Walle" , Palmer Dabbelt , "Masami Hiramatsu" , Maxime Coquelin , Chunyan Zhang , Shawn Guo , Claudiu Beznea Subject: Re: [PATCH v2 00/11] pwm: Allow .get_state to fail Message-ID: References: <20221130152148.2769768-1-u.kleine-koenig@pengutronix.de> <20221201131907.bmrenldnua7uaeab@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221201131907.bmrenldnua7uaeab@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, Dec 01, 2022 at 02:19:07PM +0100, Uwe Kleine-König wrote: > Hello Conor, > > On Thu, Dec 01, 2022 at 11:11:51AM +0000, Conor Dooley wrote: > > TL;DR, I quite like the ability to return an error and not mislead the > > caller. > > Is this an Ack? It is if you want it to be! I didn't really feel qualified to do so which is why I gave some context etc. I did check out the callsites for the non-void returning op, and it looked good to me, so sure, why not: Acked-by: Conor Dooley Thanks, Conor.