Re: [PATCH v3 09/11] platform/x86: int3472/discrete: Move GPIO request to skl_int3472_register_clock()

Hans de Goede
2022-12-16T16:36:44Z

Hi,

On 12/16/22 15:20, Andy Shevchenko wrote:
> On Fri, Dec 16, 2022 at 12:30:11PM +0100, Hans de Goede wrote:
>> Move the requesting of the clk-enable GPIO to skl_int3472_register_clock()
>> (and move the gpiod_put to unregister).
>>
>> This mirrors the GPIO handling in skl_int3472_register_regulator() and
>> allows removing skl_int3472_map_gpio_to_clk() from discrete.c .
>
> Extra space.

Fixed in my local tree.

>
> ...
>
>> + int3472->clock.ena_gpio = acpi_get_and_request_gpiod(path, agpio->pin_table[0],
>> + "int3472,clk-enable");
>> + if (IS_ERR(int3472->clock.ena_gpio)) {
>
> return dev_err_probe(...); ?

That would make the line longer then 100 chars.

Regards,

Hans

>
>> + ret = PTR_ERR(int3472->clock.ena_gpio);
>> + return dev_err_probe(int3472->dev, ret, "getting regulator GPIO\n");
>> + }
>