Re: [PATCH v3 09/11] platform/x86: int3472/discrete: Move GPIO request to skl_int3472_register_clock()

Andy Shevchenko
2022-12-16T17:15:34Z

On Fri, Dec 16, 2022 at 05:35:51PM +0100, Hans de Goede wrote:
> On 12/16/22 15:20, Andy Shevchenko wrote:
> > On Fri, Dec 16, 2022 at 12:30:11PM +0100, Hans de Goede wrote:

...

> >> + int3472->clock.ena_gpio = acpi_get_and_request_gpiod(path, agpio->pin_table[0],
> >> + "int3472,clk-enable");
> >> + if (IS_ERR(int3472->clock.ena_gpio)) {
> >
> > return dev_err_probe(...); ?
>
> That would make the line longer then 100 chars.

Maybe I wasn't clear, the point is to get rid of ret assignment (the rest can
be resplit as you wish).

> >> + ret = PTR_ERR(int3472->clock.ena_gpio);
> >> + return dev_err_probe(int3472->dev, ret, "getting regulator GPIO\n");
> >> + }

--
With Best Regards,
Andy Shevchenko