* [PATCH 268/606] leds: bd2802: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 269/606] leds: blinkm: " Uwe Kleine-König
` (27 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-bd2802.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-bd2802.c b/drivers/leds/leds-bd2802.c
index 2b6678f6bd56..601185ddabcc 100644
--- a/drivers/leds/leds-bd2802.c
+++ b/drivers/leds/leds-bd2802.c
@@ -656,8 +656,7 @@ static void bd2802_unregister_led_classdev(struct bd2802_led *led)
led_classdev_unregister(&led->cdev_led1r);
}
-static int bd2802_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int bd2802_probe(struct i2c_client *client)
{
struct bd2802_led *led;
int ret, i;
@@ -787,7 +786,7 @@ static struct i2c_driver bd2802_i2c_driver = {
.name = "BD2802",
.pm = &bd2802_pm,
},
- .probe = bd2802_probe,
+ .probe_new = bd2802_probe,
.remove = bd2802_remove,
.id_table = bd2802_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 269/606] leds: blinkm: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 268/606] leds: bd2802: Convert to i2c's .probe_new() Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 270/606] leds: is31fl32xx: " Uwe Kleine-König
` (26 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Jan-Simon Moeller, Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-blinkm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
index 3fb6a2fdaefa..414b659d2ddb 100644
--- a/drivers/leds/leds-blinkm.c
+++ b/drivers/leds/leds-blinkm.c
@@ -565,8 +565,7 @@ static int blinkm_detect(struct i2c_client *client, struct i2c_board_info *info)
return 0;
}
-static int blinkm_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int blinkm_probe(struct i2c_client *client)
{
struct blinkm_data *data;
struct blinkm_led *led[3];
@@ -731,7 +730,7 @@ static struct i2c_driver blinkm_driver = {
.driver = {
.name = "blinkm",
},
- .probe = blinkm_probe,
+ .probe_new = blinkm_probe,
.remove = blinkm_remove,
.id_table = blinkm_id,
.detect = blinkm_detect,
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 270/606] leds: is31fl32xx: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 268/606] leds: bd2802: Convert to i2c's .probe_new() Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 269/606] leds: blinkm: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 271/606] leds: lm3530: " Uwe Kleine-König
` (25 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-is31fl32xx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c
index 0d219c1ac3b5..799191859ce0 100644
--- a/drivers/leds/leds-is31fl32xx.c
+++ b/drivers/leds/leds-is31fl32xx.c
@@ -422,8 +422,7 @@ static const struct of_device_id of_is31fl32xx_match[] = {
MODULE_DEVICE_TABLE(of, of_is31fl32xx_match);
-static int is31fl32xx_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int is31fl32xx_probe(struct i2c_client *client)
{
const struct is31fl32xx_chipdef *cdef;
struct device *dev = &client->dev;
@@ -489,7 +488,7 @@ static struct i2c_driver is31fl32xx_driver = {
.name = "is31fl32xx",
.of_match_table = of_is31fl32xx_match,
},
- .probe = is31fl32xx_probe,
+ .probe_new = is31fl32xx_probe,
.remove = is31fl32xx_remove,
.id_table = is31fl32xx_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 271/606] leds: lm3530: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (2 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 270/606] leds: is31fl32xx: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 272/606] leds: lm3532: " Uwe Kleine-König
` (24 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lm3530.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
index ba906c253c7f..a9a2018592ff 100644
--- a/drivers/leds/leds-lm3530.c
+++ b/drivers/leds/leds-lm3530.c
@@ -405,8 +405,7 @@ static struct attribute *lm3530_attrs[] = {
};
ATTRIBUTE_GROUPS(lm3530);
-static int lm3530_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lm3530_probe(struct i2c_client *client)
{
struct lm3530_platform_data *pdata = dev_get_platdata(&client->dev);
struct lm3530_data *drvdata;
@@ -485,7 +484,7 @@ static const struct i2c_device_id lm3530_id[] = {
MODULE_DEVICE_TABLE(i2c, lm3530_id);
static struct i2c_driver lm3530_i2c_driver = {
- .probe = lm3530_probe,
+ .probe_new = lm3530_probe,
.remove = lm3530_remove,
.id_table = lm3530_id,
.driver = {
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 272/606] leds: lm3532: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (3 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 271/606] leds: lm3530: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 273/606] leds: lm355x: " Uwe Kleine-König
` (23 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lm3532.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
index db64d44bcbbf..a08c09129a68 100644
--- a/drivers/leds/leds-lm3532.c
+++ b/drivers/leds/leds-lm3532.c
@@ -663,8 +663,7 @@ static int lm3532_parse_node(struct lm3532_data *priv)
return ret;
}
-static int lm3532_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lm3532_probe(struct i2c_client *client)
{
struct lm3532_data *drvdata;
int ret = 0;
@@ -727,7 +726,7 @@ static const struct i2c_device_id lm3532_id[] = {
MODULE_DEVICE_TABLE(i2c, lm3532_id);
static struct i2c_driver lm3532_i2c_driver = {
- .probe = lm3532_probe,
+ .probe_new = lm3532_probe,
.remove = lm3532_remove,
.id_table = lm3532_id,
.driver = {
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 273/606] leds: lm355x: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (4 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 272/606] leds: lm3532: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 274/606] leds: lm3642: " Uwe Kleine-König
` (22 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lm355x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c
index daa35927b301..612873070ca4 100644
--- a/drivers/leds/leds-lm355x.c
+++ b/drivers/leds/leds-lm355x.c
@@ -396,9 +396,9 @@ static const struct regmap_config lm355x_regmap = {
};
/* module initialize */
-static int lm355x_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lm355x_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct lm355x_platform_data *pdata = dev_get_platdata(&client->dev);
struct lm355x_chip_data *chip;
@@ -516,7 +516,7 @@ static struct i2c_driver lm355x_i2c_driver = {
.name = LM355x_NAME,
.pm = NULL,
},
- .probe = lm355x_probe,
+ .probe_new = lm355x_probe,
.remove = lm355x_remove,
.id_table = lm355x_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 274/606] leds: lm3642: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (5 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 273/606] leds: lm355x: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 275/606] leds: lm3692x: " Uwe Kleine-König
` (21 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lm3642.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
index 428a5d928150..b75ee3546c2e 100644
--- a/drivers/leds/leds-lm3642.c
+++ b/drivers/leds/leds-lm3642.c
@@ -289,8 +289,7 @@ static struct attribute *lm3642_torch_attrs[] = {
};
ATTRIBUTE_GROUPS(lm3642_torch);
-static int lm3642_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lm3642_probe(struct i2c_client *client)
{
struct lm3642_platform_data *pdata = dev_get_platdata(&client->dev);
struct lm3642_chip_data *chip;
@@ -402,7 +401,7 @@ static struct i2c_driver lm3642_i2c_driver = {
.name = LM3642_NAME,
.pm = NULL,
},
- .probe = lm3642_probe,
+ .probe_new = lm3642_probe,
.remove = lm3642_remove,
.id_table = lm3642_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 275/606] leds: lm3692x: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (6 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 274/606] leds: lm3642: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 276/606] leds: lm3697: " Uwe Kleine-König
` (20 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lm3692x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index 54b4662bff41..66126d0666f5 100644
--- a/drivers/leds/leds-lm3692x.c
+++ b/drivers/leds/leds-lm3692x.c
@@ -456,9 +456,9 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
return ret;
}
-static int lm3692x_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lm3692x_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct lm3692x_led *led;
int ret;
@@ -518,7 +518,7 @@ static struct i2c_driver lm3692x_driver = {
.name = "lm3692x",
.of_match_table = of_lm3692x_leds_match,
},
- .probe = lm3692x_probe,
+ .probe_new = lm3692x_probe,
.remove = lm3692x_remove,
.id_table = lm3692x_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 276/606] leds: lm3697: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (7 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 275/606] leds: lm3692x: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 277/606] leds: lp3944: " Uwe Kleine-König
` (19 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lm3697.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3697.c b/drivers/leds/leds-lm3697.c
index 71231a60eebc..10e904bf40a0 100644
--- a/drivers/leds/leds-lm3697.c
+++ b/drivers/leds/leds-lm3697.c
@@ -299,8 +299,7 @@ static int lm3697_probe_dt(struct lm3697 *priv)
return ret;
}
-static int lm3697_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lm3697_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct lm3697 *led;
@@ -377,7 +376,7 @@ static struct i2c_driver lm3697_driver = {
.name = "lm3697",
.of_match_table = of_lm3697_leds_match,
},
- .probe = lm3697_probe,
+ .probe_new = lm3697_probe,
.remove = lm3697_remove,
.id_table = lm3697_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 277/606] leds: lp3944: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (8 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 276/606] leds: lm3697: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 278/606] leds: lp3952: " Uwe Kleine-König
` (18 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lp3944.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lp3944.c b/drivers/leds/leds-lp3944.c
index 673ad8c04f41..be47c66b2e00 100644
--- a/drivers/leds/leds-lp3944.c
+++ b/drivers/leds/leds-lp3944.c
@@ -359,8 +359,7 @@ static int lp3944_configure(struct i2c_client *client,
return err;
}
-static int lp3944_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lp3944_probe(struct i2c_client *client)
{
struct lp3944_platform_data *lp3944_pdata =
dev_get_platdata(&client->dev);
@@ -428,7 +427,7 @@ static struct i2c_driver lp3944_driver = {
.driver = {
.name = "lp3944",
},
- .probe = lp3944_probe,
+ .probe_new = lp3944_probe,
.remove = lp3944_remove,
.id_table = lp3944_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 278/606] leds: lp3952: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (9 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 277/606] leds: lp3944: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 279/606] leds: lp5521: " Uwe Kleine-König
` (17 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lp3952.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lp3952.c b/drivers/leds/leds-lp3952.c
index bf0ad1b5ce24..24b2e0f9080d 100644
--- a/drivers/leds/leds-lp3952.c
+++ b/drivers/leds/leds-lp3952.c
@@ -207,8 +207,7 @@ static const struct regmap_config lp3952_regmap = {
.cache_type = REGCACHE_RBTREE,
};
-static int lp3952_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lp3952_probe(struct i2c_client *client)
{
int status;
struct lp3952_led_array *priv;
@@ -274,7 +273,7 @@ static struct i2c_driver lp3952_i2c_driver = {
.driver = {
.name = LP3952_NAME,
},
- .probe = lp3952_probe,
+ .probe_new = lp3952_probe,
.remove = lp3952_remove,
.id_table = lp3952_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 279/606] leds: lp5521: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (10 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 278/606] leds: lp3952: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 280/606] leds: lp5523: " Uwe Kleine-König
` (16 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lp5521.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 7ff20c260504..6faf7b10a593 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -516,9 +516,9 @@ static struct lp55xx_device_config lp5521_cfg = {
.dev_attr_group = &lp5521_group,
};
-static int lp5521_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lp5521_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
int ret;
struct lp55xx_chip *chip;
struct lp55xx_led *led;
@@ -608,7 +608,7 @@ static struct i2c_driver lp5521_driver = {
.name = "lp5521",
.of_match_table = of_match_ptr(of_lp5521_leds_match),
},
- .probe = lp5521_probe,
+ .probe_new = lp5521_probe,
.remove = lp5521_remove,
.id_table = lp5521_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 280/606] leds: lp5523: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (11 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 279/606] leds: lp5521: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 281/606] leds: lp5562: " Uwe Kleine-König
` (15 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lp5523.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 369d40b0b65b..5dc17bb59575 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -884,9 +884,9 @@ static struct lp55xx_device_config lp5523_cfg = {
.dev_attr_group = &lp5523_group,
};
-static int lp5523_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lp5523_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
int ret;
struct lp55xx_chip *chip;
struct lp55xx_led *led;
@@ -980,7 +980,7 @@ static struct i2c_driver lp5523_driver = {
.name = "lp5523x",
.of_match_table = of_match_ptr(of_lp5523_leds_match),
},
- .probe = lp5523_probe,
+ .probe_new = lp5523_probe,
.remove = lp5523_remove,
.id_table = lp5523_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 281/606] leds: lp5562: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (12 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 280/606] leds: lp5523: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 282/606] leds: lp8501: " Uwe Kleine-König
` (14 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lp5562.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
index 0e490085ff35..b5d877faf6d7 100644
--- a/drivers/leds/leds-lp5562.c
+++ b/drivers/leds/leds-lp5562.c
@@ -511,8 +511,7 @@ static struct lp55xx_device_config lp5562_cfg = {
.dev_attr_group = &lp5562_group,
};
-static int lp5562_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lp5562_probe(struct i2c_client *client)
{
int ret;
struct lp55xx_chip *chip;
@@ -604,7 +603,7 @@ static struct i2c_driver lp5562_driver = {
.name = "lp5562",
.of_match_table = of_match_ptr(of_lp5562_leds_match),
},
- .probe = lp5562_probe,
+ .probe_new = lp5562_probe,
.remove = lp5562_remove,
.id_table = lp5562_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 282/606] leds: lp8501: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (13 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 281/606] leds: lp5562: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 283/606] leds: lp8860: " Uwe Kleine-König
` (13 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lp8501.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lp8501.c b/drivers/leds/leds-lp8501.c
index ae11a02c0ab2..165d6423a928 100644
--- a/drivers/leds/leds-lp8501.c
+++ b/drivers/leds/leds-lp8501.c
@@ -299,9 +299,9 @@ static struct lp55xx_device_config lp8501_cfg = {
.run_engine = lp8501_run_engine,
};
-static int lp8501_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lp8501_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
int ret;
struct lp55xx_chip *chip;
struct lp55xx_led *led;
@@ -392,7 +392,7 @@ static struct i2c_driver lp8501_driver = {
.name = "lp8501",
.of_match_table = of_match_ptr(of_lp8501_leds_match),
},
- .probe = lp8501_probe,
+ .probe_new = lp8501_probe,
.remove = lp8501_remove,
.id_table = lp8501_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 283/606] leds: lp8860: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (14 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 282/606] leds: lp8501: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 284/606] leds: pca9532: " Uwe Kleine-König
` (12 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lp8860.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
index e2b36d3187eb..b66ed5ac1aa5 100644
--- a/drivers/leds/leds-lp8860.c
+++ b/drivers/leds/leds-lp8860.c
@@ -375,8 +375,7 @@ static const struct regmap_config lp8860_eeprom_regmap_config = {
.cache_type = REGCACHE_NONE,
};
-static int lp8860_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int lp8860_probe(struct i2c_client *client)
{
int ret;
struct lp8860_led *led;
@@ -480,7 +479,7 @@ static struct i2c_driver lp8860_driver = {
.name = "lp8860",
.of_match_table = of_lp8860_leds_match,
},
- .probe = lp8860_probe,
+ .probe_new = lp8860_probe,
.remove = lp8860_remove,
.id_table = lp8860_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 284/606] leds: pca9532: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (15 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 283/606] leds: lp8860: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 285/606] leds: pca963x: " Uwe Kleine-König
` (11 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Riku Voipio, Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-pca9532.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index df83d97cb479..15b1acfa442e 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -50,8 +50,7 @@ struct pca9532_data {
u8 psc[2];
};
-static int pca9532_probe(struct i2c_client *client,
- const struct i2c_device_id *id);
+static int pca9532_probe(struct i2c_client *client);
static void pca9532_remove(struct i2c_client *client);
enum {
@@ -103,7 +102,7 @@ static struct i2c_driver pca9532_driver = {
.name = "leds-pca953x",
.of_match_table = of_match_ptr(of_pca9532_leds_match),
},
- .probe = pca9532_probe,
+ .probe_new = pca9532_probe,
.remove = pca9532_remove,
.id_table = pca9532_id,
};
@@ -504,9 +503,9 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np)
return pdata;
}
-static int pca9532_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int pca9532_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
int devid;
struct pca9532_data *data = i2c_get_clientdata(client);
struct pca9532_platform_data *pca9532_pdata =
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 285/606] leds: pca963x: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (16 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 284/606] leds: pca9532: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 286/606] leds: tca6507: " Uwe Kleine-König
` (10 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
.probe_new() doesn't get the i2c_device_id * parameter, so determine
that explicitly in the probe function.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-pca963x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c
index a7e052c1db53..9cd476db601f 100644
--- a/drivers/leds/leds-pca963x.c
+++ b/drivers/leds/leds-pca963x.c
@@ -389,9 +389,9 @@ static const struct of_device_id of_pca963x_match[] = {
};
MODULE_DEVICE_TABLE(of, of_pca963x_match);
-static int pca963x_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int pca963x_probe(struct i2c_client *client)
{
+ const struct i2c_device_id *id = i2c_client_get_device_id(client);
struct device *dev = &client->dev;
struct pca963x_chipdef *chipdef;
struct pca963x *chip;
@@ -431,7 +431,7 @@ static struct i2c_driver pca963x_driver = {
.name = "leds-pca963x",
.of_match_table = of_pca963x_match,
},
- .probe = pca963x_probe,
+ .probe_new = pca963x_probe,
.id_table = pca963x_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 286/606] leds: tca6507: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (17 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 285/606] leds: pca963x: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 287/606] leds: tlc591xx: " Uwe Kleine-König
` (9 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-tca6507.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index 161bef65c6b7..46e76b894651 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -728,8 +728,7 @@ static const struct of_device_id __maybe_unused of_tca6507_leds_match[] = {
};
MODULE_DEVICE_TABLE(of, of_tca6507_leds_match);
-static int tca6507_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int tca6507_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct i2c_adapter *adapter;
@@ -809,7 +808,7 @@ static struct i2c_driver tca6507_driver = {
.name = "leds-tca6507",
.of_match_table = of_match_ptr(of_tca6507_leds_match),
},
- .probe = tca6507_probe,
+ .probe_new = tca6507_probe,
.remove = tca6507_remove,
.id_table = tca6507_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 287/606] leds: tlc591xx: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (18 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 286/606] leds: tca6507: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-18 22:40 ` [PATCH 288/606] leds: turris-omnia: " Uwe Kleine-König
` (8 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-tlc591xx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
index cb7bd1353f9f..ec25e0c16bea 100644
--- a/drivers/leds/leds-tlc591xx.c
+++ b/drivers/leds/leds-tlc591xx.c
@@ -145,8 +145,7 @@ static const struct of_device_id of_tlc591xx_leds_match[] = {
MODULE_DEVICE_TABLE(of, of_tlc591xx_leds_match);
static int
-tlc591xx_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+tlc591xx_probe(struct i2c_client *client)
{
struct device_node *np, *child;
struct device *dev = &client->dev;
@@ -231,7 +230,7 @@ static struct i2c_driver tlc591xx_driver = {
.name = "tlc591xx",
.of_match_table = of_match_ptr(of_tlc591xx_leds_match),
},
- .probe = tlc591xx_probe,
+ .probe_new = tlc591xx_probe,
.id_table = tlc591xx_id,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (19 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 287/606] leds: tlc591xx: " Uwe Kleine-König
@ 2022-11-18 22:40 ` Uwe Kleine-König
2022-11-20 12:49 ` Marek Behún
2022-12-02 11:12 ` Uwe Kleine-König
2022-11-19 6:50 ` [PATCH 000/606] i2c: Complete conversion to i2c_probe_new patchwork-bot+chrome-platform
` (7 subsequent siblings)
28 siblings, 2 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-18 22:40 UTC (permalink / raw)
To: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Marek Behún, Pavel Machek
Cc: linux-i2c, kernel, Uwe Kleine-König, linux-leds,
linux-kernel
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
The probe function doesn't make use of the i2c_device_id * parameter so it
can be trivially converted.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-turris-omnia.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c
index c7c9851c894a..013f551b32b2 100644
--- a/drivers/leds/leds-turris-omnia.c
+++ b/drivers/leds/leds-turris-omnia.c
@@ -201,8 +201,7 @@ static struct attribute *omnia_led_controller_attrs[] = {
};
ATTRIBUTE_GROUPS(omnia_led_controller);
-static int omnia_leds_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int omnia_leds_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
struct device_node *np = dev_of_node(dev), *child;
@@ -272,7 +271,7 @@ static const struct i2c_device_id omnia_id[] = {
MODULE_DEVICE_TABLE(i2c, omnia_id);
static struct i2c_driver omnia_leds_driver = {
- .probe = omnia_leds_probe,
+ .probe_new = omnia_leds_probe,
.remove = omnia_leds_remove,
.id_table = omnia_id,
.driver = {
--
2.38.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-11-18 22:40 ` [PATCH 288/606] leds: turris-omnia: " Uwe Kleine-König
@ 2022-11-20 12:49 ` Marek Behún
2022-12-02 11:12 ` Uwe Kleine-König
1 sibling, 0 replies; 39+ messages in thread
From: Marek Behún @ 2022-11-20 12:49 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Pavel Machek, linux-i2c, kernel, Uwe Kleine-König,
linux-leds, linux-kernel
On Fri, 18 Nov 2022 23:40:22 +0100
Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Marek Behún <kabel@kernel.org>
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-11-18 22:40 ` [PATCH 288/606] leds: turris-omnia: " Uwe Kleine-König
2022-11-20 12:49 ` Marek Behún
@ 2022-12-02 11:12 ` Uwe Kleine-König
2022-12-07 20:30 ` Pavel Machek
2022-12-22 21:42 ` Uwe Kleine-König
1 sibling, 2 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-12-02 11:12 UTC (permalink / raw)
To: Pavel Machek
Cc: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Marek Behún, linux-kernel, linux-leds, linux-i2c, kernel
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
Hello Pavel,
On Fri, Nov 18, 2022 at 11:40:22PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
I didn't get any feedback from your side about this patch set.
In case the problem is "only" to get the led patches out of this
series, I recommend:
b4 am -l -s -P268-288 20221118224540.619276-1-uwe@kleine-koenig.org
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-12-02 11:12 ` Uwe Kleine-König
@ 2022-12-07 20:30 ` Pavel Machek
2022-12-08 7:51 ` Uwe Kleine-König
2022-12-22 21:42 ` Uwe Kleine-König
1 sibling, 1 reply; 39+ messages in thread
From: Pavel Machek @ 2022-12-07 20:30 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang,
Marek Behún, linux-kernel, linux-leds, linux-i2c, kernel
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
Hi!
> On Fri, Nov 18, 2022 at 11:40:22PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > The probe function doesn't make use of the i2c_device_id * parameter so it
> > can be trivially converted.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> I didn't get any feedback from your side about this patch set.
>
> In case the problem is "only" to get the led patches out of this
> series, I recommend:
>
> b4 am -l -s -P268-288 20221118224540.619276-1-uwe@kleine-koenig.org
Yeah, well, I guess:
# A part of the patches depend on commit 662233731d66 ("i2c: core:
# Introduce i2c_client_get_device_id helper function"), there is a branch that
# you can pull into your tree to get it:
this is a bit of a problem because Linus will be unhappy if I pull
into my for-next branch.
So... I can get them in the next cycle, or I can ack them and get them
via some special arangement with linux, or...
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-12-07 20:30 ` Pavel Machek
@ 2022-12-08 7:51 ` Uwe Kleine-König
0 siblings, 0 replies; 39+ messages in thread
From: Uwe Kleine-König @ 2022-12-08 7:51 UTC (permalink / raw)
To: Pavel Machek
Cc: Marek Behún, linux-kernel, Wolfram Sang, Angel Iglesias,
linux-i2c, kernel, Grant Likely, Lee Jones, linux-leds
[-- Attachment #1: Type: text/plain, Size: 4358 bytes --]
Hello Pavel,
On Wed, Dec 07, 2022 at 09:30:27PM +0100, Pavel Machek wrote:
> > On Fri, Nov 18, 2022 at 11:40:22PM +0100, Uwe Kleine-König wrote:
> > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >
> > > The probe function doesn't make use of the i2c_device_id * parameter so it
> > > can be trivially converted.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > I didn't get any feedback from your side about this patch set.
> >
> > In case the problem is "only" to get the led patches out of this
> > series, I recommend:
> >
> > b4 am -l -s -P268-288 20221118224540.619276-1-uwe@kleine-koenig.org
>
> Yeah, well, I guess:
>
> # A part of the patches depend on commit 662233731d66 ("i2c: core:
> # Introduce i2c_client_get_device_id helper function"), there is a branch that
> # you can pull into your tree to get it:
>
> this is a bit of a problem because Linus will be unhappy if I pull
> into my for-next branch.
I wonder if it's you or me who has a wrong expectation about Linus here.
IIUC he is unhappy if you pull some random tree (e.g. his own) for no
better reason than to update, but an immutable tag/branch to get a
dependency right should be fine. That's the whole idea about immutable
tags and branches, isn't it?
Looking at today's next, there are several merges of this immutable branch:
- 3d94887aca09 ("Merge branch 'i2c/client_device_id_helper-immutable' of https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into next")
by Dmitry Torokhov for branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git
- 719c547c6551 ("Merge branch 'i2c/client_device_id_helper-immutable' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux")
by Herbert Xu for branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
- 963c7fe6cdbf ("Merge branch i2c/client_device_id_helper-immutable of wsa/linux into next")
by Michael Ellerman for branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
- 06fa87fc9311 ("Merge branch 'i2c/client_device_id_helper-immutable' of https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into gpio/for-next")
by Bartosz Golaszewski for branch 'gpio/for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git
- 2f88b7050d67 ("Merge 'i2c/client_device_id_helper-immutable'")
by Sebastian Reichel for branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git
- b15654dd11e6 ("Merge remote-tracking branch 'i2c/i2c/client_device_id_helper-immutable' into togreg")
by Jonathan Cameron for branch 'char-misc-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
- 149f52664bb3 ("Merge branch 'i2c/client_device_id_helper-immutable' of https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into regulator-6.2")
by Mark Brown for branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
- e0c7800a5530 ("Merge branch 'i2c/client_device_id_helper-immutable' into i2c/for-mergewindow")
by Wolfram Sang for branch 'i2c/for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
- 4cb55a9a1ab7 ("Merge branch 'i2c/client_device_id_helper-immutable' of https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into HEAD")
by Mark Brown for branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
- c43c0e589e69 ("Merge branch 'i2c/client_device_id_helper-immutable' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux")
by Jakub Kicinski for branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
- 41948bd9cf01 ("Merge branch 'i2c/client_device_id_helper-immutable' of https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux into spi-6.2")
by Mark Brown for branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
mfd and backlight just started stacking on top of 662233731d66cf41e7494e532e702849c8ce18f3.
So you should be in good company at least if Linus gets angry :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-12-02 11:12 ` Uwe Kleine-König
2022-12-07 20:30 ` Pavel Machek
@ 2022-12-22 21:42 ` Uwe Kleine-König
2022-12-23 11:25 ` Lee Jones
1 sibling, 1 reply; 39+ messages in thread
From: Uwe Kleine-König @ 2022-12-22 21:42 UTC (permalink / raw)
To: Pavel Machek
Cc: Marek Behún, linux-kernel, Wolfram Sang, Angel Iglesias,
linux-i2c, kernel, Grant Likely, Lee Jones, linux-leds
[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]
Hello Pavel,
On Fri, Dec 02, 2022 at 12:12:21PM +0100, Uwe Kleine-König wrote:
> On Fri, Nov 18, 2022 at 11:40:22PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > The probe function doesn't make use of the i2c_device_id * parameter so it
> > can be trivially converted.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> I didn't get any feedback from your side about this patch set.
>
> In case the problem is "only" to get the led patches out of this
> series, I recommend:
>
> b4 am -l -s -P268-288 20221118224540.619276-1-uwe@kleine-koenig.org
Still no feedback. A big part of the series was applied to the various
trees, but the led patches are not. :-\ Would be great if you queued
them for next after the merge window closed. (Or if you have concerns,
speak up.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-12-22 21:42 ` Uwe Kleine-König
@ 2022-12-23 11:25 ` Lee Jones
2023-01-05 14:47 ` Lee Jones
0 siblings, 1 reply; 39+ messages in thread
From: Lee Jones @ 2022-12-23 11:25 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Pavel Machek, Marek Behún, linux-kernel, Wolfram Sang,
Angel Iglesias, linux-i2c, kernel, Grant Likely, Lee Jones,
linux-leds
On Thu, 22 Dec 2022, Uwe Kleine-König wrote:
> Hello Pavel,
>
> On Fri, Dec 02, 2022 at 12:12:21PM +0100, Uwe Kleine-König wrote:
> > On Fri, Nov 18, 2022 at 11:40:22PM +0100, Uwe Kleine-König wrote:
> > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >
> > > The probe function doesn't make use of the i2c_device_id * parameter so it
> > > can be trivially converted.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > I didn't get any feedback from your side about this patch set.
> >
> > In case the problem is "only" to get the led patches out of this
> > series, I recommend:
> >
> > b4 am -l -s -P268-288 20221118224540.619276-1-uwe@kleine-koenig.org
>
> Still no feedback. A big part of the series was applied to the various
> trees, but the led patches are not. :-\ Would be great if you queued
> them for next after the merge window closed. (Or if you have concerns,
> speak up.)
If it's okay with Pavel, I can pick these up after the holidays.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 288/606] leds: turris-omnia: Convert to i2c's .probe_new()
2022-12-23 11:25 ` Lee Jones
@ 2023-01-05 14:47 ` Lee Jones
0 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2023-01-05 14:47 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Pavel Machek, Marek Behún, linux-kernel, Wolfram Sang,
Angel Iglesias, linux-i2c, kernel, Grant Likely, Lee Jones,
linux-leds
On Fri, 23 Dec 2022, Lee Jones wrote:
> On Thu, 22 Dec 2022, Uwe Kleine-König wrote:
>
> > Hello Pavel,
> >
> > On Fri, Dec 02, 2022 at 12:12:21PM +0100, Uwe Kleine-König wrote:
> > > On Fri, Nov 18, 2022 at 11:40:22PM +0100, Uwe Kleine-König wrote:
> > > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > >
> > > > The probe function doesn't make use of the i2c_device_id * parameter so it
> > > > can be trivially converted.
> > > >
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >
> > > I didn't get any feedback from your side about this patch set.
> > >
> > > In case the problem is "only" to get the led patches out of this
> > > series, I recommend:
> > >
> > > b4 am -l -s -P268-288 20221118224540.619276-1-uwe@kleine-koenig.org
> >
> > Still no feedback. A big part of the series was applied to the various
> > trees, but the led patches are not. :-\ Would be great if you queued
> > them for next after the merge window closed. (Or if you have concerns,
> > speak up.)
>
> If it's okay with Pavel, I can pick these up after the holidays.
Applied now, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (20 preceding siblings ...)
2022-11-18 22:40 ` [PATCH 288/606] leds: turris-omnia: " Uwe Kleine-König
@ 2022-11-19 6:50 ` patchwork-bot+chrome-platform
2022-11-19 6:50 ` patchwork-bot+chrome-platform
` (6 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: patchwork-bot+chrome-platform @ 2022-11-19 6:50 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cuwe=40kleine-koenig=2Eorg=3E?=
Cc: ang.iglesiasg, lee.jones, grant.likely, wsa, linux-i2c, kernel,
linux-integrity, linux-kernel, linux-arm-kernel, linux-crypto,
linux-gpio, bcm-kernel-feedback-list, linux-rpi-kernel, linux-iio,
linux-input, platform-driver-x86, linux-stm32, linux-leds,
linuxppc-dev, linux-media, patches, linux-actions,
linux-renesas-soc, linux-amlogic, alsa-devel, linux-omap,
linux-samsung-soc, linux-mtd, netdev, devicetree, chrome-platform,
linux-pm, kernel, linux-pwm, linux-rtc, linux-spi, linux-staging,
linux-serial, linux-usb, linux-fbdev, linux-watchdog,
openipmi-developer
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Fri, 18 Nov 2022 23:35:34 +0100 you wrote:
> Hello,
>
> since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type") from 2016 there is a "temporary" alternative probe
> callback for i2c drivers.
>
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
> A part of the patches depend on commit 662233731d66 ("i2c: core:
> Introduce i2c_client_get_device_id helper function"), there is a branch that
> you can pull into your tree to get it:
>
> [...]
Here is the summary with links:
- [512/606] platform/chrome: cros_ec: Convert to i2c's .probe_new()
https://git.kernel.org/chrome-platform/c/f9e510dc92df
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (21 preceding siblings ...)
2022-11-19 6:50 ` [PATCH 000/606] i2c: Complete conversion to i2c_probe_new patchwork-bot+chrome-platform
@ 2022-11-19 6:50 ` patchwork-bot+chrome-platform
2022-11-19 11:10 ` Wolfram Sang
` (5 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: patchwork-bot+chrome-platform @ 2022-11-19 6:50 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cuwe=40kleine-koenig=2Eorg=3E?=
Cc: ang.iglesiasg, lee.jones, grant.likely, wsa, linux-i2c, kernel,
linux-integrity, linux-kernel, linux-arm-kernel, linux-crypto,
linux-gpio, bcm-kernel-feedback-list, linux-rpi-kernel, linux-iio,
linux-input, platform-driver-x86, linux-stm32, linux-leds,
linuxppc-dev, linux-media, patches, linux-actions,
linux-renesas-soc, linux-amlogic, alsa-devel, linux-omap,
linux-samsung-soc, linux-mtd, netdev, devicetree, chrome-platform,
linux-pm, kernel, linux-pwm, linux-rtc, linux-spi, linux-staging,
linux-serial, linux-usb, linux-fbdev, linux-watchdog,
openipmi-developer
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:
On Fri, 18 Nov 2022 23:35:34 +0100 you wrote:
> Hello,
>
> since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type") from 2016 there is a "temporary" alternative probe
> callback for i2c drivers.
>
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
> A part of the patches depend on commit 662233731d66 ("i2c: core:
> Introduce i2c_client_get_device_id helper function"), there is a branch that
> you can pull into your tree to get it:
>
> [...]
Here is the summary with links:
- [512/606] platform/chrome: cros_ec: Convert to i2c's .probe_new()
https://git.kernel.org/chrome-platform/c/f9e510dc92df
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (22 preceding siblings ...)
2022-11-19 6:50 ` patchwork-bot+chrome-platform
@ 2022-11-19 11:10 ` Wolfram Sang
2022-11-20 19:43 ` Sebastian Reichel
` (4 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Wolfram Sang @ 2022-11-19 11:10 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Angel Iglesias, Lee Jones, Grant Likely, linux-i2c, kernel,
linux-integrity, linux-kernel, linux-arm-kernel, linux-crypto,
linux-gpio, Broadcom internal kernel review list,
linux-rpi-kernel, linux-iio, linux-input, platform-driver-x86,
linux-stm32, linux-leds, linuxppc-dev, linux-media, patches,
linux-actions, linux-renesas-soc, linux-amlogic, alsa-devel,
linux-omap, linux-samsung-soc, linux-mtd, netdev, devicetree,
chrome-platform, linux-pm, Purism Kernel Team, linux-pwm,
linux-rtc, linux-spi, linux-staging, linux-serial, linux-usb,
linux-fbdev, linux-watchdog, openipmi-developer
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
Hi Uwe,
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
Thanks for this work, really, but oh my poor inbox...
> I don't think it's feasable to apply this series in one go, so I ask the
> maintainers of the changed files to apply via their tree.
This seems reasonable. It would have made sense to send "patch series
per subsystem" then. So people only see the subset they are interested
in. I know filename-to-subsys mapping is hardly ever perfect. But in my
experience, even imperfect, it is more convenient than such a huge patch
series.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (23 preceding siblings ...)
2022-11-19 11:10 ` Wolfram Sang
@ 2022-11-20 19:43 ` Sebastian Reichel
2022-11-21 9:53 ` Lee Jones
` (3 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Sebastian Reichel @ 2022-11-20 19:43 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang, linux-i2c,
kernel, linux-integrity, linux-kernel, linux-arm-kernel,
linux-crypto, linux-gpio, Broadcom internal kernel review list,
linux-rpi-kernel, linux-iio, linux-input, platform-driver-x86,
linux-stm32, linux-leds, linuxppc-dev, linux-media, patches,
linux-actions, linux-renesas-soc, linux-amlogic, alsa-devel,
linux-omap, linux-samsung-soc, linux-mtd, netdev, devicetree,
chrome-platform, linux-pm, Purism Kernel Team, linux-pwm,
linux-rtc, linux-spi, linux-staging, linux-serial, linux-usb,
linux-fbdev, linux-watchdog, openipmi-developer
[-- Attachment #1: Type: text/plain, Size: 2954 bytes --]
Hi,
On Fri, Nov 18, 2022 at 11:35:34PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type") from 2016 there is a "temporary" alternative probe
> callback for i2c drivers.
>
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
> A part of the patches depend on commit 662233731d66 ("i2c: core:
> Introduce i2c_client_get_device_id helper function"), there is a branch that
> you can pull into your tree to get it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/client_device_id_helper-immutable
>
> I don't think it's feasable to apply this series in one go, so I ask the
> maintainers of the changed files to apply via their tree. I guess it
> will take a few kernel release iterations until all patch are in, but I
> think a single tree creates too much conflicts.
>
> The last patch changes i2c_driver::probe, all non-converted drivers will
> fail to compile then. So I hope the build bots will tell me about any
> driver I missed to convert. This patch is obviously not for application
> now.
>
> I dropped most individuals from the recipents of this mail to not
> challenge the mail servers and mailing list filters too much. Sorry if
> you had extra efforts to find this mail.
>
> Best regards
> Uwe
...
> power: supply: adp5061: Convert to i2c's .probe_new()
> power: supply: bq2415x: Convert to i2c's .probe_new()
> power: supply: bq24190: Convert to i2c's .probe_new()
> power: supply: bq24257: Convert to i2c's .probe_new()
> power: supply: bq24735: Convert to i2c's .probe_new()
> power: supply: bq2515x: Convert to i2c's .probe_new()
> power: supply: bq256xx: Convert to i2c's .probe_new()
> power: supply: bq25890: Convert to i2c's .probe_new()
> power: supply: bq25980: Convert to i2c's .probe_new()
> power: supply: bq27xxx: Convert to i2c's .probe_new()
> power: supply: ds2782: Convert to i2c's .probe_new()
> power: supply: lp8727: Convert to i2c's .probe_new()
> power: supply: ltc2941: Convert to i2c's .probe_new()
> power: supply: ltc4162-l: Convert to i2c's .probe_new()
> power: supply: max14656: Convert to i2c's .probe_new()
> power: supply: max17040: Convert to i2c's .probe_new()
> power: supply: max17042_battery: Convert to i2c's .probe_new()
> power: supply: rt5033_battery: Convert to i2c's .probe_new()
> power: supply: rt9455: Convert to i2c's .probe_new()
> power: supply: sbs: Convert to i2c's .probe_new()
> power: supply: sbs-manager: Convert to i2c's .probe_new()
> power: supply: smb347: Convert to i2c's .probe_new()
> power: supply: ucs1002: Convert to i2c's .probe_new()
> power: supply: z2_battery: Convert to i2c's .probe_new()
> [...]
Thanks, I queued patches 513-536 to the power-supply subsystem.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (24 preceding siblings ...)
2022-11-20 19:43 ` Sebastian Reichel
@ 2022-11-21 9:53 ` Lee Jones
2022-11-22 18:58 ` Jonathan Cameron
` (2 subsequent siblings)
28 siblings, 0 replies; 39+ messages in thread
From: Lee Jones @ 2022-11-21 9:53 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang, linux-i2c,
kernel, linux-integrity, linux-kernel, linux-arm-kernel,
linux-crypto, linux-gpio, Broadcom internal kernel review list,
linux-rpi-kernel, linux-iio, linux-input, platform-driver-x86,
linux-stm32, linux-leds, linuxppc-dev, linux-media, patches,
linux-actions, linux-renesas-soc, linux-amlogic, alsa-devel,
linux-omap, linux-samsung-soc, linux-mtd, netdev, devicetree,
chrome-platform, linux-pm, Purism Kernel Team, linux-pwm,
linux-rtc, linux-spi, linux-staging, linux-serial, linux-usb,
linux-fbdev, linux-watchdog, openipmi-developer
On Fri, 18 Nov 2022, Uwe Kleine-König wrote:
> Hello,
>
> since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type") from 2016 there is a "temporary" alternative probe
> callback for i2c drivers.
Oh yeah, this! Thanks for picking this up Uwe, I guess I've been
distracted for the past 6 years or so. :)
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
> A part of the patches depend on commit 662233731d66 ("i2c: core:
> Introduce i2c_client_get_device_id helper function"), there is a branch that
> you can pull into your tree to get it:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/client_device_id_helper-immutable
>
> I don't think it's feasable to apply this series in one go, so I ask the
> maintainers of the changed files to apply via their tree. I guess it
> will take a few kernel release iterations until all patch are in, but I
> think a single tree creates too much conflicts.
>
> The last patch changes i2c_driver::probe, all non-converted drivers will
> fail to compile then. So I hope the build bots will tell me about any
> driver I missed to convert. This patch is obviously not for application
> now.
>
> I dropped most individuals from the recipents of this mail to not
> challenge the mail servers and mailing list filters too much. Sorry if
> you had extra efforts to find this mail.
[...]
> drivers/mfd/88pm800.c | 5 ++---
> drivers/mfd/88pm805.c | 5 ++---
> drivers/mfd/aat2870-core.c | 5 ++---
> drivers/mfd/act8945a.c | 5 ++---
> drivers/mfd/adp5520.c | 6 +++---
> drivers/mfd/arizona-i2c.c | 6 +++---
> drivers/mfd/as3711.c | 5 ++---
> drivers/mfd/as3722.c | 5 ++---
> drivers/mfd/atc260x-i2c.c | 5 ++---
> drivers/mfd/axp20x-i2c.c | 5 ++---
> drivers/mfd/bcm590xx.c | 5 ++---
> drivers/mfd/bd9571mwv.c | 5 ++---
> drivers/mfd/da903x.c | 6 +++---
> drivers/mfd/da9052-i2c.c | 6 +++---
> drivers/mfd/da9055-i2c.c | 5 ++---
> drivers/mfd/da9062-core.c | 6 +++---
> drivers/mfd/da9063-i2c.c | 6 +++---
> drivers/mfd/da9150-core.c | 5 ++---
> drivers/mfd/khadas-mcu.c | 5 ++---
> drivers/mfd/lm3533-core.c | 5 ++---
> drivers/mfd/lp3943.c | 4 ++--
> drivers/mfd/lp873x.c | 5 ++---
> drivers/mfd/lp87565.c | 5 ++---
> drivers/mfd/lp8788.c | 4 ++--
> drivers/mfd/madera-i2c.c | 6 +++---
> drivers/mfd/max14577.c | 6 +++---
> drivers/mfd/max77620.c | 6 +++---
> drivers/mfd/max77693.c | 6 +++---
> drivers/mfd/max77843.c | 6 +++---
> drivers/mfd/max8907.c | 5 ++---
> drivers/mfd/max8925-i2c.c | 5 ++---
> drivers/mfd/max8997.c | 6 +++---
> drivers/mfd/max8998.c | 6 +++---
> drivers/mfd/mc13xxx-i2c.c | 6 +++---
> drivers/mfd/menelaus.c | 5 ++---
> drivers/mfd/menf21bmc.c | 4 ++--
> drivers/mfd/palmas.c | 5 ++---
> drivers/mfd/pcf50633-core.c | 5 ++---
> drivers/mfd/rc5t583.c | 5 ++---
> drivers/mfd/retu-mfd.c | 4 ++--
> drivers/mfd/rk808.c | 5 ++---
> drivers/mfd/rohm-bd718x7.c | 5 ++---
> drivers/mfd/rsmu_i2c.c | 6 +++---
> drivers/mfd/rt5033.c | 5 ++---
> drivers/mfd/sec-core.c | 5 ++---
> drivers/mfd/si476x-i2c.c | 6 +++---
> drivers/mfd/sky81452.c | 5 ++---
> drivers/mfd/stmfx.c | 5 ++---
> drivers/mfd/stmpe-i2c.c | 5 +++--
> drivers/mfd/stpmic1.c | 5 ++---
> drivers/mfd/stw481x.c | 5 ++---
> drivers/mfd/tc3589x.c | 6 +++---
> drivers/mfd/ti-lmu.c | 5 +++--
> drivers/mfd/tps6105x.c | 5 ++---
> drivers/mfd/tps65010.c | 6 +++---
> drivers/mfd/tps6507x.c | 5 ++---
> drivers/mfd/tps65086.c | 5 ++---
> drivers/mfd/tps65090.c | 5 ++---
> drivers/mfd/tps65218.c | 5 ++---
> drivers/mfd/tps6586x.c | 5 ++---
> drivers/mfd/tps65910.c | 6 +++---
> drivers/mfd/tps65912-i2c.c | 5 ++---
> drivers/mfd/twl-core.c | 5 +++--
> drivers/mfd/twl6040.c | 5 ++---
> drivers/mfd/wl1273-core.c | 5 ++---
> drivers/mfd/wm831x-i2c.c | 6 +++---
> drivers/mfd/wm8350-i2c.c | 5 ++---
> drivers/mfd/wm8400-core.c | 5 ++---
> drivers/mfd/wm8994-core.c | 6 +++---
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee@kernel.org>
> drivers/video/backlight/adp8860_bl.c | 6 +++---
> drivers/video/backlight/adp8870_bl.c | 6 +++---
> drivers/video/backlight/arcxcnn_bl.c | 4 ++--
> drivers/video/backlight/bd6107.c | 5 ++---
> drivers/video/backlight/lm3630a_bl.c | 5 ++---
> drivers/video/backlight/lm3639_bl.c | 5 ++---
> drivers/video/backlight/lp855x_bl.c | 5 +++--
> drivers/video/backlight/lv5207lp.c | 5 ++---
> drivers/video/backlight/tosa_bl.c | 5 ++---
> drivers/video/fbdev/matrox/matroxfb_maven.c | 5 ++---
For my own reference (apply this as-is to your sign-off block):
Acked-for-Backlight-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (25 preceding siblings ...)
2022-11-21 9:53 ` Lee Jones
@ 2022-11-22 18:58 ` Jonathan Cameron
2022-11-22 20:16 ` Uwe Kleine-König
2022-12-09 12:00 ` (subset) " Robert Foss
2022-12-12 16:36 ` Robert Foss
28 siblings, 1 reply; 39+ messages in thread
From: Jonathan Cameron @ 2022-11-22 18:58 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Angel Iglesias, Lee Jones, Grant Likely, Wolfram Sang, linux-i2c,
kernel, linux-integrity, linux-kernel, linux-arm-kernel,
linux-crypto, linux-gpio, Broadcom internal kernel review list,
linux-rpi-kernel, linux-iio, linux-input, platform-driver-x86,
linux-stm32, linux-leds, linuxppc-dev, linux-media, patches,
linux-actions, linux-renesas-soc, linux-amlogic, alsa-devel,
linux-omap, linux-samsung-soc, linux-mtd, netdev, devicetree,
chrome-platform, linux-pm, Purism Kernel Team, linux-pwm,
linux-rtc, linux-spi, linux-staging, linux-serial, linux-usb,
linux-fbdev, linux-watchdog, openipmi-developer, gregkh
Queued all of the below:
with one tweaked as per your suggestion and the highlighted one dropped on basis
I was already carrying the equivalent - as you pointed out.
I was already carrying the required dependency.
Includes the IIO ones in staging.
Thanks,
Jonathan
p.s. I perhaps foolishly did this in a highly manual way so as to
also pick up Andy's RB. So might have dropped one...
Definitely would have been better as one patch per subsystem with
a cover letter suitable for replies like Andy's to be picked up
by b4.
> iio: accel: adxl372_i2c: Convert to i2c's .probe_new()
> iio: accel: bma180: Convert to i2c's .probe_new()
> iio: accel: bma400: Convert to i2c's .probe_new()
> iio: accel: bmc150: Convert to i2c's .probe_new()
> iio: accel: da280: Convert to i2c's .probe_new()
> iio: accel: kxcjk-1013: Convert to i2c's .probe_new()
> iio: accel: mma7455_i2c: Convert to i2c's .probe_new()
> iio: accel: mma8452: Convert to i2c's .probe_new()
> iio: accel: mma9551: Convert to i2c's .probe_new()
> iio: accel: mma9553: Convert to i2c's .probe_new()
> iio: adc: ad7091r5: Convert to i2c's .probe_new()
> iio: adc: ad7291: Convert to i2c's .probe_new()
> iio: adc: ad799x: Convert to i2c's .probe_new()
> iio: adc: ina2xx-adc: Convert to i2c's .probe_new()
> iio: adc: ltc2471: Convert to i2c's .probe_new()
> iio: adc: ltc2485: Convert to i2c's .probe_new()
> iio: adc: ltc2497: Convert to i2c's .probe_new()
> iio: adc: max1363: Convert to i2c's .probe_new()
> iio: adc: max9611: Convert to i2c's .probe_new()
> iio: adc: mcp3422: Convert to i2c's .probe_new()
> iio: adc: ti-adc081c: Convert to i2c's .probe_new()
> iio: adc: ti-ads1015: Convert to i2c's .probe_new()
> iio: cdc: ad7150: Convert to i2c's .probe_new()
> iio: cdc: ad7746: Convert to i2c's .probe_new()
> iio: chemical: ams-iaq-core: Convert to i2c's .probe_new()
> iio: chemical: atlas-ezo-sensor: Convert to i2c's .probe_new()
> iio: chemical: atlas-sensor: Convert to i2c's .probe_new()
> iio: chemical: bme680_i2c: Convert to i2c's .probe_new()
> iio: chemical: ccs811: Convert to i2c's .probe_new()
> iio: chemical: scd4x: Convert to i2c's .probe_new()
> iio: chemical: sgp30: Convert to i2c's .probe_new()
> iio: chemical: sgp40: Convert to i2c's .probe_new()
> iio: chemical: vz89x: Convert to i2c's .probe_new()
> iio: dac: ad5064: Convert to i2c's .probe_new()
> iio: dac: ad5380: Convert to i2c's .probe_new()
> iio: dac: ad5446: Convert to i2c's .probe_new()
> iio: dac: ad5593r: Convert to i2c's .probe_new()
> iio: dac: ad5696-i2c: Convert to i2c's .probe_new()
> iio: dac: ds4424: Convert to i2c's .probe_new()
> iio: dac: m62332: Convert to i2c's .probe_new()
> iio: dac: max517: Convert to i2c's .probe_new()
> iio: dac: max5821: Convert to i2c's .probe_new()
> iio: dac: mcp4725: Convert to i2c's .probe_new()
> iio: dac: ti-dac5571: Convert to i2c's .probe_new()
> iio: gyro: bmg160_i2c: Convert to i2c's .probe_new()
> iio: gyro: itg3200_core: Convert to i2c's .probe_new()
> iio: gyro: mpu3050-i2c: Convert to i2c's .probe_new()
> iio: gyro: st_gyro_i2c: Convert to i2c's .probe_new()
> iio: health: afe4404: Convert to i2c's .probe_new()
> iio: health: max30100: Convert to i2c's .probe_new()
> iio: health: max30102: Convert to i2c's .probe_new()
> iio: humidity: am2315: Convert to i2c's .probe_new()
> iio: humidity: hdc100x: Convert to i2c's .probe_new()
> iio: humidity: hdc2010: Convert to i2c's .probe_new()
> iio: humidity: hts221_i2c: Convert to i2c's .probe_new()
> iio: humidity: htu21: Convert to i2c's .probe_new()
> iio: humidity: si7005: Convert to i2c's .probe_new()
> iio: humidity: si7020: Convert to i2c's .probe_new()
> iio: imu: bmi160/bmi160_i2c: Convert to i2c's .probe_new()
> iio: imu: fxos8700_i2c: Convert to i2c's .probe_new()
> iio: imu: inv_mpu6050: Convert to i2c's .probe_new()
> iio: imu: kmx61: Convert to i2c's .probe_new()
> iio: imu: st_lsm6dsx: Convert to i2c's .probe_new()
> iio: light: adjd_s311: Convert to i2c's .probe_new()
> iio: light: adux1020: Convert to i2c's .probe_new()
> iio: light: al3010: Convert to i2c's .probe_new()
> iio: light: al3320a: Convert to i2c's .probe_new()
> iio: light: apds9300: Convert to i2c's .probe_new()
> iio: light: apds9960: Convert to i2c's .probe_new()
> iio: light: bh1750: Convert to i2c's .probe_new()
> iio: light: bh1780: Convert to i2c's .probe_new()
> iio: light: cm3232: Convert to i2c's .probe_new()
> iio: light: cm3323: Convert to i2c's .probe_new()
> iio: light: cm36651: Convert to i2c's .probe_new()
> iio: light: gp2ap002: Convert to i2c's .probe_new()
> iio: light: gp2ap020a00f: Convert to i2c's .probe_new()
> iio: light: isl29018: Convert to i2c's .probe_new()
> iio: light: isl29028: Convert to i2c's .probe_new()
> iio: light: isl29125: Convert to i2c's .probe_new()
> iio: light: jsa1212: Convert to i2c's .probe_new()
> iio: light: ltr501: Convert to i2c's .probe_new()
> iio: light: lv0104cs: Convert to i2c's .probe_new()
> iio: light: max44000: Convert to i2c's .probe_new()
> iio: light: max44009: Convert to i2c's .probe_new()
> iio: light: noa1305: Convert to i2c's .probe_new()
> iio: light: opt3001: Convert to i2c's .probe_new()
> iio: light: pa12203001: Convert to i2c's .probe_new()
> iio: light: rpr0521: Convert to i2c's .probe_new()
> iio: light: si1133: Convert to i2c's .probe_new()
> iio: light: si1145: Convert to i2c's .probe_new()
> iio: light: st_uvis25_i2c: Convert to i2c's .probe_new()
> iio: light: stk3310: Convert to i2c's .probe_new()
> iio: light: tcs3414: Convert to i2c's .probe_new()
> iio: light: tcs3472: Convert to i2c's .probe_new()
> iio: light: tsl2563: Convert to i2c's .probe_new()
> iio: light: tsl2583: Convert to i2c's .probe_new()
> iio: light: tsl2772: Convert to i2c's .probe_new()
> iio: light: tsl4531: Convert to i2c's .probe_new()
> iio: light: us5182d: Convert to i2c's .probe_new()
> iio: light: vcnl4000: Convert to i2c's .probe_new()
> iio: light: vcnl4035: Convert to i2c's .probe_new()
> iio: light: veml6030: Convert to i2c's .probe_new()
> iio: light: veml6070: Convert to i2c's .probe_new()
> iio: light: zopt2201: Convert to i2c's .probe_new()
> iio: magnetometer: ak8974: Convert to i2c's .probe_new()
> iio: magnetometer: ak8975: Convert to i2c's .probe_new()
> iio: magnetometer: bmc150_magn_i2c: Convert to i2c's .probe_new()
> iio: magnetometer: hmc5843: Convert to i2c's .probe_new()
> iio: magnetometer: mag3110: Convert to i2c's .probe_new()
> iio: magnetometer: mmc35240: Convert to i2c's .probe_new()
> iio: magnetometer: yamaha-yas530: Convert to i2c's .probe_new()
> iio: potentiometer: ad5272: Convert to i2c's .probe_new()
> iio: potentiometer: ds1803: Convert to i2c's .probe_new()
> iio: potentiometer: max5432: Convert to i2c's .probe_new()
> iio: potentiometer: tpl0102: Convert to i2c's .probe_new()
> iio: potentiostat: lmp91000: Convert to i2c's .probe_new()
> iio: pressure: abp060mg: Convert to i2c's .probe_new()
Not this one > iio: pressure: bmp280-i2c: Convert to i2c's .probe_new()
> iio: pressure: dlhl60d: Convert to i2c's .probe_new()
> iio: pressure: dps310: Convert to i2c's .probe_new()
> iio: pressure: hp03: Convert to i2c's .probe_new()
> iio: pressure: hp206c: Convert to i2c's .probe_new()
> iio: pressure: icp10100: Convert to i2c's .probe_new()
> iio: pressure: mpl115_i2c: Convert to i2c's .probe_new()
> iio: pressure: mpl3115: Convert to i2c's .probe_new()
> iio: pressure: ms5611_i2c: Convert to i2c's .probe_new()
> iio: pressure: ms5637: Convert to i2c's .probe_new()
> iio: pressure: st_pressure_i2c: Convert to i2c's .probe_new()
> iio: pressure: t5403: Convert to i2c's .probe_new()
> iio: pressure: zpa2326_i2c: Convert to i2c's .probe_new()
> iio: proximity: isl29501: Convert to i2c's .probe_new()
> iio: proximity: mb1232: Convert to i2c's .probe_new()
> iio: proximity: pulsedlight-lidar-lite-v2: Convert to i2c's
> .probe_new()
> iio: proximity: rfd77402: Convert to i2c's .probe_new()
> iio: proximity: srf08: Convert to i2c's .probe_new()
> iio: proximity: sx9500: Convert to i2c's .probe_new()
> iio: temperature: mlx90614: Convert to i2c's .probe_new()
> iio: temperature: mlx90632: Convert to i2c's .probe_new()
> iio: temperature: tmp006: Convert to i2c's .probe_new()
> iio: temperature: tmp007: Convert to i2c's .probe_new()
> iio: temperature: tsys01: Convert to i2c's .probe_new()
> iio: temperature: tsys02d: Convert to i2c's .probe_new()
...
> staging: iio: adt7316: Convert to i2c's .probe_new()
> staging: iio: ad5933: Convert to i2c's .probe_new()
> staging: iio: ade7854: Convert to i2c's .probe_new()
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-22 18:58 ` Jonathan Cameron
@ 2022-11-22 20:16 ` Uwe Kleine-König
2022-11-26 15:43 ` Andy Shevchenko
0 siblings, 1 reply; 39+ messages in thread
From: Uwe Kleine-König @ 2022-11-22 20:16 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Uwe Kleine-König, alsa-devel, linux-staging, linux-pwm,
linux-iio, linux-fbdev, platform-driver-x86, linux-mtd, linux-i2c,
Lee Jones, linux-stm32, linux-leds, linux-rtc, linux-renesas-soc,
linux-samsung-soc, linux-pm, Broadcom internal kernel review list,
linux-serial, linux-input, Grant Likely, linux-media, devicetree,
linux-watchdog, chrome-platform, linux-actions, linux-gpio,
Angel Iglesias, gregkh, linux-rpi-kernel, linux-amlogic,
openipmi-developer, linux-omap, linux-arm-kernel,
Purism Kernel Team, patches, linux-usb, linux-kernel, linux-spi,
Wolfram Sang, linux-crypto, kernel, netdev, linux-integrity,
linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]
On Tue, Nov 22, 2022 at 06:58:18PM +0000, Jonathan Cameron wrote:
>
> Queued all of the below:
> with one tweaked as per your suggestion and the highlighted one dropped on basis
> I was already carrying the equivalent - as you pointed out.
>
> I was already carrying the required dependency.
>
> Includes the IIO ones in staging.
>
> Thanks,
>
> Jonathan
>
> p.s. I perhaps foolishly did this in a highly manual way so as to
> also pick up Andy's RB. So might have dropped one...
You could have done:
H=$(git rev-parse @)
b4 am -P 49-190 20221118224540.619276-1-uwe@kleine-koenig.org
git am ...
git filter-branch -f --msg-filter "grep -v 'Signed-off-by: Jonathan'; echo 'Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>'; echo 'Signed-off-by: Jonathan Cameron <jic23@kernel.org>'" $H..
(untested, but you get the idea).
> Definitely would have been better as one patch per subsystem with
> a cover letter suitable for replies like Andy's to be picked up
> by b4.
Next time I will go for one series per subsystem which I like better
than one patch per subsystem.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-22 20:16 ` Uwe Kleine-König
@ 2022-11-26 15:43 ` Andy Shevchenko
0 siblings, 0 replies; 39+ messages in thread
From: Andy Shevchenko @ 2022-11-26 15:43 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Jonathan Cameron, Uwe Kleine-König, alsa-devel,
linux-staging, linux-pwm, linux-iio, linux-fbdev,
platform-driver-x86, linux-mtd, linux-i2c, Lee Jones, linux-stm32,
linux-leds, linux-rtc, linux-renesas-soc, linux-samsung-soc,
linux-pm, Broadcom internal kernel review list, linux-serial,
linux-input, Grant Likely, linux-media, devicetree,
linux-watchdog, chrome-platform, linux-actions, linux-gpio,
Angel Iglesias, gregkh, linux-rpi-kernel, linux-amlogic,
openipmi-developer, linux-omap, linux-arm-kernel,
Purism Kernel Team, patches, linux-usb, linux-kernel, linux-spi,
Wolfram Sang, linux-crypto, kernel, netdev, linux-integrity,
linuxppc-dev
On Tue, Nov 22, 2022 at 09:16:54PM +0100, Uwe Kleine-König wrote:
> On Tue, Nov 22, 2022 at 06:58:18PM +0000, Jonathan Cameron wrote:
> > Queued all of the below:
> > with one tweaked as per your suggestion and the highlighted one dropped on basis
> > I was already carrying the equivalent - as you pointed out.
> >
> > I was already carrying the required dependency.
> >
> > Includes the IIO ones in staging.
> >
> > p.s. I perhaps foolishly did this in a highly manual way so as to
> > also pick up Andy's RB. So might have dropped one...
>
> You could have done:
>
> H=$(git rev-parse @)
> b4 am -P 49-190 20221118224540.619276-1-uwe@kleine-koenig.org
> git am ...
> git filter-branch -f --msg-filter "grep -v 'Signed-off-by: Jonathan'; echo 'Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>'; echo 'Signed-off-by: Jonathan Cameron <jic23@kernel.org>'" $H..
>
> (untested, but you get the idea).
That's, for example (just last from the history as is), how I usually do it
(tested):
git filter-branch --msg-filter 'sed -e "/Signed-off-by: Andy Shevchenko/ a Tested-by: Daniel Scally <dan.scally@ideasonboard.com>"' -f HEAD~4..HEAD
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: (subset) [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (26 preceding siblings ...)
2022-11-22 18:58 ` Jonathan Cameron
@ 2022-12-09 12:00 ` Robert Foss
2022-12-12 16:36 ` Robert Foss
28 siblings, 0 replies; 39+ messages in thread
From: Robert Foss @ 2022-12-09 12:00 UTC (permalink / raw)
To: Uwe Kleine-König, Wolfram Sang, Angel Iglesias, Grant Likely,
Lee Jones
Cc: Robert Foss, Broadcom internal kernel review list, linux-gpio,
linux-rtc, linux-arm-kernel, linux-input, linux-integrity,
linux-media, openipmi-developer, linux-serial, linux-usb,
linux-spi, kernel, Purism Kernel Team, linux-rpi-kernel,
linux-leds, linux-actions, netdev, linux-iio, linux-pwm,
linux-staging, chrome-platform, linux-crypto, linux-watchdog,
linux-amlogic, linux-fbdev, linux-renesas-soc, linux-i2c,
linux-kernel, alsa-devel, linux-stm32, linuxppc-dev, patches,
linux-omap, linux-mtd, linux-samsung-soc, linux-pm,
platform-driver-x86, devicetree
On Fri, 18 Nov 2022 23:35:34 +0100, Uwe Kleine-König wrote:
> since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type") from 2016 there is a "temporary" alternative probe
> callback for i2c drivers.
>
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
> A part of the patches depend on commit 662233731d66 ("i2c: core:
> Introduce i2c_client_get_device_id helper function"), there is a branch that
> you can pull into your tree to get it:
>
> [...]
Applied all patches that build.
Patches excluded:
- ps8622
- ti-sn65dsi83
- adv7511
Repo: https://cgit.freedesktop.org/drm/drm-misc/
[014/606] drm/bridge: adv7511: Convert to i2c's .probe_new()
(no commit info)
[015/606] drm/bridge/analogix/anx6345: Convert to i2c's .probe_new()
(no commit info)
[016/606] drm/bridge/analogix/anx78xx: Convert to i2c's .probe_new()
(no commit info)
[017/606] drm/bridge: anx7625: Convert to i2c's .probe_new()
(no commit info)
[018/606] drm/bridge: icn6211: Convert to i2c's .probe_new()
(no commit info)
[019/606] drm/bridge: chrontel-ch7033: Convert to i2c's .probe_new()
commit: 8dc6de280f01c0f7b8d40435736f3c975368ad70
[020/606] drm/bridge: it6505: Convert to i2c's .probe_new()
(no commit info)
[021/606] drm/bridge: it66121: Convert to i2c's .probe_new()
(no commit info)
[022/606] drm/bridge: lt8912b: Convert to i2c's .probe_new()
(no commit info)
[023/606] drm/bridge: lt9211: Convert to i2c's .probe_new()
(no commit info)
[024/606] drm/bridge: lt9611: Convert to i2c's .probe_new()
(no commit info)
[025/606] drm/bridge: lt9611uxc: Convert to i2c's .probe_new()
(no commit info)
[026/606] drm/bridge: megachips: Convert to i2c's .probe_new()
(no commit info)
[027/606] drm/bridge: nxp-ptn3460: Convert to i2c's .probe_new()
(no commit info)
[028/606] drm/bridge: parade-ps8622: Convert to i2c's .probe_new()
(no commit info)
[029/606] drm/bridge: sii902x: Convert to i2c's .probe_new()
(no commit info)
[030/606] drm/bridge: sii9234: Convert to i2c's .probe_new()
(no commit info)
[031/606] drm/bridge: sii8620: Convert to i2c's .probe_new()
(no commit info)
[032/606] drm/bridge: tc358767: Convert to i2c's .probe_new()
(no commit info)
[033/606] drm/bridge: tc358768: Convert to i2c's .probe_new()
(no commit info)
[034/606] drm/bridge/tc358775: Convert to i2c's .probe_new()
(no commit info)
[035/606] drm/bridge: ti-sn65dsi83: Convert to i2c's .probe_new()
(no commit info)
[037/606] drm/bridge: tfp410: Convert to i2c's .probe_new()
(no commit info)
rob
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: (subset) [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
2022-11-18 22:35 [PATCH 000/606] i2c: Complete conversion to i2c_probe_new Uwe Kleine-König
` (27 preceding siblings ...)
2022-12-09 12:00 ` (subset) " Robert Foss
@ 2022-12-12 16:36 ` Robert Foss
28 siblings, 0 replies; 39+ messages in thread
From: Robert Foss @ 2022-12-12 16:36 UTC (permalink / raw)
To: Lee Jones, Uwe Kleine-König, Angel Iglesias, Wolfram Sang,
Grant Likely
Cc: Robert Foss, linuxppc-dev, linux-actions, linux-spi, devicetree,
linux-media, linux-stm32, linux-crypto, chrome-platform,
Broadcom internal kernel review list, linux-input,
linux-rpi-kernel, linux-integrity, linux-omap, linux-serial,
Purism Kernel Team, linux-staging, alsa-devel, linux-watchdog,
linux-gpio, linux-rtc, linux-leds, linux-iio, linux-kernel,
linux-usb, linux-pm, platform-driver-x86, patches, linux-mtd,
linux-renesas-soc, linux-amlogic, linux-pwm, linux-samsung-soc,
linux-i2c, kernel, netdev, linux-arm-kernel, openipmi-developer,
linux-fbdev
On Fri, 18 Nov 2022 23:35:34 +0100, Uwe Kleine-König wrote:
> since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type") from 2016 there is a "temporary" alternative probe
> callback for i2c drivers.
>
> This series completes all drivers to this new callback (unless I missed
> something). It's based on current next/master.
> A part of the patches depend on commit 662233731d66 ("i2c: core:
> Introduce i2c_client_get_device_id helper function"), there is a branch that
> you can pull into your tree to get it:
>
> [...]
Applied, thanks!
Repo: https://cgit.freedesktop.org/drm/drm-misc/
[014/606] drm/bridge: adv7511: Convert to i2c's .probe_new()
commit: 1c546894ff82f8b7c070998c03f9b15a3499f326
[028/606] drm/bridge: parade-ps8622: Convert to i2c's .probe_new()
commit: d6b522e9bbb0cca1aeae4ef6188800534794836f
[035/606] drm/bridge: ti-sn65dsi83: Convert to i2c's .probe_new()
commit: 0f6548807fa77e87bbc37964c6b1ed9ba6e1155d
rob
^ permalink raw reply [flat|nested] 39+ messages in thread