public inbox for linux-leds@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Hui Wang <hui.wang@canonical.com>
Cc: linux-leds@vger.kernel.org, pavel@ucw.cz
Subject: Re: [PATCH] leds: pwm: clear the led structure before parsing each child node
Date: Wed, 4 Jan 2023 18:15:48 +0000	[thread overview]
Message-ID: <Y7XCVDpHbvc5P/NY@google.com> (raw)
In-Reply-To: <20221220073335.393489-1-hui.wang@canonical.com>

On Tue, 20 Dec 2022, Hui Wang wrote:

> I defined 2 leds in the device tree, in the 1st led node, the
> max-brightness is set to 248, while in the 2nd led node, I
> mis-spelled the max-brightness to max-brighttness, but the driver
> is still able to get the max-brightness 248 for the 2nd node,  that
> is because the led structure is not cleared before parsing each child
> node.
> 
> 	pwmleds {
> 		compatible = "pwm-leds";
> 
> 		pwm-green {
> 			...
> 			max-brightness = <248>;
> 		};
> 
> 		pwm-red {
> 		        ...
> 			max-brighttness = <128>;
> 		};
> 
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  drivers/leds/leds-pwm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]

      reply	other threads:[~2023-01-04 18:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  7:33 [PATCH] leds: pwm: clear the led structure before parsing each child node Hui Wang
2023-01-04 18:15 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7XCVDpHbvc5P/NY@google.com \
    --to=lee@kernel.org \
    --cc=hui.wang@canonical.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox