From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4B3C54EBD for ; Mon, 9 Jan 2023 16:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbjAIQ5N (ORCPT ); Mon, 9 Jan 2023 11:57:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236677AbjAIQ4j (ORCPT ); Mon, 9 Jan 2023 11:56:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A155A22A; Mon, 9 Jan 2023 08:56:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31E95611A0; Mon, 9 Jan 2023 16:56:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 994B1C433EF; Mon, 9 Jan 2023 16:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673283397; bh=NpgdUywdtZmmgVQ+ulovo4MOXF9WUa/Zni2/s0Grk2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b/7MU+aXJgDuZvXlUTbYIQypzqKJIcJCR0ilMkZza5MFk+3Q35KuLJTtgu+L9NKU0 rbCCU2G5VlryEX50yxv1b4ZnSouI4ZEKaADU9B/Rf6lIbMfxvx04QKClac6jKkR7Jw Vu1St4n1CAlysMPJCxyCRU07OT0oNzq2udlGb/GXNb8sbNBxDYXD3Ir9dCHNdCSuHi 8152efaCbloMbNIt37bEvD27UJvQ1hDf7eth6kiTGnu6a8Q5Nqy0KFhufWKIGbmYNp tvvWCRqiKNjG5hc9mReiOtZe3xsVKWwgUOBWqGXDEv7X0zUonQ8txoWrt2eRd7In0B nur+ajEj9ikLQ== Date: Mon, 9 Jan 2023 16:56:32 +0000 From: Lee Jones To: Joseph Strauss Cc: pavel@ucw.cz, jansimon.moeller@gmx.de, conor@kernel.org, christophe.jaillet@wanadoo.fr, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Add multicolor support to BlinkM LED driver Message-ID: References: <20221228010958.9670-1-jstrauss@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221228010958.9670-1-jstrauss@mailbox.org> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, 27 Dec 2022, Joseph Strauss wrote: > Added multicolor support to the BlinkM driver, making it easier to > control from userspace. The BlinkM LED is a programmable RGB LED. The > driver currently supports only the regular LED sysfs class, resulting in > the creation of three distinct classes, one for red, green, and blue. > The user then has to input three values into the three seperate > brightness files within those classes. The multicolor LED framework > makes the device easier to control with the multi_intensity file: the > user can input three values at once to form a color, while still > controlling the lightness with the brightness file. > > The main struct blinkm_led has changed slightly. A struct > led_classdev_mc has been added to represent the multicolor sysfs class, > and an additional struct led_classdev pointer has been added for > convenience, which points to the struct led_classdev within struct > led_classdev_mc. The struct led_classdev for the regular sysfs classes > remain. Additionally, a field representing the multicolor LED has been > added to the struct blinkm_data, seperate from the blinkm_leds[3] array. > > In the blinkm_probe function, the multicolor LED class is registered > after the regular LED classes. The blinkm_set_mc_brightness() function > had to be added to calculate the three color components and then set the > fields of the blinkm_data structure accordingly. > > Signed-off-by: Joseph Strauss > --- > Changes in v2: > - Replaced instances of the constant 3 with NUM_LEDS, where applicable > - Fixed formatting errors > - Replaced loop inside of blinkm_set_mc_brightness() with equivalent > statements > - Changed id of multicolor class from 4 to 3 > - Replaced call to devm_kmalloc_array() with devm_kcalloc() > > Documentation/leds/leds-blinkm.rst | 26 +++++- > drivers/leds/Kconfig | 1 + > drivers/leds/leds-blinkm.c | 143 +++++++++++++++++++++++------ > 3 files changed, 137 insertions(+), 33 deletions(-) Another one for Pavel until I can build some knowledge. -- Lee Jones [李琼斯]