Re: [bug report] leds: ns2: Remove work queue

Pavel Machek
2021-12-15T20:40:03Z

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

Hi!

> Hello LED devs,
>
> The patch c29e650b3af2: "leds: ns2: Remove work queue" from Nov 20,
> 2015, leads to the following Smatch static checker warning:
>
> drivers/leds/leds-ns2.c:96 ns2_led_set_mode()
> warn: sleeping in atomic context

Yup, this looks wrong.

Plus, the code is quite crazy.

Not sure what the write_lock in that function is supposed to protect
against. Perhaps it can be just removed?

Hmm. led_set_mode uses custom interface for hardware accelerated
LED. Ideally there's more fixing to be done there :-(.

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]