Re: [PATCH v14 2/2] leds: Add driver for Qualcomm LPG

Pavel Machek
2022-05-04T07:30:13Z

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

Hi!

> +/sys/class/leds/<led>/hw_pattern
> +--------------------------------
> +
> +Specify a hardware pattern for a Qualcomm LPG LED.
> +
> +The pattern is a series of brightness and hold-time pairs, with the hold-time
> +expressed in milliseconds. The hold time is a property of the pattern and must
> +therefor be identical for each element in the pattern (except for the pauses
> +described below).

therefore?

> +Simple pattern::
> +
> + "255 500 0 500"
> +
> + ^
> + |
> + 255 +----+ +----+
> + | | | | ...
> + 0 | +----+ +----
> + +---------------------->
> + 0 5 10 15 time (100ms)
> +
> +The LPG supports specifying a longer hold-time for the first and last element
> +in the pattern, the so called "low pause" and "high pause".

Please see
Documentation/devicetree/bindings/leds/leds-trigger-pattern.txt . This
should really be compatible.

Can I get either patch to disable pattern infrastructure for now or to
get it compatible?

Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]