From: Pavel Machek <pavel@ucw.cz>
To: Sven Schwermer <sven@svenschwermer.de>
Cc: linux-leds@vger.kernel.org,
Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
jacek.anaszewski@gmail.com, schuchmann@schleissheimer.de
Subject: Re: [PATCH RESEND v2] led: multicolor: Fix intensity setting while SW blinking
Date: Thu, 23 Mar 2023 12:38:27 +0100 [thread overview]
Message-ID: <ZBw6Mwa0cWAddj3P@duo.ucw.cz> (raw)
In-Reply-To: <20220627133110.271455-1-sven@svenschwermer.de>
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
On Mon 2022-06-27 15:31:10, Sven Schwermer wrote:
> From: Sven Schwermer <sven.schwermer@disruptive-technologies.com>
>
> When writing to the multi_intensity file, don't unconditionally call
> led_set_brightness. By only doing this if blinking is inactive we
> prevent blinking from stopping if the blinking is in its off phase while
> the file is written.
>
> Instead, if blinking is active, the changed intensity values are applied
> upon the next blink. This is consistent with changing the brightness on
> monochrome LEDs with active blinking.
>
> Suggested-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Tested-by: Sven Schuchmann <schuchmann@schleissheimer.de>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Signed-off-by: Sven Schwermer
<sven.schwermer@disruptive-technologies.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-03-23 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 13:31 [PATCH RESEND v2] led: multicolor: Fix intensity setting while SW blinking Sven Schwermer
2023-01-04 8:46 ` AW: " Sven Schuchmann
2023-03-22 17:25 ` Jacek Anaszewski
2023-03-23 11:38 ` Pavel Machek [this message]
2025-04-02 20:53 ` Tobias Deiminger
2025-04-04 15:46 ` Lee Jones
2025-04-04 18:40 ` [PATCH v3] " Sven Schwermer
2025-04-10 9:53 ` (subset) " Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2022-06-01 6:37 [PATCH RESEND v2] " Sven Schwermer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBw6Mwa0cWAddj3P@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=schuchmann@schleissheimer.de \
--cc=sven.schwermer@disruptive-technologies.com \
--cc=sven@svenschwermer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox