From: Pavel Machek <pavel@ucw.cz>
To: Tom Rix <trix@redhat.com>
Cc: lee@kernel.org, quic_fenglinw@quicinc.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs storage-class-specifier to static
Date: Thu, 23 Mar 2023 20:47:13 +0100 [thread overview]
Message-ID: <ZByswXZdvtaLOT02@duo.ucw.cz> (raw)
In-Reply-To: <20230317191341.1670660-1-trix@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Fri 2023-03-17 15:13:41, Tom Rix wrote:
> smatch reports
> drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
> symbol 'mvflash_3ch_regs' was not declared. Should it be static?
> drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
> symbol 'mvflash_4ch_regs' was not declared. Should it be static?
>
> These variables are only used in leds-qcom-flash.c,
> so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-03-23 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 19:13 [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs storage-class-specifier to static Tom Rix
2023-03-23 19:47 ` Pavel Machek [this message]
2023-03-30 13:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZByswXZdvtaLOT02@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).