From: Pavel Machek <pavel@ucw.cz>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Matti Vaittinen <mazziesaccount@gmail.com>
Subject: Re: [PATCH v5 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel i2c LED driver
Date: Mon, 17 Apr 2023 14:22:18 +0200 [thread overview]
Message-ID: <ZD05+hsRy14semza@duo.ucw.cz> (raw)
In-Reply-To: <20230416211550.903240-3-andreas@kemnade.info>
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]
Hi!
> The device provides 6 channels which can be individually
> turned off and on but groups of two channels share a common brightness
> register.
>
> Limitation: The GPIO to enable the device is not used yet.
(I'd expect some explanation how you dealt with the brigthness pairing
here. I can figure it out from the fcode, but... I guess you should
state it at the begining of driver in a comment at least.).
> +++ b/drivers/leds/Kconfig
> @@ -551,6 +551,17 @@ config LEDS_REGULATOR
> help
> This option enables support for regulator driven LEDs.
>
> +config LEDS_BD2606MVV
> + tristate "LED driver for BD2606MVV"
> + depends on LEDS_CLASS
> + depends on I2C
> + select REGMAP_I2C
> + help
> + This option enables support for BD2606MVV LED driver chips
> + accessed via the I2C bus. It supports setting brightness, with
> + the limitiation that there are groups of two channels sharing
> + a brightness setting, but not the on/off setting.
Add the usual note about modules here.
Rest looks ok.
With that fixed:
Acked-by: Pavel Machek <pavel@ucw.cz>
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2023-04-17 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 21:15 [PATCH v5 0/2] leds: Add a driver for the BD2606MVV Andreas Kemnade
2023-04-16 21:15 ` [PATCH v5 1/2] dt-bindings: leds: Add ROHM BD2606MVV LED Andreas Kemnade
2023-04-18 22:29 ` Rob Herring
2023-04-16 21:15 ` [PATCH v5 2/2] leds: bd2606mvv: Driver for the Rohm 6 Channel i2c LED driver Andreas Kemnade
2023-04-17 12:22 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD05+hsRy14semza@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).