From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C0DC0015E for ; Tue, 18 Jul 2023 14:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231138AbjGROVd (ORCPT ); Tue, 18 Jul 2023 10:21:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbjGROVb (ORCPT ); Tue, 18 Jul 2023 10:21:31 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 551A9B5; Tue, 18 Jul 2023 07:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689690085; x=1721226085; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0861blgBMRAfvbFAlkcqEo4YjVxrPm0OzISkjLVjP7o=; b=eTVO0sYqjKyrre8ayf5rBQBbVJG/EU3QVnD/Jq/T8D1ve0qnKugWULcc ccCOQP++TcHHZIeGFmk07BDAZilHjaXgybPOEVrHgcFjTbwNpFoArVMZD CIIFjq0d2CMLBvzgPqNH+kQgAG2GRo1AugsPYifj7eDU1nWdRUOf2RoAR lUPmhE2EspOSPpvnE+yWAGwqXlBqkD1DjCnIKcGeUNpio4DiLcIG6M4vV 3twpzIUCNT0Ac+tmyytGFb4x/XQPo9ohXi/KEr0yHvygcRwPooVL1s3Ka 2LGJAty+j8VW1tWerpE/mlWxUAfgYSoQReRMrYmNekxLBSzua/PChI61H w==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="432398328" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="432398328" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 07:21:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="717607969" X-IronPort-AV: E=Sophos;i="6.01,214,1684825200"; d="scan'208";a="717607969" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 18 Jul 2023 07:20:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLlZJ-00Grxd-0L; Tue, 18 Jul 2023 17:20:49 +0300 Date: Tue, 18 Jul 2023 17:20:48 +0300 From: Andy Shevchenko To: Henning Schild Cc: Lee Jones , Hans de Goede , Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-watchdog@vger.kernel.org, Pavel Machek , Mark Gross , Tobias Schaffner Subject: Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver default on platform Message-ID: References: <20230718105213.1275-1-henning.schild@siemens.com> <20230718105213.1275-2-henning.schild@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718105213.1275-2-henning.schild@siemens.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote: > If a user did choose to enable Siemens Simatic platform support they > likely want that driver to be enabled without having to flip more config > switches. So we make the watchdog driver config switch default to the > platform driver switches value. A nit-pick below. ... > config SIEMENS_SIMATIC_IPC_WDT > tristate "Siemens Simatic IPC Watchdog" > depends on SIEMENS_SIMATIC_IPC > + default SIEMENS_SIMATIC_IPC It's more natural to group tristate and default, vs. depends and select. > select WATCHDOG_CORE > select P2SB -- With Best Regards, Andy Shevchenko