From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Lee Jones <lee@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-watchdog@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Mark Gross <markgross@kernel.org>,
Tobias Schaffner <tobias.schaffner@siemens.com>
Subject: Re: [PATCH 3/3] platform/x86: Move all simatic ipc drivers to the subdirectory siemens
Date: Tue, 18 Jul 2023 18:15:06 +0300 [thread overview]
Message-ID: <ZLasehsClBD8pkPC@smile.fi.intel.com> (raw)
In-Reply-To: <20230718164727.6a89e3da@md1za8fc.ad001.siemens.net>
On Tue, Jul 18, 2023 at 04:47:27PM +0200, Henning Schild wrote:
> Am Tue, 18 Jul 2023 17:23:30 +0300
> schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>
> > On Tue, Jul 18, 2023 at 12:52:13PM +0200, Henning Schild wrote:
> > > Users without a Siemens Simatic IPC will not care about any of these
> > > drivers. Users who do care can enable the submenu and all drivers
> > > behind it will be enabled.
...
> > > # Siemens Simatic Industrial PCs
> > > +obj-$(CONFIG_X86_PLATFORM_DRIVERS_SIEMENS) +=
> > > siemens/
> >
> > Do you need conditional here? We have stumbled over similar for
> > entire intel subfolder, it might affect the rest as well when you
> > don't expect it.
> >
> > obj-y += siemens/
> >
> > ?
>
> It was requested to be done like that by Hans, he wanted me to do a
> similar thing that
"Similar" is not the "same". :-)
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f1e1ea516721d1ea0b21327ff9e6cb2c2bb86e28
> is doing.
>
> And that is what i did. If there was a y ... the whole "one switch to
> rule them all" story would not work out anymore.
See these:
https://git.kernel.org/torvalds/c/8bd836feb6ca
https://git.kernel.org/torvalds/c/4f6c131c3c31
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-18 15:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 10:52 [PATCH 0/3] platform/x86: move simatic ipc drivers into subdir Henning Schild
2023-07-18 10:52 ` [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver default on platform Henning Schild
2023-07-18 14:20 ` Andy Shevchenko
2023-07-18 14:42 ` Henning Schild
2023-07-18 15:10 ` Guenter Roeck
2023-07-19 7:18 ` Henning Schild
2023-07-19 13:27 ` Guenter Roeck
2023-07-19 14:40 ` Henning Schild
2023-07-18 15:07 ` Guenter Roeck
2023-07-19 7:20 ` Henning Schild
2023-07-18 10:52 ` [PATCH 2/3] leds: simatic-ipc-leds: default config switch to platform switch Henning Schild
2023-07-18 14:21 ` Andy Shevchenko
2023-07-18 14:43 ` Henning Schild
2023-07-19 8:43 ` Lee Jones
2023-07-19 10:54 ` Henning Schild
2023-07-18 10:52 ` [PATCH 3/3] platform/x86: Move all simatic ipc drivers to the subdirectory siemens Henning Schild
2023-07-18 10:58 ` Henning Schild
2023-07-18 14:23 ` Andy Shevchenko
2023-07-18 14:47 ` Henning Schild
2023-07-18 15:15 ` Andy Shevchenko [this message]
2023-07-19 8:32 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLasehsClBD8pkPC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tobias.schaffner@siemens.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox