From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346A8EB64DA for ; Wed, 19 Jul 2023 16:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbjGSQJp (ORCPT ); Wed, 19 Jul 2023 12:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjGSQJp (ORCPT ); Wed, 19 Jul 2023 12:09:45 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 607EA113; Wed, 19 Jul 2023 09:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689782984; x=1721318984; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bfmNxrSOSuOKyNBS+iuM0AhQyIpxlWUsNNWHaPn1DrQ=; b=MMiqb4ahPGRrPldVkBfeQtmyBY5lk5w2qhLFzObq3JJ64RaJhUcQk2iq QdWNFWYL4lW1Gz6gvO9QbBQiTOkY+7k1u6ewCxecygQyC6A8kPzu43JC4 FeKILvJB6hh4RlVdMSJVbYCb8V+3m06FOlDz4eihBFEMJhB8Ww76+5k0/ s5Y+uVNTTbGdZ0/eIx+bugpUbKCrrksISTUKNYl0d1g8X3JDqHgEjH9Jf cHU83+WyxKXml1VTKnPq5GDRUX2QkQFcJtnzaicBGsJrEA9wLW3+3hrLH FYMl5sOkMnFZeGHyZDImPGWZAi/9tEBRRhNQ/RYcFSnVVntRrLc4afl+a g==; X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="356464764" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="356464764" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 09:06:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10776"; a="674352133" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="674352133" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 19 Jul 2023 09:06:06 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qM9gj-00HVG2-0p; Wed, 19 Jul 2023 19:06:05 +0300 Date: Wed, 19 Jul 2023 19:06:04 +0300 From: Andy Shevchenko To: Henning Schild Cc: Lee Jones , Hans de Goede , Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-watchdog@vger.kernel.org, Pavel Machek , Mark Gross , Tobias Schaffner Subject: Re: [PATCH v2 0/3] platform/x86: move simatic drivers into subdir Message-ID: References: <20230719153518.13073-1-henning.schild@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719153518.13073-1-henning.schild@siemens.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, Jul 19, 2023 at 05:35:15PM +0200, Henning Schild wrote: > change since v1: > - switch LED/wdt Kconfig to "default y" > - remove guard which could hide whole siemens submenu, and default m > > This series does two things. It builds up a Kconfig inheritance chain > for all platform device drivers, namely Watchdog and LED. And then it > puts all Siemens Simatic IPC drivers in the platform/x86/ directory in > a subdirectory called "siemens". > > That is so that users have to flip less config switches, and to ease > maintenance. All three good enough, although I prefer the ordering that 'tristate' followed by 'default' without interleaved 'depends on'. I leave it to Hans. Other that that, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko