From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9ED7209F47 for ; Mon, 7 Apr 2025 16:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744042433; cv=none; b=HPJ5wpRbT6X4f5mfF3N/IN9Yo2D+fyroJ0Zk8PIPTSu7wJ/eYhJ1q6ANHfPBb0v/g4VD8UbCWcPUGWW65Pz2nwOnLABaNbeY2qpyjHfT1dRRJAbSBJUwef1JDxq86/Rw87RtRF7B81uvV9uDyTpOMCPon+J52njuapjFw63gPFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744042433; c=relaxed/simple; bh=momMVb5vlwB7w7QBIrh4FuJxBMr+DXof5tHLvIxbILc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZgZyn1B7DdoHrcIRmrbevElBeBt4Dgfng+n0QmAfywY1zgtWucrKANkWHwsvrFwTvEoxfN58fr5r/FUzouVsWcbb+pbWmC62HBlBy7YwfKwZMs7I0wLVy8jDk849IROS89sw/+ayJs4cqUXNaRVP+r4QsU1k+OQ1Cam+BcfH5TE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=VUkcGvdZ; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="VUkcGvdZ" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so44101015e9.2 for ; Mon, 07 Apr 2025 09:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1744042428; x=1744647228; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hAlufBsPlnjuTWbgusP8CYnzhAGj3Mnwll46JdWGBbE=; b=VUkcGvdZWUbu9OzL8xb/T9nIPABJp+EpwUB25HeDeqsIYBWHw/KxG+9HzB6zJ25efA IEVWesGAkZXnsKnEEQm5RrjsBBy/tM0vuvAVzxUKgGOfI/2MnZRk9eU1buIVmNaD/vyl 7ohlvYtihiG99nc1Pjalgx9Cg3PhduK3ocW9+yDw355ftfxGvBo3YocEdBwq8pF8+NYx lMdNCYIYwmRxY1Ub0vqMljGY5ITbfI0syUZ0bCM41CmNbN56FnpgJML2mZso6zE4ctdw GGWGXp/DxpbSRR2/MomVoMl/GluMdqLScFL5xdZU1NcCHhUkH0KM61p8FLLG8T+nyt1b kttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744042428; x=1744647228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hAlufBsPlnjuTWbgusP8CYnzhAGj3Mnwll46JdWGBbE=; b=iDWQ4ceiZE+SD3SSjq8L20t8ExJV0JBt2Le9toLJ9iESbYVsk1E72dVSZEQ05JHLr8 ug1o7nh/4j5Y22vNbugXGnJxz8dkvhvb1OzLs738uvHb5AO1MwTdai1+zrUT8tnPnZ5q MKqsHG5wqDWp31CmER0x5aFyQLQiAM8Q7w8Nqgdec8q0U87beApp3tbfBbKqHNmS3xyK 6/1NMG3koKKyOZXCJfLCfOJfY0yNrUpOub+oubLFB4PLM8AemJGwwrjGsPUAoahnLJTq 16nMjYXas8IYnGMwsVpDekKPM+aAG/haRwwanVM2S3m66Qvr7+GYpMEeQMwezxV9UO8C fY3g== X-Forwarded-Encrypted: i=1; AJvYcCW/TkRdsEmyhge75q95+jXjkC/gArb5hjhlzfZGCqjN/xFT72hZKv4GUUhk66vBfUwVh6uljI1bo3FQ@vger.kernel.org X-Gm-Message-State: AOJu0YxXPNAhVn0NPa0sza2/qgvy/TebbHMZhu2DmsSRUBlegJtyO7r4 hSD5b6xbwSHyfa3VdbV4gSRURpMX4aJJRg4vYYMb6ATufisfjy9OP4HOambqlPo= X-Gm-Gg: ASbGncujOLwLjLl5+5SKRjsdR8sPbUJhMQ+LkiRGFbE/hvoMYxcbIJCOU1v/tsCVJuo 4u4voqH0jEzJgbMcxwNK2VZpesEMK+n6QuUuKzgKAAGwKFfrCCUU/7Cisze2vMv+CROZgPycpaB 6BGsMi452C+hiBS+XRifmxsGGzeFTDVvloMkQCXHOEjXONy3WRzw2mTvTWUpwqJAHsNMfpJmJw7 K+5Lwe86j/VqR2qkdDZqlqSRQF/SjC0DadUUoUvnnE/YjToDOsGZFn/spVySwX3qqPmFszj3iMe k8KhqslILCSa95r4uHSHR6MYWnyyUhFcY4bznEIVSATeY28VQDpeLGAqnT+UvCdfxjQPYdl8XOq z7Rcm1VmkrIChtb3Y13aNidJpHqM= X-Google-Smtp-Source: AGHT+IF9E+Yu68SivmKTZ/2oBu6XpMDyufJhLClsxWUTbSHDLDqi5DwsmXJhaL8CEGG/v/moBPNDvw== X-Received: by 2002:a05:600c:1d28:b0:43c:fad6:fa5a with SMTP id 5b1f17b1804b1-43ed0d9ce1dmr107471025e9.24.1744042427942; Mon, 07 Apr 2025 09:13:47 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1630ddesm137924675e9.5.2025.04.07.09.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 09:13:46 -0700 (PDT) Date: Mon, 7 Apr 2025 17:13:44 +0100 From: Daniel Thompson To: Pengyu Luo Cc: Jianhua Lu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 3/4] backlight: ktz8866: improve current sinks setting Message-ID: References: <20250407095119.588920-1-mitltlatltl@gmail.com> <20250407095119.588920-4-mitltlatltl@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250407095119.588920-4-mitltlatltl@gmail.com> On Mon, Apr 07, 2025 at 05:51:18PM +0800, Pengyu Luo wrote: > I polled all registers when the module was loading, found that > current sinks have already been configured. Bootloader would set > when booting. So checking it before setting the all channels. Can you rephrase this so the problem and solution are more clearly expressed. Perhaps template Ingo suggests here would be good: https://www.spinics.net/lists/kernel/msg1633438.html > Signed-off-by: Pengyu Luo > --- > drivers/video/backlight/ktz8866.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/backlight/ktz8866.c b/drivers/video/backlight/ktz8866.c > index 017ad80dd..b67ca136d 100644 > --- a/drivers/video/backlight/ktz8866.c > +++ b/drivers/video/backlight/ktz8866.c > @@ -46,6 +46,8 @@ > #define LCD_BIAS_EN 0x9F > #define PWM_HYST 0x5 > > +#define CURRENT_SINKS_MASK GENMASK(5, 0) > + Call this BL_EN_CURRENT_SINKS_MASK and keep it next to the register it applies to. > struct ktz8866_slave { > struct i2c_client *client; > struct regmap *regmap; > @@ -112,11 +120,18 @@ static void ktz8866_init(struct ktz8866 *ktz) > { > unsigned int val = 0; > > - if (!of_property_read_u32(ktz->client->dev.of_node, "current-num-sinks", &val)) > + if (!of_property_read_u32(ktz->client->dev.of_node, "current-num-sinks", &val)) { > ktz8866_write(ktz, BL_EN, BIT(val) - 1); > - else > - /* Enable all 6 current sinks if the number of current sinks isn't specified. */ > - ktz8866_write(ktz, BL_EN, BIT(6) - 1); > + } else { > + /* > + * Enable all 6 current sinks if the number of current > + * sinks isn't specified and the bootloader didn't set > + * the value. > + */ > + ktz8866_read(ktz, BL_EN, &val); > + if (!(val && CURRENT_SINKS_MASK)) This is the wrong form of AND. > + ktz8866_write(ktz, BL_EN, CURRENT_SINKS_MASK); > + } Daniel.