From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B12E20967B for ; Mon, 7 Apr 2025 16:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744043271; cv=none; b=QVWQGjBXV7a+/HBAgimtCO7zOizA/QfJ1PpJsf1cxY9x7L/dJg3vGw9yGblZSkI+kcslLO8wWWeGqrMouapT5dNFtXmqqKRDpjym6MjCc0DkGz6xtMT/5txLI68NAMn92kE/1TBrhUjgBMJNOELz31YhQ/9kcdzxHyQO9dXlS9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744043271; c=relaxed/simple; bh=ixu4OFoJwzg1v+1wl51xk03lO5q8ieoco/QoCpn/be4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cIQ0DvNnYYEKEcmn95ms8ist/F/xB3cK4lbHw9Ej3HTioSqXFUIXuvQ7QpUQsejPvtX8KOIjh6QL5D+csMn6x5wohH9qwdYYXfLGx8w//4INp649xeuH/0w6W/NNQvS01qfzFPyoUinN7keBHSusFUwfnBcMUORDXLEpBY6Hh1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=CJjPujMh; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="CJjPujMh" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39bf44be22fso3102001f8f.0 for ; Mon, 07 Apr 2025 09:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1744043267; x=1744648067; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gmt4HX/iSNiSTqkD3t3ALwtpmvWnuIuBQoVi+iO2Lmc=; b=CJjPujMhKpR8Ka2qInFujzInJVSRNAgpGLfDvBTxTRZtTXaVur3Y4xK68UyceaFHh7 7pPcqYdXqsa3XhfsWV0/OCq8L0m2LkA13N9k2HWQ9jFAGeXSB3ShLkhRFB6HOSZxDa1N N3vu0K0ProzdEcBTfluMRCpfE2vYHJqpcrTdHD+QqbFa/H9bVk3kuPHNgRg7wysgFu/4 y6vYEbehUyBMWDRBATOJszi25NbagcmcvmZvcbey2LB0VhWms1V8dCnMC8FWLkLR3ngM 5UoAxTaM4V7MkSez7t41faMXV+SGO2jr+azrbjVPwet8CIgtQIsDNWfklXQ3PNVnnltN aSkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744043267; x=1744648067; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gmt4HX/iSNiSTqkD3t3ALwtpmvWnuIuBQoVi+iO2Lmc=; b=Nnj2eSGRYQnpdwG2cFO4FOb59gyDBl4isEJo2z6fRQThtbkOyfhNXT71jStZCx4k6c R6hYn7a7nnVWo6iAiqibje5veK+MMbpx5AOKoOP2+gg0sQOYCUMhUWHFPO5IzC66UC/A 9X8hVhjtu2RjLQYvoNfrU5wD64f9Nk9c6/B3JAfP7jWIfBW7asJvabn7Nna10VG9Ylqo IVDNHNvJSvlvt+ExLoaNsK1G7zKXnGE7z+pM33Co7G07dkYieKUvp2Za0557O+pZNMCl CA4hVHiyLd0H6cn1QeYAq/TpxzNCBacauc50XW3QnHbGLJbKj+XJykWKJw2BQlcYtlnE 2BZw== X-Forwarded-Encrypted: i=1; AJvYcCUA2oD1xwGtlJE+modmYVYuYSHYl94WNE0h/nQ6OT43Jr7QMPhMY4oV7fqsKcEDUXh6AZUtqnUFIth3@vger.kernel.org X-Gm-Message-State: AOJu0YxVukppaxfta/8Qbhghenqh2Jdi3aI5AtNSsDSilbOw4rkCHaQb h3OSG9VS5KTbNaPj7iCZKaFXFQQ4/8HEzEf9hS1tIVoSJsq8xvuMrEM8AGYLMOg= X-Gm-Gg: ASbGncutHKe4bxU1sEzPkTaQ1MaJisFRHS+KB4Fxs1OikRJU/O6X2qjaCLQ5xMn1aoq al12UCHHQZ+PP2hqkiQ2PRjWx7xZE9130hCf4Ec8oOQ7BcVi0XWdcuK/gBR0nv9lXlGUSawinyI 9q7cNA6SrVKcb7hBsqULHlSCEC2NzZgBORcSSVV2XzG0FZzaUCJhvEXqZbN6FCT4egoCnZ4axUq PAE+V4g8LfzINsjnOLrkVInzMoC36oOQ7Uh9Y21dNeBhQ8Ag2cZIpk+0F35nBhOVIhTLacJPgR6 bMm7Fzzhmx/g/xDkbNtiEUpJQ/HOQitlYJNTYRXwReBxnba8aHXBBt8gq/B8IJH56YsIYraqARN yg1VB+0Zx4wWktxxPf7IumdqiEf0= X-Google-Smtp-Source: AGHT+IG8J3er1iyXQBPMxITzMvfz9EFr3jDi7ygtRVXk9vTgIkpVU04qGBBpxMY6//a+NXkI/WoaMA== X-Received: by 2002:a05:6000:1786:b0:39c:1f02:449f with SMTP id ffacd0b85a97d-39d6fc00d2dmr6036975f8f.2.1744043267049; Mon, 07 Apr 2025 09:27:47 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec34a92desm134263455e9.14.2025.04.07.09.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 09:27:46 -0700 (PDT) Date: Mon, 7 Apr 2025 17:27:44 +0100 From: Daniel Thompson To: Pengyu Luo Cc: Jianhua Lu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 2/4] backlight: ktz8866: add slave handler Message-ID: References: <20250407095119.588920-1-mitltlatltl@gmail.com> <20250407095119.588920-3-mitltlatltl@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250407095119.588920-3-mitltlatltl@gmail.com> On Mon, Apr 07, 2025 at 05:51:17PM +0800, Pengyu Luo wrote: > Kinetic ktz8866, found in many android devices, nowadays, some oem use > dual ktz8866 to support a larger panel and higher brightness, original > driver would only handle half backlight region on these devices, > registering it twice is unreasonable, so adding the slave handler to > support it. Is there anything unique about KTZ8866 that allows it to be used like this? I think it would be better to add support for secondary backlight controllers into the backlight framework, rather than having to implement driver specific hacks for every backlight controller that appears in a primary/secondary configuration. Also, the kernel seeks to avoid adding new instances of master/slave terminology. See the coding style doc for suggested alternatives: https://www.kernel.org/doc/html/latest/process/coding-style.html#naming Daniel.