From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Marek Behún" <kabel@kernel.org>, "Lee Jones" <lee@kernel.org>,
"Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, "Gregory CLEMENT" <gregory.clement@bootlin.com>,
arm@kernel.org, "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH leds v2 08/11] leds: turris-omnia: Use dev_err_probe() where appropriate
Date: Tue, 3 Sep 2024 19:28:02 +0300 [thread overview]
Message-ID: <Ztc5ErXbwF7ElhDF@smile.fi.intel.com> (raw)
In-Reply-To: <224af639-babd-4d6e-813b-70fe07d5e337@lunn.ch>
On Tue, Sep 03, 2024 at 05:56:29PM +0200, Andrew Lunn wrote:
> On Tue, Sep 03, 2024 at 01:45:49PM +0300, Andy Shevchenko wrote:
> > On Tue, Sep 3, 2024 at 1:20 PM Marek Behún <kabel@kernel.org> wrote:
...
> > > + if (ret)
> > > + return dev_err_probe(dev, ret, "Cannot set LED %pOF to software mode\n", np);
> >
> > Side note: Not sure how np is being used besides the messaging. If
> > it's only for the messaging, I would rather see %pfw and fwnode based
> > approach.
>
> This board has a number of Ethernet switches described in DT. Nobody
> takes ACPI seriously for any sort of complex networking. So using
> fwnode is probably pointless, this board will probably never be used
> with anything other than DT.
Okay, fair enough!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-03 16:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 10:19 [PATCH leds v2 00/11] Turris Omnia LED driver changes Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 01/11] turris-omnia-mcu-interface.h: Move command execution function to global header Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 02/11] leds: turris-omnia: Use command execution functions from the MCU driver Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 03/11] turris-omnia-mcu-interface.h: Add LED commands related definitions to global header Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 04/11] leds: turris-omnia: Use global header for MCU command definitions Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 05/11] leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 06/11] platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 07/11] leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 08/11] leds: turris-omnia: Use dev_err_probe() where appropriate Marek Behún
2024-09-03 10:45 ` Andy Shevchenko
2024-09-03 15:56 ` Andrew Lunn
2024-09-03 16:28 ` Andy Shevchenko [this message]
2024-09-04 7:37 ` Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 09/11] leds: turris-omnia: Use uppercase first letter in all comments Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 10/11] leds: turris-omnia: Use 100 columns in the rest of the code Marek Behún
2024-09-03 13:21 ` Arnd Bergmann
2024-09-04 7:28 ` Marek Behún
2024-09-03 10:19 ` [PATCH leds v2 11/11] ARM: dts: turris-omnia: Add global LED brightness change interrupt Marek Behún
2024-09-03 14:26 ` [PATCH leds v2 00/11] Turris Omnia LED driver changes Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztc5ErXbwF7ElhDF@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sebastian.hesselbarth@gmail.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).